Skip to contentSkip to conversation

overlay filesystem fixes for 3.18

GIT PULL Miklos Szeredi 4 participants 8 messages Nov 20, 2014 – Nov 22, 2014 VFS

lore
Share & tools
lore
#0 lore raw

Hi Al,

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-current

The biggest change is to rename the filesystem from "overlayfs" to "overlay". This will allow legacy overlayfs to be easily carried by distros alongside the new mainline one. Also fix a couple of copy-up races and allow escaping comma character in filenames.

Thanks,
Miklos

---
Miklos Szeredi (8):
ovl: rename filesystem type to "overlay"
ovl: fix remove/copy-up race
ovl: fix race in private xattr checks
ovl: allow filenames with comma
ovl: use lockless_dereference() for upperdentry
ovl: pass dentry into ovl_dir_read_merged()
ovl: update MAINTAINERS
ovl: ovl_dir_fsync() cleanup

---
 Documentation/filesystems/overlayfs.txt |  2 +-
 MAINTAINERS                             |  7 ++--
 fs/Makefile                             |  2 +-
 fs/overlayfs/Kconfig                    |  2 +-
 fs/overlayfs/Makefile                   |  4 +--
 fs/overlayfs/dir.c                      | 31 ++++++++++-------
 fs/overlayfs/inode.c                    | 27 ++++++++++-----
 fs/overlayfs/readdir.c                  | 39 +++++++++------------
 fs/overlayfs/super.c                    | 61 ++++++++++++++++++++++++++-------
 9 files changed, 111 insertions(+), 64 deletions(-)
maintainer
#1 lore raw
Quoted 10 lines · Miklos Szeredi

Hi Al,

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-current

The biggest change is to rename the filesystem from "overlayfs" to "overlay". This will allow legacy overlayfs to be easily carried by distros alongside the new mainline one. Also fix a couple of copy-up races and allow escaping comma character in filenames.

Grabbed, will push after I get a bit of sleep (and the same regarding the review and comments on the other branch).

#2 lore raw
In reply to Miklos Szeredi
Quoted 6 lines · Miklos Szeredi

Hi Al,

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-current

This seems to be the place where overlayfs-fixes are collected for a git-pull request.
Can you add a "T:" line with the Git tree into MAINTAINERS file if this is the case?
If not please let the people know about current situation. Thanks.

- Sedat -

Quoted 34 lines

The biggest change is to rename the filesystem from "overlayfs" to "overlay". This will allow legacy overlayfs to be easily carried by distros alongside the new mainline one. Also fix a couple of copy-up races and allow escaping comma character in filenames.

Thanks,
Miklos

---
Miklos Szeredi (8):
ovl: rename filesystem type to "overlay"
ovl: fix remove/copy-up race
ovl: fix race in private xattr checks
ovl: allow filenames with comma
ovl: use lockless_dereference() for upperdentry
ovl: pass dentry into ovl_dir_read_merged()
ovl: update MAINTAINERS
ovl: ovl_dir_fsync() cleanup

---
 Documentation/filesystems/overlayfs.txt |  2 +-
 MAINTAINERS                             |  7 ++--
 fs/Makefile                             |  2 +-
 fs/overlayfs/Kconfig                    |  2 +-
 fs/overlayfs/Makefile                   |  4 +--
 fs/overlayfs/dir.c                      | 31 ++++++++++-------
 fs/overlayfs/inode.c                    | 27 ++++++++++-----
 fs/overlayfs/readdir.c                  | 39 +++++++++------------
 fs/overlayfs/super.c                    | 61 ++++++++++++++++++++++++++-------
 9 files changed, 111 insertions(+), 64 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 7 lines · Sedat Dilek
Quoted 2 lines

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-current

This seems to be the place where overlayfs-fixes are collected for a git-pull request.
Can you add a "T:" line with the Git tree into MAINTAINERS file if this is the case?

Done that already. See "ovl: update MAINTAINERS" patch in that series.

Thanks,
Miklos

#4 lore raw
Quoted 11 lines · Miklos Szeredi
Quoted 7 lines · Sedat Dilek
Quoted 2 lines

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-current

This seems to be the place where overlayfs-fixes are collected for a git-pull request.
Can you add a "T:" line with the Git tree into MAINTAINERS file if this is the case?

Done that already. See "ovl: update MAINTAINERS" patch in that series.

I asked for that a while ago.
"Done" is good to hear.

What about the other stuff (see my questions in [1])?

Thanks.

- Sedat -

[1] http://marc.info/?l=linux-kernel&m=141406538905679&w=1

#5 lore raw
In reply to Miklos Szeredi

Dear Miklos,

Quoted 4 lines · On Donnerstag, 20. November 2014 17:45:31 Miklos Szeredi wrote:

The biggest change is to rename the filesystem from "overlayfs" to "overlay". This will allow legacy overlayfs to be easily carried by distros alongside the new mainline one.

Would you kindly give a firm elaboration of this rename?

Why would a distro kernel maintainer want to keep the external overlayfs patches together with the now in kernel module?

Isn't it enough to drop the external patches from distro kernels in order to use it successfully or are there any semantic changes hidden that an admin should know about?

BTW: congrats to all involved parties. A layered filesystem finally arrived in the Linux kernel! This is a quantum leap for creative system architects.

Cheers,
Pete

proud user of aufs (and formerly unionfs) based fat diskless systems since about a decade.

#6 lore raw
Quoted 8 lines · Hans-Peter Jansen

Dear Miklos,

Quoted 4 lines · On Donnerstag, 20. November 2014 17:45:31 Miklos Szeredi wrote:

The biggest change is to rename the filesystem from "overlayfs" to "overlay". This will allow legacy overlayfs to be easily carried by distros alongside the new mainline one.

Quoted 8 lines

Would you kindly give a firm elaboration of this rename?

Why would a distro kernel maintainer want to keep the external overlayfs patches together with the now in kernel module?

Isn't it enough to drop the external patches from distro kernels in order to use it successfully or are there any semantic changes hidden that an admin should know about?

See this thread:

https://lkml.org/lkml/2014/11/18/433

Thanks,
Miklos

#7 lore raw
Quoted 9 lines · On Freitag, 21. November 2014 13:41:57 Miklos Szeredi wrote:
Quoted 8 lines · Hans-Peter Jansen

Dear Miklos,

Quoted 4 lines · On Donnerstag, 20. November 2014 17:45:31 Miklos Szeredi wrote:

The biggest change is to rename the filesystem from "overlayfs" to "overlay". This will allow legacy overlayfs to be easily carried by distros
alongside the new mainline one.

Quoted 6 lines
Quoted 2 lines

Would you kindly give a firm elaboration of this rename?

See this thread:

https://lkml.org/lkml/2014/11/18/433

Okay, thanks. I must have missed this one. "overlay" is as good as a name can be, IMHO.

Cheers,
Pete