net: mctp: tests: use actual address when creating dev with addr
Jeremy Kerr
maintainerPATCH 1/1 net: mctp: tests: use actual address when creating dev with addr
Sashiko reports:
Quoted 2 lines
This isn't a bug in the core networking code, but the addr parameter appears to be ignored here.
In mctp_test_create_dev_with_addr(), we are ignoring the addr argument and just using 8. Use the passed address instead.
All invocations use 8 anyway, so no effective change at present.
--- net/mctp/test/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/mctp/test/utils.c +1 -1
@@ -95,7 +95,7 @@ struct mctp_test_dev *mctp_test_create_dev_with_addr(mctp_eid_t addr) } dev->mdev->num_addrs =1 ; - dev->mdev->addrs[0 ] =8 ; + dev->mdev->addrs[0 ] = addr;return dev; }
---
base-commit: 8b0e64d6c9e7feec5ba5643b4fa8b7fd54464778
change-id: 20260403-dev-mctp-fix-test-addr-4ee89cf80edc
Best regards,
Signature · 1 line
Jeremy Kerr <[email protected]>
Quoted 5 lines · Jeremy Kerr
Sashiko reports:
Quoted 2 lines
This isn't a bug in the core networking code, but the addr parameter appears to be ignored here.
Quoted 7 lines
In
mctp_test_create_dev_with_addr(), we are ignoring the addr argument and just using8. Use the passed address instead.All invocations use 8 anyway, so no effective change at present.
Fixes 22cb45afd221 ("net: mctp: perform source address lookups when we populate our dst")Signed-off-by Jeremy Kerr <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Fri, 03 Apr 2026 10:21:04 +0800 you wrote:
Sashiko reports:
Quoted 2 lines
This isn't a bug in the core networking code, but the addr parameter appears to be ignored here.
In
mctp_test_create_dev_with_addr(), we are ignoring the addr argument and just using8. Use the passed address instead.[...]
Here is the summary with links:
- [net-next] net: mctp: tests: use actual address when creating dev with addr
https://git.kernel.org/netdev/net-next/c/70e32aadb5ca
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html