pull request (net-next): ipsec-next 2026-04-08
Subsystems (4)
Steffen Klassert
maintainercover pull request (net-next): ipsec-next 2026-04-08
1) Update outdated comment in xfrm_dst_check().
From kexinsun.
2) Drop support for HMAC-RIPEMD-160 from IPsec.
From Eric Biggers.
Please pull or let me know if there are problems.
Thanks!
The following changes since commit d2adf01780b8957b31f4954d56646b02de956f65:
net: freescale: ucc_geth: call of_node_put once (2026-02-24 18:26:30 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git tags/ipsec-next-2026-04-08
for you to fetch changes up to 05d42dc8ab92aa54aaeb1c033927c88fd2accba4:
xfrm: Drop support for HMAC-RIPEMD-160 (2026-04-07 10:47:58 +0200)
----------------------------------------------------------------
ipsec-next-2026-04-08
----------------------------------------------------------------
Eric Biggers (1):
xfrm: Drop support for HMAC-RIPEMD-160
kexinsun (1):
xfrm: update outdated comment
net/xfrm/xfrm_algo.c | 20 -------------------- net/xfrm/xfrm_policy.c | 2 +- tools/testing/selftests/net/ipsec.c | 8 ++------ 3 files changed, 3 insertions(+), 27 deletions(-)
Steffen Klassert
maintainerPATCH 1/2 xfrm: update outdated comment
From: kexinsun <[email protected]>
The function __xfrm4_bundle_create() was refactored into xfrm_bundle_create() (among others) by commit 25ee3286dcbc ("xfrm: Merge common code into xfrm_bundle_create"). The responsibility for setting dst->obsolete to DST_OBSOLETE_FORCE_CHK now lives in xfrm_bundle_create(). Update the comment accordingly.
--- net/xfrm/xfrm_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/xfrm/xfrm_policy.c +1 -1
@@ -3910,7 +3910,7 @@ EXPORT_SYMBOL(__xfrm_route_forward);static struct dst_entry *xfrm_dst_check (struct dst_entry *dst,u32 cookie) { -/* Code (such as __xfrm4_bundle_create()) sets dst->obsolete +/* Code (such as xfrm_bundle_create()) sets dst->obsolete * to DST_OBSOLETE_FORCE_CHK to force all XFRM destinations to * get validated by dst_ops->check on every use. We do this * because when a normal route referenced by an XFRM dst is
Signature · 1 line
2.43.0
Re: [PATCH 1/2] xfrm: update outdated comment
This series was applied to netdev/net-next.git (main) by Steffen Klassert <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (main) by Steffen Klassert <[email protected]>:
Quoted 9 lines · On Wed, 8 Apr 2026 11:42:40 +0200 you wrote:
From: kexinsun <[email protected]>
The function
__xfrm4_bundle_create()was refactored intoxfrm_bundle_create()(among others) by commit25ee3286dcbc("xfrm: Merge common code intoxfrm_bundle_create"). The responsibility for settingdst->obsoletetoDST_OBSOLETE_FORCE_CHKnow lives inxfrm_bundle_create(). Update the comment accordingly.[...]
Here is the summary with links:
- [1/2] xfrm: update outdated comment
https://git.kernel.org/netdev/net-next/c/be14d13625c9 - [2/2] xfrm: Drop support for HMAC-RIPEMD-160 https://git.kernel.org/netdev/net-next/c/05d42dc8ab92
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Steffen Klassert
maintainerPATCH 2/2 xfrm: Drop support for HMAC-RIPEMD-160
In reply to Steffen KlassertFrom: Eric Biggers <[email protected]>
Drop support for HMAC-RIPEMD-160 from IPsec to reduce the UAPI surface and simplify future maintenance. It's almost certainly unused.
RIPEMD-160 received some attention in the early 2000s when SHA-* weren't quite as well established. But it never received much adoption outside of certain niches such as Bitcoin.
It's actually unclear that Linux + IPsec + HMAC-RIPEMD-160 has *ever* been used, even historically. When support for it was added in 2003, it was done so in a "cleanup" commit without any justification [1]. It didn't actually work until someone happened to fix it 5 years later [2]. That person didn't use or test it either [3]. Finally, also note that "hmac(rmd160)" is by far the slowest of the algorithms in aalg_list[].
Of course, today IPsec is usually used with an AEAD, such as AES-GCM. But even for IPsec users still using a dedicated auth algorithm, they almost certainly aren't using, and shouldn't use, HMAC-RIPEMD-160.
Thus, let's just drop support for it. Note: no kconfig update is needed, since CRYPTO_RMD160 wasn't actually being selected anyway.
References:
[1] linux-history commit d462985fc1941a47
("[IPSEC]: Clean up key manager algorithm handling.")
[2] linux commit a13366c632132bb9
("xfrm: xfrm_algo: correct usage of RIPEMD-160")
[3] https://lore.kernel.org/all/[email protected]
--- net/xfrm/xfrm_algo.c | 20 -------------------- tools/testing/selftests/net/ipsec.c | 8 ++------ 2 files changed, 2 insertions(+), 26 deletions(-)
net/xfrm/xfrm_algo.c +0 -20
@@ -290,26 +290,6 @@ static struct xfrm_algo_desc aalg_list[] = { .sadb_alg_maxbits = 512 } }, -{ - .name = "hmac(rmd160)", - .compat = "rmd160", - - .uinfo = { - .auth = { - .icv_truncbits = 96, - .icv_fullbits = 160, - } - }, - - .pfkey_supported = 1, - - .desc = { - .sadb_alg_id = SADB_X_AALG_RIPEMD160HMAC, - .sadb_alg_ivlen = 0, - .sadb_alg_minbits = 160, - .sadb_alg_maxbits = 160 - } -}, { .name = "xcbc(aes)",
tools/testing/selftests/net/ipsec.c +2 -6
@@ -62,8 +62,6 @@#define VETH_FMT "ktst-%d"#define VETH_LEN 12 -#define XFRM_ALGO_NR_KEYS 29 -static int nsfd_parent =-1 ;static int nsfd_childa =-1 ;static int nsfd_childb =-1 ;
@@ -96,7 +94,6 @@ struct xfrm_key_entry xfrm_key_entries[] = { {"cbc(cast5)", 128}, {"cbc(serpent)", 128}, {"hmac(sha1)", 160}, - {"hmac(rmd160)", 160}, {"cbc(des3_ede)", 192}, {"hmac(sha256)", 256}, {"cbc(aes)", 256},
@@ -813,7 +810,7 @@ static int xfrm_fill_key(char *name, char *buf, {int i; -for (i =0 ; i <XFRM_ALGO_NR_KEYS ; i++) { +for (i =0 ; i <ARRAY_SIZE (xfrm_key_entries); i++) {if (strncmp (name, xfrm_key_entries[i].algo_name,ALGO_LEN ) ==0 ) *key_len = xfrm_key_entries[i].key_len; }
@@ -2061,8 +2058,7 @@ static int write_desc(int proto, int test_desc_fd,int proto_list[] = {IPPROTO_AH ,IPPROTO_COMP ,IPPROTO_ESP };char *ah_list[] = {"digest_null" ,"hmac(md5)" ,"hmac(sha1)" ,"hmac(sha256)" , -"hmac(sha384)" ,"hmac(sha512)" ,"hmac(rmd160)" , -"xcbc(aes)" ,"cmac(aes)" +"hmac(sha384)" ,"hmac(sha512)" ,"xcbc(aes)" ,"cmac(aes)" };char *comp_list[] = {"deflate" ,
Signature · 1 line
2.43.0