eth: fbnic: Use wake instead of start
Subsystems (3)
PATCH 1/1 eth: fbnic: Use wake instead of start
From: Mohsin Bashir <[email protected]>
fbnic_up() calls netif_tx_start_all_queues(), which only clears __QUEUE_STATE_DRV_XOFF. If qdisc backlog has accumulated on any TX queue before the reconfiguration (e.g. ring resize via ethtool -G), start does not call __netif_schedule() to kick the qdisc, so the pending backlog is never drained and the queue stalls.
Switch to netif_tx_wake_all_queues(), which clears DRV_XOFF and also calls __netif_schedule() on every queue, ensuring any backlog that built up before the down/up cycle is promptly dequeued.
--- drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/meta/fbnic/fbnic_pci.c +1 -1
@@ -139,7 +139,7 @@ void fbnic_up(struct fbnic_net *fbn)/* Enable Tx/Rx processing */ fbnic_napi_enable (fbn); -netif_tx_start_all_queues (fbn->netdev); +netif_tx_wake_all_queues (fbn->netdev);fbnic_service_task_start (fbn);
Signature · 1 line
2.52.0
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Tue, 7 Apr 2026 17:24:15 -0700 you wrote:
From: Mohsin Bashir <[email protected]>
fbnic_up()callsnetif_tx_start_all_queues(), which only clears__QUEUE_STATE_DRV_XOFF. If qdisc backlog has accumulated on any TX queue before the reconfiguration (e.g. ring resize via ethtool -G), start does not call__netif_schedule()to kick the qdisc, so the pending backlog is never drained and the queue stalls.[...]
Here is the summary with links:
- [net] eth: fbnic: Use wake instead of start
https://git.kernel.org/netdev/net/c/12ff2a4aee6c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html