bpf/selftests: remove test_access_variable_array
Subsystems (3)
PATCH 1/1 bpf/selftests: remove test_access_variable_array
test_access_variable_array relied on accessing struct sched_domain::span to validate variable-length array handling via BTF. Recent scheduler refactoring removed or hid this field, causing the test
to fail to build.
Given that this test depends on internal scheduler structures that are subject to refactoring, and equivalent variable-length array coverage already exists via bpf_testmod-based tests, remove test_access_variable_array entirely.
--- .../bpf/prog_tests/access_variable_array.c | 16 ---------------- .../bpf/progs/test_access_variable_array.c | 19 ------------------- 2 files changed, 35 deletions(-) delete mode 100644 tools/testing/selftests/bpf/prog_tests/access_variable_array.c delete mode 100644 tools/testing/selftests/bpf/progs/test_access_variable_array.c
tools/testing/selftests/bpf/prog_tests/access_variable_array.c deleted +0 -16
@@ -1,16 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright (c) 2022 Bytedance */ - -#include <test_progs.h> -#include "test_access_variable_array.skel.h" - -void test_access_variable_array (void ) -{ -struct test_access_variable_array *skel; - - skel =test_access_variable_array__open_and_load (); -if (!ASSERT_OK_PTR (skel,"test_access_variable_array__open_and_load" )) -return ; - -test_access_variable_array__destroy (skel); -}
tools/testing/selftests/bpf/progs/test_access_variable_array.c deleted +0 -19
@@ -1,19 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright (c) 2023 Bytedance */ - -#include "vmlinux.h" -#include <bpf/bpf_helpers.h> -#include <bpf/bpf_tracing.h> - -unsigned long span =0 ; - -SEC("fentry/sched_balance_rq") -int BPF_PROG (fentry_fentry ,int this_cpu,struct rq *this_rq, -struct sched_domain *sd) -{ - span = sd->span[0 ]; - -return 0 ; -} - -char _license[] SEC("license") = "GPL";
Signature · 1 line
2.45.2
Quoted 10 lines · Venkat Rao Bagalkote
test_access_variable_arrayrelied on accessing structsched_domain::spanto validate variable-length array handling via BTF. Recent scheduler refactoring removed or hid this field, causing the test
to fail to build.Given that this test depends on internal scheduler structures that are subject to refactoring, and equivalent variable-length array coverage already exists via bpf_testmod-based tests, remove
test_access_variable_arrayentirely.
Quoted 4 lines
Signed-off-by Venkat Rao Bagalkote <[email protected]>---
Hi,
Tested this patch and it is fixing the build issue.
Without this patch:
progs/test_access_variable_array.c:14:13: error:
no member named 'span' in 'struct sched_domain'
span = sd->span[0];
^~~~
With this patch above build is fixed
Please add below tag
Regards,
Naveen Kumar T
Quoted 53 lines
.../bpf/prog_tests/access_variable_array.c | 16 ---------------- .../bpf/progs/test_access_variable_array.c | 19 ------------------- 2 files changed, 35 deletions(-)delete mode 100644
tools/testing/selftests/bpf/prog_tests/access_variable_array.cdelete mode 100644tools/testing/selftests/bpf/progs/test_access_variable_array.ctools/testing/selftests/bpf/prog_tests/access_variable_array.c deleted +0
-16@@ -1,16 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright (c) 2022 Bytedance */ - -#include <test_progs.h> -#include "test_access_variable_array.skel.h" - -void test_access_variable_array (void ) -{ -struct test_access_variable_array *skel; - - skel =test_access_variable_array__open_and_load (); -if (!ASSERT_OK_PTR (skel,"test_access_variable_array__open_and_load" )) -return ; - -test_access_variable_array__destroy (skel); -}tools/testing/selftests/bpf/progs/test_access_variable_array.c deleted +0
-19@@ -1,19 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright (c) 2023 Bytedance */ - -#include "vmlinux.h" -#include <bpf/bpf_helpers.h> -#include <bpf/bpf_tracing.h> - -unsigned long span =0 ; - -SEC("fentry/sched_balance_rq") -int BPF_PROG (fentry_fentry ,int this_cpu,struct rq *this_rq, -struct sched_domain *sd) -{ - span = sd->span[0 ]; - -return 0 ; -} - -char _license[] SEC("license") = "GPL";
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 11 lines · On Fri, 10 Apr 2026 16:24:04 +0530 you wrote:
test_access_variable_arrayrelied on accessing structsched_domain::spanto validate variable-length array handling via BTF. Recent scheduler refactoring removed or hid this field, causing the test
to fail to build.Given that this test depends on internal scheduler structures that are subject to refactoring, and equivalent variable-length array coverage already exists via bpf_testmod-based tests, remove
test_access_variable_arrayentirely.[...]
Here is the summary with links:
- bpf/selftests: remove test_access_variable_array
https://git.kernel.org/bpf/bpf-next/c/aacee214d576
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html