net/sched: act_mirred: fix wrong device for mac_header_xmit check in tcf_blockcast_redir
Subsystems (3)
PATCH 1/1 net/sched: act_mirred: fix wrong device for mac_header_xmit check in tcf_blockcast_redir
In tcf_blockcast_redir(), when iterating block ports to redirect packets to multiple devices, the mac_header_xmit flag is queried from the wrong device. The loop sends to dev_prev but queries dev_is_mac_header_xmit(dev) — which is the NEXT device in the iteration, not the one being sent to.
This causes tcf_mirred_to_dev() to make incorrect decisions about whether to push or pull the MAC header. When the block contains mixed device types (e.g., an ethernet veth and a tunnel device), intermediate devices get the wrong mac_header_xmit flag, leading to skb header corruption. In the worst case, skb_push_rcsum with an incorrect mac_len can exhaust headroom and panic.
The last device in the loop is handled correctly (line 365-366 uses dev_is_mac_header_xmit(dev_prev)), confirming this is a copy-paste oversight for the intermediate devices.
Fix by using dev_prev instead of dev for the mac_header_xmit query, consistent with the device actually being sent to.
--- net/sched/act_mirred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sched/act_mirred.c +1 -1
@@ -354,7 +354,7 @@ static int tcf_blockcast_redir(struct sk_buff *skb, struct tcf_mirred *m, goto assign_prev;tcf_mirred_to_dev (skb, m, dev_prev, -dev_is_mac_header_xmit (dev), +dev_is_mac_header_xmit (dev_prev), mirred_eaction, retval); assign_prev: dev_prev = dev;
Signature · 1 line
2.39.3 (Apple Git-145)
Quoted 17 lines · Dudu Lu
In
tcf_blockcast_redir(), when iterating block ports to redirect packets to multiple devices, themac_header_xmitflag is queried from the wrong device. The loop sends todev_prevbut queriesdev_is_mac_header_xmit(dev)— which is the NEXT device in the iteration, not the one being sent to.This causes
tcf_mirred_to_dev()to make incorrect decisions about whether to push or pull the MAC header. When the block contains mixed device types (e.g., an ethernet veth and a tunnel device), intermediate devices get the wrongmac_header_xmitflag, leading to skb header corruption. In the worst case,skb_push_rcsumwith an incorrectmac_lencan exhaust headroom and panic.The last device in the loop is handled correctly (line 365-366 uses
dev_is_mac_header_xmit(dev_prev)), confirming this is a copy-paste oversight for the intermediate devices.
Quoted 5 lines
Fix by using
dev_previnstead of dev for themac_header_xmitquery, consistent with the device actually being sent to.Fixes 42f39036cda8 ("net/sched: act_mirred: Allow mirred to block")Signed-off-by Dudu Lu <[email protected]>
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 6 lines · On Mon, 13 Apr 2026 16:49:27 +0800 you wrote:
In
tcf_blockcast_redir(), when iterating block ports to redirect packets to multiple devices, themac_header_xmitflag is queried from the wrong device. The loop sends todev_prevbut queriesdev_is_mac_header_xmit(dev)— which is the NEXT device in the iteration, not the one being sent to.
Quoted 8 lines
This causes
tcf_mirred_to_dev()to make incorrect decisions about whether to push or pull the MAC header. When the block contains mixed device types (e.g., an ethernet veth and a tunnel device), intermediate devices get the wrongmac_header_xmitflag, leading to skb header corruption. In the worst case,skb_push_rcsumwith an incorrectmac_lencan exhaust headroom and panic.[...]
Here is the summary with links:
- net/sched: act_mirred: fix wrong device for mac_header_xmit check in tcf_blockcast_redir
https://git.kernel.org/netdev/net/c/4510d140524c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html