Bluetooth: btmtk: validate WMT event SKB length before struct access
Subsystems (3)
PATCH v4 1/1 Bluetooth: btmtk: validate WMT event SKB length before struct access
From: Tristan Madani <[email protected]>
btmtk_usb_hci_wmt_sync() casts the WMT event response SKB data to struct btmtk_hci_wmt_evt (7 bytes) and struct btmtk_hci_wmt_evt_funcc (9 bytes) without first checking that the SKB contains enough data. A short firmware response causes out-of-bounds reads from SKB tailroom.
Use skb_pull_data() to validate and advance past the base WMT event header. For the FUNC_CTRL case, pull the additional status field bytes before accessing them.
---
Changes in v4:
- Use skb_pull_data() instead of manual length checks, per Luiz Augusto von Dentz.
Changes in v3:
- CI all pass (CheckPatch, BuildKernel, CheckSparse, etc.).
drivers/bluetooth/btmtk.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
drivers/bluetooth/btmtk.c +13 -2
@@ -695,8 +695,13 @@ static int btmtk_usb_hci_wmt_sync(struct hci_dev *hdev,if (data->evt_skb ==NULL ) goto err_free_wc; -/* Parse and handle the return WMT event */ - wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data; + wmt_evt =skb_pull_data (data->evt_skb,sizeof (*wmt_evt)); +if (!wmt_evt) { +bt_dev_err (hdev,"WMT event too short (%u bytes)" , + data->evt_skb->len); + err = -EINVAL ; + goto err_free_skb; + }if (wmt_evt->whdr.op != hdr->op) {bt_dev_err (hdev,"Wrong op received %d expected %d" , wmt_evt->whdr.op, hdr->op);
@@ -712,6 +717,12 @@ static int btmtk_usb_hci_wmt_sync(struct hci_dev *hdev, status =BTMTK_WMT_PATCH_DONE ;break ;case BTMTK_WMT_FUNC_CTRL : +if (!skb_pull_data (data->evt_skb, +sizeof (wmt_evt_funcc->status))) { + err = -EINVAL ; + goto err_free_skb; + } + wmt_evt_funcc = (struct btmtk_hci_wmt_evt_funcc *)wmt_evt;if (be16_to_cpu (wmt_evt_funcc->status) ==0x404 ) status =BTMTK_WMT_ON_DONE ;
Signature · 1 line
2.47.3
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1083803
---Test result---
Test Summary:
CheckPatch PASS 0.55 seconds GitLint PASS 0.28 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 27.17 seconds CheckAllWarning PASS 29.25 seconds CheckSparse PASS 28.09 seconds BuildKernel32 PASS 26.72 seconds TestRunnerSetup PASS 587.86 seconds IncrementalBuild PASS 24.98 seconds
https://github.com/bluez/bluetooth-next/pull/109
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Tue, 21 Apr 2026 11:14:54 +0000 you wrote:
From: Tristan Madani <[email protected]>
btmtk_usb_hci_wmt_sync()casts the WMT event response SKB data to structbtmtk_hci_wmt_evt(7 bytes) and structbtmtk_hci_wmt_evt_funcc(9 bytes) without first checking that the SKB contains enough data. A short firmware response causes out-of-bounds reads from SKB tailroom.[...]
Here is the summary with links:
- [v4] Bluetooth: btmtk: validate WMT event SKB length before struct access
https://git.kernel.org/bluetooth/bluetooth-next/c/006b9943b982
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html