Skip to contentSkip to conversation

xserver-xf86-config: re-enable AutoAddDevices for beagleboard

PATCH In review Paul Eggleton 3 participants 4 messages May 29, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xserver-xf86-config: re-enable AutoAddDevices for beagleboard

This was added quite a long time ago because of poor interactions between HAL and the X server when it came to enabling input devices. HAL is long gone and I think it's safe to say we don't need to disable this any longer, especially as it gets in the way of being able to plug in the keyboard/mouse after boot.

(This has already effectively been removed for the other BSPs in meta-yocto-bsp).

Fixes [YOCTO #1823].

---
 .../xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf               | 1 -
 1 file changed, 1 deletion(-)
meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf +0 -1
index 0335e6a..264f3c9 100644
@@ -30,5 +30,4 @@ EndSection
 
 Section "ServerFlags"
 	Option		"DontZap"  "0"
-        Option		"AutoAddDevices" "False"
 EndSection
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 21 lines · Paul Eggleton

This was added quite a long time ago because of poor interactions between HAL and the X server when it came to enabling input devices. HAL is long gone and I think it's safe to say we don't need to disable this any longer, especially as it gets in the way of being able to plug in the keyboard/mouse after boot.

(This has already effectively been removed for the other BSPs in meta-yocto-bsp).

Fixes [YOCTO #1823].

---
 .../xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf               | 1 -
 1 file changed, 1 deletion(-)
meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf +0 -0
index 0335e6a..264f3c9 100644

meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf EndSection · line 33

Quoted 5 lines
meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf +0 -1
@@ -30,5 +30,4 @@ EndSection
 
 Section "ServerFlags"
        Option          "DontZap"  "0"
-        Option         "AutoAddDevices" "False"
 EndSection

Ross

#2 lore raw
In reply to Paul Eggleton
Quoted 10 lines · Paul Eggleton

This was added quite a long time ago because of poor interactions between HAL and the X server when it came to enabling input devices. HAL is long gone and I think it's safe to say we don't need to disable this any longer, especially as it gets in the way of being able to plug in the keyboard/mouse after boot.

(This has already effectively been removed for the other BSPs in meta-yocto-bsp).

Fixes [YOCTO #1823].

Doesn't this break touchscreen calibration? At least when I was adding it to my BSP it was also solving issues with xinput-calibrator expecting input devices with specified names (and autoadded were different)

Quoted 22 lines
---
 .../xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf               | 1 -
 1 file changed, 1 deletion(-)
meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf +0 -1
index 0335e6a..264f3c9 100644
@@ -30,5 +30,4 @@ EndSection
 
 Section "ServerFlags"
 	Option		"DontZap"  "0"
-        Option		"AutoAddDevices" "False"
 EndSection
Signature · 6 lines
1.8.1.2

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 7 lines · On Wednesday 29 May 2013 17:56:24 Martin Jansa wrote:
Quoted 6 lines · Paul Eggleton

This was added quite a long time ago because of poor interactions between HAL and the X server when it came to enabling input devices. HAL is long gone and I think it's safe to say we don't need to disable this any longer, especially as it gets in the way of being able to plug in the keyboard/mouse after boot.

Quoted 6 lines
Quoted 4 lines

(This has already effectively been removed for the other BSPs in meta-yocto-bsp).

Fixes [YOCTO #1823].

Doesn't this break touchscreen calibration?

I'd hope not...

Quoted 3 lines

At least when I was adding it to my BSP it was also solving issues with xinput-calibrator expecting input devices with specified names (and autoadded were different)

Surely that's a deficiency in xinput-calibrator that should be fixed there if it is still a problem?

I didn't mention it in the commit message, but FWIW I did look at the meta-ti xorg.conf files and they don't have this line.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre