selftests: drv-net: clarify linters and frameworks in README
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 selftests: drv-net: clarify linters and frameworks in README
Minor clarifications in the README:
- call out what linters we expect to be clean
- make it clear that by "frameworks" we mean code under lib/ not just factoring code out in the same file
Signed-off-by Jakub Kicinski <[email protected]>
---
CC: [email protected]
CC: [email protected]
--- tools/testing/selftests/drivers/net/README.rst | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
tools/testing/selftests/drivers/net/README.rst +8 -2
@@ -211,8 +211,8 @@ Avoid libraries and frameworks Test files should be relatively self contained. The libraries should only include very core or non-trivial code. -It may be tempting to "factor out" the common code, but fight that urge. -Library code increases the barrier of entry, and complexity in general. +It may be tempting to "factor out" the common code to lib/py/, but fight that +urge. Library code increases the barrier of entry, and complexity in general. Avoid mixing test code and boilerplate ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -290,6 +290,12 @@ decorator can be a list or a generator. def test(cfg, mode, protocol): pass +Linters +~~~~~~~ + +We expect clean ``ruff check`` and ``pylint --disable=R``. +The code should be clean, avoid disabling pylint warnings explicitly! + Running tests CI-style ======================
Signature · 1 line
2.54.0
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Tue, 28 Apr 2026 13:33:57 -0700 you wrote:
Minor clarifications in the README:
- call out what linters we expect to be clean
- make it clear that by "frameworks" we mean code underlib/not just factoring code out in the same fileSigned-off-by Jakub Kicinski <[email protected]>[...]
Here is the summary with links:
- [net-next] selftests: drv-net: clarify linters and frameworks in README
https://git.kernel.org/netdev/net/c/72e9647e2b20
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html