net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising
Subsystems (3)
PATCH 1/1 net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising
When configuring the link parameters in forced mode for the AQR-105, the Extended Next Page bit gets advertised for Multi-Gigabit modes.
This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as the Extended Next Page advertising. This bit used to be marked as reserved, but a proper define for it was added in :
commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")
Let's use it instead of the ADVERTISE_RESV definition, making the code more self-documenting.
--- drivers/net/phy/aquantia/aquantia_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/phy/aquantia/aquantia_main.c +3 -3
@@ -385,15 +385,15 @@ static int aqr105_setup_forced(struct phy_device *phydev) vend |=MDIO_AN_VEND_PROV_1000BASET_HALF ;break ;case SPEED_2500 : - adv |= (ADVERTISE_NPAGE |ADVERTISE_RESV ); + adv |= (ADVERTISE_NPAGE |ADVERTISE_XNP ); vend |=MDIO_AN_VEND_PROV_2500BASET_FULL ;break ;case SPEED_5000 : - adv |= (ADVERTISE_NPAGE |ADVERTISE_RESV ); + adv |= (ADVERTISE_NPAGE |ADVERTISE_XNP ); vend |=MDIO_AN_VEND_PROV_5000BASET_FULL ;break ;case SPEED_10000 : - adv |= (ADVERTISE_NPAGE |ADVERTISE_RESV ); + adv |= (ADVERTISE_NPAGE |ADVERTISE_XNP ); ctrl10 |=MDIO_AN_10GBT_CTRL_ADV10G ;break ;default :
Signature · 1 line
2.49.0
Quoted 8 lines · Maxime Chevallier
When configuring the link parameters in forced mode for the AQR-105, the Extended Next Page bit gets advertised for Multi-Gigabit modes.
This is done through bit 12 of
MDIO_AN_ADVERTISEinMDIO_MMD_AN. This contains a copy of theMII_ADVERTISE, for which 802.3 defines bit 12 as the Extended Next Page advertising. This bit used to be marked as reserved, but a proper define for it was added in :
Quoted 6 lines
commit
e7a62edd34b1("net: phy: qcom: at803x: Use the correct bit to disable extended next page")Let's use it instead of the
ADVERTISE_RESVdefinition, making the code more self-documenting.Signed-off-by Maxime Chevallier <[email protected]>
Andrew
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Tue, 28 Apr 2026 14:58:27 +0200 you wrote:
When configuring the link parameters in forced mode for the AQR-105, the Extended Next Page bit gets advertised for Multi-Gigabit modes.
This is done through bit 12 of
MDIO_AN_ADVERTISEinMDIO_MMD_AN. This contains a copy of theMII_ADVERTISE, for which 802.3 defines bit 12 as the Extended Next Page advertising. This bit used to be marked as reserved, but a proper define for it was added in :[...]
Here is the summary with links:
- [net-next] net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising
https://git.kernel.org/netdev/net-next/c/e2d217fe3ff2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html