Skip to contentSkip to conversation

net: ethernet: cs89x0: remove stale CONFIG_MACH_MX31ADS reference

PATCH Applied Ethan Nelson-Moore 2 participants 2 messages May 9 – May 12

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ethernet: cs89x0: remove stale CONFIG_MACH_MX31ADS reference

The legacy ARM board file for MACH_MX31ADS was removed in commit c93197b0041d ("ARM: imx: Remove i.MX31 board files"), but a reference to it remained in the cs89x0 driver. Drop this unused code.

---
I found this issue while working on updating arch/arm/tools/mach-types to remove entries for board files that are not in the kernel - this reference caused my script to consider MACH_MX31ADS to be present in the kernel.

 drivers/net/ethernet/cirrus/cs89x0.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/cirrus/cs89x0.c +0 -2
index fa5857923db4..b4bfd6c174e7 100644
@@ -1271,7 +1271,6 @@ static const struct net_device_ops net_ops = {
 
 static void __init reset_chip(struct net_device *dev)
 {
-#if !defined(CONFIG_MACH_MX31ADS)
 	struct net_local *lp = netdev_priv(dev);
 	unsigned long reset_start_time;
 
@@ -1298,7 +1297,6 @@ static void __init reset_chip(struct net_device *dev)
 	while ((readreg(dev, PP_SelfST) & INIT_DONE) == 0 &&
 	       time_before(jiffies, reset_start_time + 2))
 		;
-#endif /* !CONFIG_MACH_MX31ADS */
 }
 
 /* This is the real probe routine.
Signature · 1 line
2.43.0
#1 lore raw
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:

Quoted 4 lines · On Fri, 8 May 2026 19:37:28 -0700 you wrote:

The legacy ARM board file for MACH_MX31ADS was removed in commit c93197b0041d ("ARM: imx: Remove i.MX31 board files"), but a reference to it remained in the cs89x0 driver. Drop this unused code.

Quoted 8 lines

---
I found this issue while working on updating arch/arm/tools/mach-types to remove entries for board files that are not in the kernel - this reference caused my script to consider MACH_MX31ADS to be present in the kernel.

[...]

Here is the summary with links:
- net: ethernet: cs89x0: remove stale CONFIG_MACH_MX31ADS reference

    https://git.kernel.org/netdev/net/c/36a8d04a8293

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html