Skip to contentSkip to conversation

arm64: dts/bindings: Add support for BeagleBadge

PATCH Superseded Judith Mendez 3 participants 7 messages May 8 – May 13

Subsystems (2)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v2 cover arm64: dts/bindings: Add support for BeagleBadge

Hi,

BeagleBoard.org BeagleBadge[1] is a compact, affordable open source hardware [2] single board computer based on the Texas Instruments AM62L3 SoC designed for IoT and embedded applications. Add base support for the same.

SD boot:

This patch series adds:
- Device tree bindings update for am62l3-badge
- Device tree source for BeagleBadge board
- Defconfig: drivers for BeagleBadge

Changelog:
Binding:
- Update compatible to: beagle,am62l3-beaglebadge
DTS:
- Add thermal zones
- Move pinmux definitions from consumer nodes to base controller nodes
- Define GPIOs for each of use: BOOST_5V_ENA, USB_HUB_RST, MIKROBUS_RST
- Add Andrew's sign-off tag
Defconfig:
- Add defconfig patch which enables drivers as modules for beaglebadge

Patch series depends on:
- "pinctrl: mcp23s08: Initialize mcp->dev and mcp->addr before regmap init"
- Link: https://lore.kernel.org/all/[email protected]

[0] https://beagleboard.org/
[1] https://www.beagleboard.org/boards/beaglebadge
[2] https://github.com/beagleboard/BeagleBadge/blob/main/design/BeagleBadge_RevA_V0.7_SCH_251107.pdf

Judith Mendez (3):
dt-bindings: arm: ti: Add am62l3-beaglebadge
arm64: dts: ti: Add k3-am62l3-beaglebadge
arm64: defconfig: Enable drivers for BeagleBadge

 .../devicetree/bindings/arm/ti/k3.yaml        |   1 +
 arch/arm64/boot/dts/ti/Makefile               |   1 +
 .../boot/dts/ti/k3-am62l3-beaglebadge.dts     | 702 ++++++++++++++++++
 arch/arm64/configs/defconfig                  |   5 +
 4 files changed, 709 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts
Signature · 1 line
2.54.0
#1 lore raw

PATCH v2 1/3 dt-bindings: arm: ti: Add am62l3-beaglebadge

This board is based on ti,am62l3.

https://beagleboard.org
https://github.com/beagleboard/BeagleBadge

---
Changelog:
- Update compatible to: beagle,am62l3-beaglebadge

---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/ti/k3.yaml +1 -0
index 2a6a9441c23d..d9cd3fb712fd 100644
@@ -40,6 +40,7 @@ properties:
       - description: K3 AM62L3 SoC and Boards
         items:
           - enum:
+              - beagle,am62l3-beaglebadge
               - ti,am62l3-evm
           - const: ti,am62l3
 
Signature · 1 line
2.54.0
maintainer Acked-by on v2 1/3
#2 lore raw

Re: [PATCH v2 1/3] dt-bindings: arm: ti: Add am62l3-beaglebadge

Quoted 4 lines · Judith Mendez

This board is based on ti,am62l3.

https://beagleboard.org
https://github.com/beagleboard/BeagleBadge

Quoted 8 lines

---
Changelog:
- Update compatible to: beagle,am62l3-beaglebadge

---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)
#3 lore raw

PATCH v2 2/3 arm64: dts: ti: Add k3-am62l3-beaglebadge

In reply to Judith Mendez

BeagleBoard.org BeagleBadge is a compact, affordable open source hardware single board computer based on the Texas Instruments AM62L3 SoC designed for IoT and embedded applications with low power consumption. Expansion is provided over open standards based headers including QWIIC and GPIO interfaces.

https://beagleboard.org
https://github.com/beagleboard/BeagleBadge

---
Changelog:
- Add thermal zones
- Move pinmux definitions from consumer nodes to base controller nodes
- Define GPIOs for each of use: BOOST_5V_ENA, USB_HUB_RST, MIKROBUS_RST

---
 arch/arm64/boot/dts/ti/Makefile               |   1 +
 .../boot/dts/ti/k3-am62l3-beaglebadge.dts     | 702 ++++++++++++++++++
 2 files changed, 703 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts
arch/arm64/boot/dts/ti/Makefile +1 -0
index 5269c9619b65..4e377ca011cd 100644
@@ -41,6 +41,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62d2-evm.dtb
 
 # Boards with AM62Lx SoCs
 dtb-$(CONFIG_ARCH_K3) += k3-am62l3-evm.dtb
+dtb-$(CONFIG_ARCH_K3) += k3-am62l3-beaglebadge.dtb
 
 # Boards with AM62Px SoC
 dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +702 -0

702 lines not on this page · raw message

Signature · 1 line
2.54.0
#4 lore raw

Re: [PATCH v2 2/3] arm64: dts: ti: Add k3-am62l3-beaglebadge

Thank you for your contribution! Sashiko AI review found 6 potential issue(s) to consider: - [High] Incorrect muxmode for MCP23S18 reset pin - [Medium] Invalid PWM period for multicolor RGB LEDs…

Thank you for your contribution! Sashiko AI review found 6 potential issue(s) to consider:
- [High] Incorrect muxmode for MCP23S18 reset pin
- [Medium] Invalid PWM period for multicolor RGB LEDs
- [Medium] Over-voltage input configuration for 3.3V load switch
- [Low] Device Tree schema violation in microchip,spi-present-mask
- [Low] Unnecessary address and size cells in sdhci2 node
- [Low] Typo in gpio-line-names
--

commit 7f076ae76f17c0b92ffa0b772d551d80e949dbd9
Author: Judith Mendez <[email protected]>

arm64: dts: ti: Add k3-am62l3-beaglebadge

BeagleBoard.org BeagleBadge is a compact, affordable open source hardware single board computer based on the Texas Instruments AM62L3 SoC. Expansion is provided over open standards based headers including QWIIC and GPIO interfaces.

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +0 -0
new file mode 100644
index 0000000000000..2bbced7bc2c9d

[ ... ]

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 112

Quoted 9 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +9 -0
+	multicolor-led {
+		compatible = "pwm-leds-multicolor";
+
+		multi-led {
+			color = <LED_COLOR_ID_RGB>;
+			max-brightness = <255>;
+
+			led-red {
+				pwms = <&ecap2 0 255 0>;

Is 255 nanoseconds the correct PWM period here?

This translates to a frequency of ~3.9 MHz, which is far too fast for LED brightness control and provides virtually no duty cycle resolution.

Was the max-brightness value (255) incorrectly copied into the PWM period cell?

[ ... ]

Quoted 20 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +20 -0
+	vsys_out: regulator-0 {
+		/* output of BQ24070 */
+		compatible = "regulator-fixed";
+		regulator-name = "VSYS_OUT";
+		regulator-min-microvolt = <4400000>;
+		regulator-max-microvolt = <4400000>;
+		regulator-always-on;
+		regulator-boot-on;
+		bootph-all;
+	};
+
+	vcc_3v3_main: regulator-1 {
+		/* output of TPS62A06 */
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_3V3_MAIN";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vsys_out>;
+		regulator-always-on;
+		regulator-boot-on;

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 187

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +10 -0
+		bootph-all;
+	};
+
+	vdd_3v3: regulator-2 {
+		/* output of TPS22965 */
+		compatible = "regulator-fixed";
+		regulator-name = "VDD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vsys_out>;

Should this load switch be connected to &vcc_3v3_main instead of &vsys_out?

Since it is a load switch, its output voltage matches its input voltage. Connecting its vin-supply to &vsys_out (4.4V) contradicts the node's regulator-max-microvolt = <3300000> configuration, causing it to pass 4.4V to a 3.3V rail.

[ ... ]

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 410

Quoted 3 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +3 -0
+	mcp23s18_reset_pins_default: mcp23s18-reset-default-pins {
+		pinctrl-single,pins = <
+			AM62LX_IOPAD(0x00a0, PIN_OUTPUT, 4) /* (H21) GPMC0_AD10.GPIO0_25 */

Does this pin need to be configured for muxmode 7?

The comments and the reset-gpios property of the mcp23s18 node expect this pin to act as GPIO0_25. On AM62Lx SoCs, the GPIO function is located at muxmode 7.

With muxmode 4, the pad won't be connected to the GPIO controller, and the GPIO expander will remain in reset.

[ ... ]

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 576

Quoted 6 lines

+&gpio0 {

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +5 -0
+	gpio-line-names ="","","","","","","","","","",									/* 0-9 */
+			 "","","","","","BOOST_5V_ENA","VDD_3V3_SD_ENA","","","",					/* 10-19 */
+			 "","","","","","MCP23S18_RESET","BTN_SELECT","","","",						/* 20-29 */
+			 "","BTN_LEFT","BTN_UP","","LORA_RESET","","","","","",						/* 30-39 */
+			 "FUEL_GUAGE_BATLOW","LORA_RFSW","BTN_DOWN","USB_HUB_RST","MIKROBUS_INT","","","","","",	/* 40-49 */

This isn't a bug, but there's a typo (FUEL_GUAGE_BATLOW) in the line name.

[ ... ]

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 617

Quoted 8 lines

+&sdhci2 {

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +7 -0
+	vmmc-supply = <&wlan_en>;
+	bus-width = <4>;
+	non-removable;
+	cap-power-off-card;
+	keep-power-in-suspend;
+	#address-cells = <1>;
+	#size-cells = <0>;

Are these #address-cells and #size-cells properties needed here?

Since the sdhci2 node contains no child nodes, this will trigger an avoid_unnecessary_addr_size dtc warning.

[ ... ]

Quoted 5 lines

+&spi1 {

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +4 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi1_pins_default>;
+	status = "okay";
+

arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts line 694

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts new file +10 -0
+	mcp23s18: gpio@0 {
+		compatible = "microchip,mcp23s18";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		reset-gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mcp23s18_reset_pins_default>;
+		microchip,spi-present-mask = <0x01>;

Should microchip,spi-present-mask be formatted as /bits/ 8 <0x01>?

The microchip,mcp23s08.yaml device tree binding schema requires this property to be a uint8, so keeping it as a 32-bit cell will trigger a dt_binding_check validation error.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#5 lore raw

PATCH v2 3/3 arm64: defconfig: Enable drivers for BeagleBadge

In reply to Judith Mendez

Enable drivers used on BeagleBadge[1]:
- LED PWM Multicolor driver as a module
- MCP SPI IO Expander driver as a module
- Seven Segment display GPIO driver as module
- Temperature Sensor driver as a module

[1] https://github.com/beagleboard/BeagleBadge

---
Changelog:
- Add defconfig patch which enables drivers as modules for beaglebadge

---
 arch/arm64/configs/defconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/configs/defconfig +5 -0
index d905a0777f93..0e4cf5e01146 100644
@@ -634,6 +634,7 @@ CONFIG_PINCTRL_BRCMSTB=y
 CONFIG_PINCTRL_BCM2712=y
 CONFIG_PINCTRL_DA9062=m
 CONFIG_PINCTRL_MAX77620=y
+CONFIG_PINCTRL_MCP23S08=m
 CONFIG_PINCTRL_RK805=m
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_PINCTRL_SX150X=m
@@ -764,6 +765,7 @@ CONFIG_SENSORS_MACSMC_HWMON=m
 CONFIG_SENSORS_LM75=m
 CONFIG_SENSORS_LM90=m
 CONFIG_SENSORS_PWM_FAN=m
+CONFIG_SENSORS_SHT4x=m
 CONFIG_SENSORS_RASPBERRYPI_HWMON=m
 CONFIG_SENSORS_SL28CPLD=m
 CONFIG_SENSORS_AMC6821=m
@@ -955,6 +957,8 @@ CONFIG_VIDEO_IMX412=m
 CONFIG_VIDEO_OV5640=m
 CONFIG_VIDEO_OV5645=m
 CONFIG_VIDEO_S5KJN1=m
+CONFIG_AUXDISPLAY=y
+CONFIG_SEG_LED_GPIO=m
 CONFIG_DRM=m
 CONFIG_DRM_I2C_NXP_TDA998X=m
 CONFIG_DRM_HDLCD=m
@@ -1333,6 +1337,7 @@ CONFIG_LEDS_PWM=y
 CONFIG_LEDS_SYSCON=y
 CONFIG_LEDS_QCOM_FLASH=m
 CONFIG_LEDS_QCOM_LPG=m
+CONFIG_LEDS_PWM_MULTICOLOR=m
 CONFIG_LEDS_TRIGGER_TIMER=y
 CONFIG_LEDS_TRIGGER_DISK=y
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
Signature · 1 line
2.54.0
#6 lore raw

Re: [PATCH v2 3/3] arm64: defconfig: Enable drivers for BeagleBadge

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added configurations `CONFIG_SENSORS_SHT4x` and `CONFIG_LEDS_PWM_MULTICOLOR` are not…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added configurations CONFIG_SENSORS_SHT4x and CONFIG_LEDS_PWM_MULTICOLOR are not placed in the correct savedefconfig sequence. --

commit 6f7a4afa4cd800dc21fa4233eabb09b5e3390bc1
Author: Judith Mendez <[email protected]>

arm64: defconfig: Enable drivers for BeagleBadge

This commit enables several drivers as modules or built-in for the BeagleBadge device. The enabled drivers include LED PWM Multicolor, MCP SPI IO Expander, Seven Segment display GPIO, and Temperature Sensor.

Quoted 4 lines
arch/arm64/configs/defconfig +0 -0
index d905a0777f939..0e4cf5e01146f 100644

[ ... ]

arch/arm64/configs/defconfig CONFIG_SENSORS_MACSMC_HWMON=m · line 768

Quoted 5 lines
arch/arm64/configs/defconfig +1 -0
@@ -764,6 +765,7 @@ CONFIG_SENSORS_MACSMC_HWMON=m
 CONFIG_SENSORS_LM75=m
 CONFIG_SENSORS_LM90=m
 CONFIG_SENSORS_PWM_FAN=m
+CONFIG_SENSORS_SHT4x=m

This isn't a bug, but was this defconfig updated using make savedefconfig?

Manual insertions can disrupt the canonical Kconfig parsing order. Based on the definitions in drivers/hwmon/Kconfig, SENSORS_SHT4x is defined after SENSORS_SL28CPLD and before SENSORS_AMC6821, so its proper canonical placement would be between those two entries.

Quoted 3 lines
arch/arm64/configs/defconfig +0 -0
 CONFIG_SENSORS_RASPBERRYPI_HWMON=m
 CONFIG_SENSORS_SL28CPLD=m
 CONFIG_SENSORS_AMC6821=m

[ ... ]

arch/arm64/configs/defconfig CONFIG_LEDS_PWM=y · line 1340

Quoted 5 lines
arch/arm64/configs/defconfig +1 -0
@@ -1333,6 +1337,7 @@ CONFIG_LEDS_PWM=y
 CONFIG_LEDS_SYSCON=y
 CONFIG_LEDS_QCOM_FLASH=m
 CONFIG_LEDS_QCOM_LPG=m
+CONFIG_LEDS_PWM_MULTICOLOR=m

Similarly, should CONFIG_LEDS_PWM_MULTICOLOR precede CONFIG_LEDS_QCOM_LPG to match the order in drivers/leds/rgb/Kconfig?

Quoted 3 lines
arch/arm64/configs/defconfig +0 -0
 CONFIG_LEDS_TRIGGER_TIMER=y
 CONFIG_LEDS_TRIGGER_DISK=y
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3