Skip to contentSkip to conversation

dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility

PATCH Applied [email protected] 2 participants 2 messages Jun 2 – Jun 4

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility

From: Zhi Li <[email protected]>

Commit c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets") added two optional cells to eswin,hsp-sp-csr but omitted minItems: 4.

As a result, dt-schema implicitly required all 6 cells, which broke backward compatibility with existing 4-cell device trees.

Add minItems: 4 to preserve backward compatibility.

Fixes c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets")

---
Changes in v3:
- Fix commit reference format reported by checkpatch.pl.
- No functional change.
- Link to v2:

    https://lore.kernel.org/lkml/[email protected]/
---
 Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml +2 -1
index b66ae6300faf..65882ff79d8d 100644
@@ -84,7 +84,8 @@ properties:
       This reference is provided for background information only.
     $ref: /schemas/types.yaml#/definitions/phandle-array
     items:
-      - items:
+      - minItems: 4
+        items:
           - description: Phandle to HSP(High-Speed Peripheral) device
           - description: Offset of phy control register for internal
                          or external clock selection
Signature · 1 line
2.25.1
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Tue, 2 Jun 2026 09:45:28 +0800 you wrote:

From: Zhi Li <[email protected]>

Commit c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets") added two optional cells to eswin,hsp-sp-csr but omitted minItems: 4.

As a result, dt-schema implicitly required all 6 cells, which broke backward compatibility with existing 4-cell device trees.

[...]

Here is the summary with links:
- [net,v3] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility

    https://git.kernel.org/netdev/net/c/1232b3104b4b

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html