net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails
Subsystems (4)
Lorenzo Bianconi
maintainerPATCH 1/1 net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails
Report an extack error message in airoha_tc_htb_modify_queue routine if airoha_qdma_set_tx_rate_limit() fails.
--- drivers/net/ethernet/airoha/airoha_eth.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/net/ethernet/airoha/airoha_eth.c +7 -1
@@ -2605,13 +2605,19 @@ static int airoha_tc_htb_modify_queue(struct net_device *dev, {u32 channel =TC_H_MIN (opt->classid) %AIROHA_NUM_QOS_CHANNELS ;u32 rate =div_u64 (opt->rate,1000 ) <<3 ;/* kbps */ +int err;if (opt->parent_classid !=TC_HTB_CLASSID_ROOT ) {NL_SET_ERR_MSG_MOD (opt->extack,"invalid parent classid" );return -EINVAL ; } -return airoha_qdma_set_tx_rate_limit (dev, channel, rate, opt->quantum); + err =airoha_qdma_set_tx_rate_limit (dev, channel, rate, opt->quantum); +if (err) +NL_SET_ERR_MSG_MOD (opt->extack, +"failed configuring htb offload" ); + +return err; } static int airoha_tc_htb_alloc_leaf_queue(struct net_device *netdev,
---
base-commit: dfcc2ff12925d99e858eaf539eaa4aaaf81fe2a6
change-id: 20260603-airoha_tc_htb_modify_queue-err-message-fea72af2c4b6
Best regards,
Signature · 1 line
Lorenzo Bianconi <[email protected]>
From: Lorenzo Bianconi <[email protected]>
Date: Wed, 03 Jun 2026 12:30:01 +0200
Quoted 4 lines
Report an extack error message in
airoha_tc_htb_modify_queueroutine ifairoha_qdma_set_tx_rate_limit()fails.Signed-off-by Lorenzo Bianconi <[email protected]>
Quoted 19 lines
--- drivers/net/ethernet/airoha/airoha_eth.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)drivers/net/ethernet/airoha/airoha_eth.c +1
-0@@ -2605,13 +2605,19 @@ static int airoha_tc_htb_modify_queue(struct net_device *dev, {u32 channel =TC_H_MIN (opt->classid) %AIROHA_NUM_QOS_CHANNELS ;u32 rate =div_u64 (opt->rate,1000 ) <<3 ;/* kbps */ +int err;if (opt->parent_classid !=TC_HTB_CLASSID_ROOT ) {NL_SET_ERR_MSG_MOD (opt->extack,"invalid parent classid" );return -EINVAL ; }
drivers/net/ethernet/airoha/airoha_eth.c static int airoha_tc_htb_modify_queue(struct net_device *dev, · line 2623
Quoted 10 lines
drivers/net/ethernet/airoha/airoha_eth.c +6
-1-return airoha_qdma_set_tx_rate_limit (dev, channel, rate, opt->quantum); + err =airoha_qdma_set_tx_rate_limit (dev, channel, rate, opt->quantum); +if (err) +NL_SET_ERR_MSG_MOD (opt->extack, +"failed configuring htb offload" ); + +return err; } static int airoha_tc_htb_alloc_leaf_queue(struct net_device *netdev,
Thanks,
Olek
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 03 Jun 2026 12:30:01 +0200 you wrote:
Report an extack error message in
airoha_tc_htb_modify_queueroutine ifairoha_qdma_set_tx_rate_limit()fails.Signed-off-by Lorenzo Bianconi <[email protected]>--- drivers/net/ethernet/airoha/airoha_eth.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)[...]
Here is the summary with links:
- [net-next] net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails
https://git.kernel.org/netdev/net-next/c/144969cd80c5
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html