Skip to contentSkip to conversation

bpftool build: Restrict feature tests during bootstrap compilation

PATCH Applied Ian Rogers 3 participants 3 messages May 31 – Jun 5

Subsystems (2)
lore
Share & tools
lore

Ian Rogers

author
#0 lore raw

PATCH 1/1 bpftool build: Restrict feature tests during bootstrap compilation

When the perf build executes 'make -C ../bpf/bpftool bootstrap', bpftool's Makefile unconditionally evaluated feature checks for llvm, libcap, libbfd, and disassembler libraries because the bootstrap target was not exempted.

Since the bootstrap bpftool strictly compiles minimal AST parsing and C code generation logic without linking LLVM or disassembler libraries, these feature check sub-makes are completely redundant.

Exempt the bootstrap target from non-essential feature tests to eliminate unneeded sub-make fork overhead during Kbuild startup.

Assisted-by Gemini:gemini-3.1-pro-preview

---
This patch originally appeared in the now merged perf patch series:
https://lore.kernel.org/linux-perf-users/[email protected]/

---
 tools/bpf/bpftool/Makefile | 5 +++++
 1 file changed, 5 insertions(+)
tools/bpf/bpftool/Makefile +5 -0
index 0febf60e1b64..8f50bc163bb2 100644
@@ -106,6 +106,10 @@ ifneq ($(SKIP_CRYPTO),1)
   CRYPTO_LIBS := -lcrypto
 endif
 
+ifeq ($(MAKECMDGOALS),bootstrap)
+FEATURE_TESTS := libelf-zstd
+FEATURE_DISPLAY :=
+else
 FEATURE_TESTS := clang-bpf-co-re
 FEATURE_TESTS += llvm
 FEATURE_TESTS += libcap
@@ -122,6 +126,7 @@ FEATURE_DISPLAY += libcap
 FEATURE_DISPLAY += libbfd
 FEATURE_DISPLAY += libbfd-liberty
 FEATURE_DISPLAY += libbfd-liberty-z
+endif
 
 check_feat := 1
 NON_CHECK_FEAT_TARGETS := clean uninstall doc doc-clean doc-install doc-uninstall
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
maintainer Acked-by on v1 1/1
#1 lore raw

2026-05-30 18:07 UTC-0700 ~ Ian Rogers <[email protected]>

Quoted 8 lines

When the perf build executes 'make -C ../bpf/bpftool bootstrap', bpftool's Makefile unconditionally evaluated feature checks for llvm, libcap, libbfd, and disassembler libraries because the bootstrap target was not exempted.

Since the bootstrap bpftool strictly compiles minimal AST parsing and C code generation logic without linking LLVM or disassembler libraries, these feature check sub-makes are completely redundant.

Quoted 6 lines

Exempt the bootstrap target from non-essential feature tests to eliminate unneeded sub-make fork overhead during Kbuild startup.

Assisted-by Gemini:gemini-3.1-pro-preview

Makes sense, thank you Ian!

#2 lore raw
In reply to Ian Rogers
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 9 lines · On Sat, 30 May 2026 18:07:50 -0700 you wrote:

When the perf build executes 'make -C ../bpf/bpftool bootstrap', bpftool's Makefile unconditionally evaluated feature checks for llvm, libcap, libbfd, and disassembler libraries because the bootstrap target was not exempted.

Since the bootstrap bpftool strictly compiles minimal AST parsing and C code generation logic without linking LLVM or disassembler libraries, these feature check sub-makes are completely redundant.

[...]

Here is the summary with links:
- [v1] bpftool build: Restrict feature tests during bootstrap compilation

    https://git.kernel.org/bpf/bpf-next/c/231fc9bc27fd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html