Skip to contentSkip to conversation

man: iplink: fix indentation level after inet parameter

PATCH Applied Fernando Fernandez Mancera 2 participants 3 messages Jun 7

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 man: iplink: fix indentation level after inet parameter

The indentation for inet block opens with +8 but closes with -10. Fix the imbalance.

Fixes fdb064bf64e5 ("iplink: add support for setting IPv4 devconf parameters")
---
 man/man8/ip-link.8.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man/man8/ip-link.8.in +1 -1
index e7ef64dd..d4f9f062 100644
@@ -214,7 +214,7 @@ ip-link \- network device configuration
 .br
 .RB "[ " igmpv3_unsolicited_report_interval " " INTERVAL " ] ]"
 .br
-.in -10
+.in -8
 .br
 .RB "[ " macaddr
 .RI "[ " MACADDR " ]"
Signature · 1 line
2.54.0
#1 lore raw

PATCH 2/2 iplink: set NLA_F_NESTED for IPv4 devconf attributes

In order to use set multiple IPv4 devconf parameters at once, NLA_F_NESTED flag is required.

ip link set dev enp8s0 inet forwarding on proxy_arp off

Fixes fdb064bf64e5 ("iplink: add support for setting IPv4 devconf parameters")
---
 ip/iplink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ip/iplink.c +2 -1
index 9799530f..3f0b46c9 100644
@@ -579,7 +579,8 @@ static int iplink_parse_inet(int *argcp, char ***argvp, struct iplink_req *req)
 
 	afs = addattr_nest(&req->n, sizeof(*req), IFLA_AF_SPEC);
 	afinet = addattr_nest(&req->n, sizeof(*req), AF_INET);
-	inet_devconf = addattr_nest(&req->n, sizeof(*req), IFLA_INET_CONF);
+	inet_devconf = addattr_nest(&req->n, sizeof(*req),
+				    IFLA_INET_CONF | NLA_F_NESTED);
 
 	while (NEXT_ARG_OK()) {
 		NEXT_ARG();
Signature · 1 line
2.54.0
#2 lore raw
In reply to Fernando Fernandez Mancera
This series was applied to iproute2/iproute2-next.git (main) by David Ahern <[email protected]>:

Hello:

This series was applied to iproute2/iproute2-next.git (main) by David Ahern <[email protected]>:

Quoted 8 lines · On Sun, 7 Jun 2026 08:57:14 +0200 you wrote:

The indentation for inet block opens with +8 but closes with -10. Fix the imbalance.

Fixes fdb064bf64e5 ("iplink: add support for setting IPv4 devconf parameters")
---
 man/man8/ip-link.8.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [1/2,iproute2-next] man: iplink: fix indentation level after inet parameter

    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=6592993853c0
  - [2/2,iproute2-next] iplink: set NLA_F_NESTED for IPv4 devconf attributes
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=7340b539841d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html