netdev: fix double-free in netdev_nl_bind_rx_doit()
Subsystems (2)
Jakub Kicinski
maintainerPATCH 1/1 netdev: fix double-free in netdev_nl_bind_rx_doit()
Sashiko flags that genlmsg_reply() always consumes the skb. The error path calls nlmsg_free(rsp) so we can't jump directly to it. Let's not unbind, just propagate the error to the user. This is the typical way of handling genlmsg_reply() failures. They shouldn't happen unless user does something silly like calling the kernel with an already-full rcvbuf.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- net/core/netdev-genl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/core/netdev-genl.c +1 -3
@@ -1095,8 +1095,6 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)genlmsg_end (rsp, hdr); err =genlmsg_reply (rsp, info); -if (err) - goto err_unbind;bitmap_free (rxq_bitmap);
@@ -1104,7 +1102,7 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)mutex_unlock (&priv->lock); -return 0 ; +return err <0 ? err :0 ; err_unbind:net_devmem_unbind_dmabuf (binding);
Signature · 1 line
2.54.0
Quoted 47 lines · Jakub Kicinski
Sashiko flags that
genlmsg_reply()always consumes the skb. The error path callsnlmsg_free(rsp)so we can't jump directly to it. Let's not unbind, just propagate the error to the user. This is the typical way of handlinggenlmsg_reply()failures. They shouldn't happen unless user does something silly like calling the kernel with an already-full rcvbuf.Reported-by Sashiko <[email protected]>Fixes 170aafe35cb9 ("netdev: support binding dma-buf to netdevice")Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- net/core/netdev-genl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)net/core/netdev-genl.c +1
-3@@ -1095,8 +1095,6 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)genlmsg_end (rsp, hdr); err =genlmsg_reply (rsp, info); -if (err) - goto err_unbind;bitmap_free (rxq_bitmap);@@ -1104,7 +1102,7 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)mutex_unlock (&priv->lock); -return 0 ; +return err <0 ? err :0 ; err_unbind:net_devmem_unbind_dmabuf (binding);Signature · 1 line
2.54.0
Quoted 10 lines · Jakub Kicinski
Sashiko flags that
genlmsg_reply()always consumes the skb. The error path callsnlmsg_free(rsp)so we can't jump directly to it. Let's not unbind, just propagate the error to the user. This is the typical way of handlinggenlmsg_reply()failures. They shouldn't happen unless user does something silly like calling the kernel with an already-full rcvbuf.Reported-by Sashiko <[email protected]>Fixes 170aafe35cb9 ("netdev: support binding dma-buf to netdevice")Signed-off-by Jakub Kicinski <[email protected]>
Quoted 36 lines · Jakub Kicinski
Sashiko flags that
genlmsg_reply()always consumes the skb. The error path callsnlmsg_free(rsp)so we can't jump directly to it. Let's not unbind, just propagate the error to the user. This is the typical way of handlinggenlmsg_reply()failures. They shouldn't happen unless user does something silly like calling the kernel with an already-full rcvbuf.Reported-by Sashiko <[email protected]>Fixes 170aafe35cb9 ("netdev: support binding dma-buf to netdevice")Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]--- net/core/netdev-genl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)net/core/netdev-genl.c +0
-2@@ -1095,8 +1095,6 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)genlmsg_end (rsp, hdr); err =genlmsg_reply (rsp, info); -if (err) - goto err_unbind;bitmap_free (rxq_bitmap);
net/core/netdev-genl.c int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) · line 1108
Quoted 8 lines
net/core/netdev-genl.c +1
-1@@ -1104,7 +1102,7 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)mutex_unlock (&priv->lock); -return 0 ; +return err <0 ? err :0 ; err_unbind:net_devmem_unbind_dmabuf (binding);
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 5 Jun 2026 18:21:24 -0700 you wrote:
Sashiko flags that
genlmsg_reply()always consumes the skb. The error path callsnlmsg_free(rsp)so we can't jump directly to it. Let's not unbind, just propagate the error to the user. This is the typical way of handlinggenlmsg_reply()failures. They shouldn't happen unless user does something silly like calling the kernel with an already-full rcvbuf.[...]
Here is the summary with links:
- [net] netdev: fix double-free in netdev_nl_bind_rx_doit()
https://git.kernel.org/netdev/net/c/c849de7d8757
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html