Skip to contentSkip to conversation

Don't include linux/a.out.h unnecessarily

PATCH In review David Howells 2 participants 2 messages Jan 4, 2005

Subsystems (4)
VFS exec and binfmt Proc filesystem Kcore
lore
Share & tools
lore

David Howells

author
#0 lore raw

PATCH 1/1 Don't include linux/a.out.h unnecessarily

The attached patch prevents unnecessary inclusion of linux/a.out.h since not all archs support AOUT and thus may not have asm/a.out.h.

There was a patch included for this previously, but it seems to have been dropped.

Signed-off-by David Howells <[email protected]>

---
warthog>diffstat aouth-2610mm1.diff

 exec.c       |    1 -
 proc/kcore.c |    1 -
 2 files changed, 2 deletions(-)
fs/exec.c renamed from warthog/kernels/linux-2.6.10-mm1/fs/exec.c +0 -1
diff -uNrp /warthog/kernels/linux-2.6.10-mm1/fs/exec.c linux-2.6.10-mm1-frv/fs/exec.c
@@ -26,7 +26,6 @@
 #include <linux/slab.h>
 #include <linux/file.h>
 #include <linux/mman.h>
-#include <linux/a.out.h>
 #include <linux/stat.h>
 #include <linux/fcntl.h>
 #include <linux/smp_lock.h>
fs/proc/kcore.c renamed from warthog/kernels/linux-2.6.10-mm1/fs/proc/kcore.c +0 -1
diff -uNrp /warthog/kernels/linux-2.6.10-mm1/fs/proc/kcore.c linux-2.6.10-mm1-frv/fs/proc/kcore.c
@@ -13,7 +13,6 @@
 #include <linux/mm.h>
 #include <linux/proc_fs.h>
 #include <linux/user.h>
-#include <linux/a.out.h>
 #include <linux/elf.h>
 #include <linux/elfcore.h>
 #include <linux/vmalloc.h>
#1 lore raw
Quoted 5 lines · David Howells

The attached patch prevents unnecessary inclusion of linux/a.out.h since not all archs support AOUT and thus may not have asm/a.out.h.

There was a patch included for this previously, but it seems to have been dropped.

Because it breaks the alpha build. There's a big #ifdef __alpha__ block in search_binary_handler() which uses definitions from asm/a.out.h.

Sorry, I should have cc'd you on my original report:
http://article.gmane.org/gmane.linux.kernel/263714

Nathan