net/mlx5: Check max_macs devlink param value against max capability
Subsystems (4)
Tariq Toukan
maintainerPATCH 1/1 net/mlx5: Check max_macs devlink param value against max capability
From: Dragos Tatulea <[email protected]>
The max_macs devlink param is checked against the FW max value only at param register time (driver load) and inside the validate callback (devlink param set). The stored DRIVERINIT value persists across FW resets and devlink reloads without any further checks against the max.
If the FW link type changes from Ethernet to IB and a FW reset happens, the MAX cap for log_max_current_uc_list will become zero, but the previously stored max_macs value remains and is unconditionally programmed into the HCA caps in handle_hca_cap(). FW will then return a syndrome during SET_HCA_CAP:
mlx5_cmd_out_err:839:(pid 3831): SET_HCA_CAP(0x109) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x537801), err(-22) set_hca_cap:907:(pid 3831): handle_hca_cap failed
This results in a failure to register the RDMA device.
This patch skips programming log_max_current_uc_list when the MAX capability is 0 (in case of IB).
--- drivers/net/ethernet/mellanox/mlx5/core/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/main.c +7 -5
@@ -527,7 +527,6 @@ static int handle_hca_cap(struct mlx5_core_dev *dev, void *set_ctx) {struct mlx5_profile *prof = &dev->profile;void *set_hca_cap; -int max_uc_list;int err; err =mlx5_core_get_caps (dev,MLX5_CAP_GENERAL );
@@ -610,10 +609,13 @@ static int handle_hca_cap(struct mlx5_core_dev *dev, void *set_ctx)MLX5_SET (cmd_hca_cap, set_hca_cap, roce,mlx5_is_roce_on (dev)); - max_uc_list =max_uc_list_get_devlink_param (dev); -if (max_uc_list >0 ) -MLX5_SET (cmd_hca_cap, set_hca_cap, log_max_current_uc_list, -ilog2 (max_uc_list)); +if (MLX5_CAP_GEN_MAX (dev, log_max_current_uc_list)) { +int max_uc_list =max_uc_list_get_devlink_param (dev); + +if (max_uc_list >0 ) +MLX5_SET (cmd_hca_cap, set_hca_cap, + log_max_current_uc_list,ilog2 (max_uc_list)); + }/* enable absolute native port num */ if (MLX5_CAP_GEN_MAX (dev, abs_native_port_num))
base-commit: 0068940907d33217ae01217f84910a5cde606c17
Signature · 1 line
2.44.0
From: Tariq Toukan <[email protected]>
Date: Thu, 11 Jun 2026 16:52:30 +0300
Quoted 19 lines
From: Dragos Tatulea <[email protected]>
The
max_macsdevlink param is checked against the FW max value only at param register time (driver load) and inside the validate callback (devlink param set). The stored DRIVERINIT value persists across FW resets and devlink reloads without any further checks against the max.If the FW link type changes from Ethernet to IB and a FW reset happens, the MAX cap for
log_max_current_uc_listwill become zero, but the previously storedmax_macsvalue remains and is unconditionally programmed into the HCA caps inhandle_hca_cap(). FW will then return a syndrome duringSET_HCA_CAP:mlx5_cmd_out_err:839:(pid 3831):
SET_HCA_CAP(0x109)op_mod(0x0)failed, status bad parameter(0x3), syndrome (0x537801), err(-22) set_hca_cap:907:(pid 3831):handle_hca_capfailedThis results in a failure to register the RDMA device.
Quoted 8 lines
This patch skips programming
log_max_current_uc_listwhen the MAX capability is 0 (in case of IB).Fixes 8680a60fc1fc ("net/mlx5: Let user configure max_macs generic param")Signed-off-by Dragos Tatulea <[email protected]>Reviewed-by Yael Chemla <[email protected]>Reviewed-by Carolina Jubran <[email protected]>Signed-off-by Tariq Toukan <[email protected]>
Thanks,
Olek
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 11 Jun 2026 16:52:30 +0300 you wrote:
From: Dragos Tatulea <[email protected]>
The
max_macsdevlink param is checked against the FW max value only at param register time (driver load) and inside the validate callback (devlink param set). The stored DRIVERINIT value persists across FW resets and devlink reloads without any further checks against the max.[...]
Here is the summary with links:
- [net] net/mlx5: Check max_macs devlink param value against max capability
https://git.kernel.org/netdev/net/c/d7b0413b3571
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html