pinctrl: airoha: Fix AN7583 Pin 21 BIT duplicate in conf tables
Subsystems (4)
PATCH 1/1 pinctrl: airoha: Fix AN7583 Pin 21 BIT duplicate in conf tables
From 5ed6ed42e17baf059bfaf1ba0ab5fc484f854659 Mon Sep 17 00:00:00 2001
From: "Wayen.Yan" <[email protected]>
Date: Sun, 14 Jun 2026 16:56:18 +0800
Subject: [PATCH] pinctrl: airoha: Fix AN7583 Pin 21 BIT duplicate in conf
tables
AN7583 pinctrl configuration tables have Pin 20 and Pin 21 both mapped to BIT(18), causing pin 21 configuration to incorrectly modify pin 20.
Fixes the following tables:
- an7583_pinctrl_pullup_conf
- an7583_pinctrl_pulldown_conf
- an7583_pinctrl_drive_e2_conf
- an7583_pinctrl_drive_e4_conf
Pin 18-22 sequence should be: BIT(16), BIT(17), BIT(18), BIT(19), BIT(20)
Fixes 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")
Signed-off-by Wayen Yan <[email protected]>
--- drivers/pinctrl/mediatek/pinctrl-airoha.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/mediatek/pinctrl-airoha.c +4 -4
@@ -1847,7 +1847,7 @@ static const struct airoha_pinctrl_conf an7583_pinctrl_pullup_conf[] = {PINCTRL_CONF_DESC (18 ,REG_GPIO_L_PU ,BIT (16 )),PINCTRL_CONF_DESC (19 ,REG_GPIO_L_PU ,BIT (17 )),PINCTRL_CONF_DESC (20 ,REG_GPIO_L_PU ,BIT (18 )), -PINCTRL_CONF_DESC (21 ,REG_GPIO_L_PU ,BIT (18 )), +PINCTRL_CONF_DESC (21 ,REG_GPIO_L_PU ,BIT (19 )),PINCTRL_CONF_DESC (22 ,REG_GPIO_L_PU ,BIT (20 )),PINCTRL_CONF_DESC (23 ,REG_GPIO_L_PU ,BIT (21 )), PINCTRL_CONF_DESC(24, REG_GPIO_L_PU, BIT(22)),
@@ -1964,7 +1964,7 @@ static const struct airoha_pinctrl_conf an7583_pinctrl_pulldown_conf[] = {PINCTRL_CONF_DESC (18 ,REG_GPIO_L_PD ,BIT (16 )),PINCTRL_CONF_DESC (19 ,REG_GPIO_L_PD ,BIT (17 )),PINCTRL_CONF_DESC (20 ,REG_GPIO_L_PD ,BIT (18 )), -PINCTRL_CONF_DESC (21 ,REG_GPIO_L_PD ,BIT (18 )), +PINCTRL_CONF_DESC (21 ,REG_GPIO_L_PD ,BIT (19 )),PINCTRL_CONF_DESC (22 ,REG_GPIO_L_PD ,BIT (20 )),PINCTRL_CONF_DESC (23 ,REG_GPIO_L_PD ,BIT (21 )), PINCTRL_CONF_DESC(24, REG_GPIO_L_PD, BIT(22)),
@@ -2081,7 +2081,7 @@ static const struct airoha_pinctrl_conf an7583_pinctrl_drive_e2_conf[] = {PINCTRL_CONF_DESC (18 ,REG_GPIO_L_E2 ,BIT (16 )),PINCTRL_CONF_DESC (19 ,REG_GPIO_L_E2 ,BIT (17 )),PINCTRL_CONF_DESC (20 ,REG_GPIO_L_E2 ,BIT (18 )), -PINCTRL_CONF_DESC (21 ,REG_GPIO_L_E2 ,BIT (18 )), +PINCTRL_CONF_DESC (21 ,REG_GPIO_L_E2 ,BIT (19 )),PINCTRL_CONF_DESC (22 ,REG_GPIO_L_E2 ,BIT (20 )),PINCTRL_CONF_DESC (23 ,REG_GPIO_L_E2 ,BIT (21 )), PINCTRL_CONF_DESC(24, REG_GPIO_L_E2, BIT(22)),
@@ -2198,7 +2198,7 @@ static const struct airoha_pinctrl_conf an7583_pinctrl_drive_e4_conf[] = {PINCTRL_CONF_DESC (18 ,REG_GPIO_L_E4 ,BIT (16 )),PINCTRL_CONF_DESC (19 ,REG_GPIO_L_E4 ,BIT (17 )),PINCTRL_CONF_DESC (20 ,REG_GPIO_L_E4 ,BIT (18 )), -PINCTRL_CONF_DESC (21 ,REG_GPIO_L_E4 ,BIT (18 )), +PINCTRL_CONF_DESC (21 ,REG_GPIO_L_E4 ,BIT (19 )),PINCTRL_CONF_DESC (22 ,REG_GPIO_L_E4 ,BIT (20 )),PINCTRL_CONF_DESC (23 ,REG_GPIO_L_E4 ,BIT (21 )), PINCTRL_CONF_DESC(24, REG_GPIO_L_E4, BIT(22)),
Signature · 1 line
2.51.0