Skip to contentSkip to conversation

net: airoha: Fix QoS counter configuration for Tx-fwd channels

PATCH Applied Wayen Yan 2 participants 2 messages Jun 16

Subsystems (4)

v1 of 2 Applied 1/1 Latest is v2 →

lore
Share & tools
lore

Wayen Yan

author
#0 lore raw

PATCH 1/1 net: airoha: Fix QoS counter configuration for Tx-fwd channels

In airoha_qdma_init_qos_stats(), the Tx-fwd counter was incorrectly using register index (i << 1) instead of ((i << 1) + 1). This caused the Tx-fwd configuration to overwrite the Tx-cpu configuration for each QoS channel, resulting in incorrect QoS statistics.

Fix by using the correct register index ((i << 1) + 1) for Tx-fwd counter configuration.

Fixes 20bf7d07c956 ("net: airoha: add QDMA support for Airoha EN7581 Ethernet")
---
 drivers/net/ethernet/airoha/airoha_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/airoha/airoha_eth.c +1 -1
index 31cdb11cd7..329988a840 100644
@@ -1256,7 +1256,7 @@ static void airoha_qdma_init_qos_stats(struct airoha_qdma *qdma)
 			       FIELD_PREP(CNTR_CHAN_MASK, i));
 		/* Tx-fwd transferred count */
 		airoha_qdma_wr(qdma, REG_CNTR_VAL((i << 1) + 1), 0);
-		airoha_qdma_wr(qdma, REG_CNTR_CFG(i << 1),
+		airoha_qdma_wr(qdma, REG_CNTR_CFG((i << 1) + 1),
 			       CNTR_EN_MASK | CNTR_ALL_QUEUE_EN_MASK |
 			       CNTR_ALL_DSCP_RING_EN_MASK |
 			       FIELD_PREP(CNTR_SRC_MASK, 1) |
Signature · 1 line
2.51.0
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 16 Jun 2026 18:50:29 +0800 you wrote:

In airoha_qdma_init_qos_stats(), the Tx-fwd counter was incorrectly using register index (i << 1) instead of ((i << 1) + 1). This caused the Tx-fwd configuration to overwrite the Tx-cpu configuration for each QoS channel, resulting in incorrect QoS statistics.

Fix by using the correct register index ((i << 1) + 1) for Tx-fwd counter configuration.

[...]

Here is the summary with links:
- net: airoha: Fix QoS counter configuration for Tx-fwd channels

    https://git.kernel.org/netdev/net-next/c/1402ecccf563

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html