Skip to contentSkip to conversation

octeontx2-af: npc: Log successful MCAM drop-on-non-hit install at debug level

PATCH Applied Ratheesh Kannoth 3 participants 3 messages Jun 15 – Jun 18

Subsystems (3)
lore
Share & tools
lore

Ratheesh Kannoth

author maintainer
#0 lore raw

PATCH 1/1 octeontx2-af: npc: Log successful MCAM drop-on-non-hit install at debug level

npc_install_mcam_drop_rule() used dev_err() after a successful rvu_mbox_handler_npc_mcam_write_entry() call, so normal installs appeared as errors in dmesg. Use dev_dbg() for the success path and keep dev_err() for real failures.

Fixes 3571fe07a090 ("octeontx2-af: Drop rules for NPC MCAM")
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c +1 -1
index 34f1e066707b..3d4d3ab5183b 100644
@@ -2215,7 +2215,7 @@ int npc_install_mcam_drop_rule(struct rvu *rvu, int mcam_idx, u16 *counter_idx,
 		return err;
 	}
 
-	dev_err(rvu->dev,
+	dev_dbg(rvu->dev,
 		"%s: Installed single drop on non hit rule at %d, cntr=%d\n",
 		__func__, mcam_idx, req.cntr);
 
Signature · 1 line
2.43.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ratheesh Kannoth

npc_install_mcam_drop_rule() used dev_err() after a successful rvu_mbox_handler_npc_mcam_write_entry() call, so normal installs appeared as errors in dmesg. Use dev_dbg() for the success path and keep dev_err() for real failures.

Fixes 3571fe07a090 ("octeontx2-af: Drop rules for NPC MCAM")
#2 lore raw
In reply to Ratheesh Kannoth
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Mon, 15 Jun 2026 09:01:57 +0530 you wrote:

npc_install_mcam_drop_rule() used dev_err() after a successful rvu_mbox_handler_npc_mcam_write_entry() call, so normal installs appeared as errors in dmesg. Use dev_dbg() for the success path and keep dev_err() for real failures.

Fixes 3571fe07a090 ("octeontx2-af: Drop rules for NPC MCAM")

[...]

Here is the summary with links:
- [net] octeontx2-af: npc: Log successful MCAM drop-on-non-hit install at debug level

    https://git.kernel.org/netdev/net/c/4f6ac65e8162

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html