netfilter: nfnetlink_log: work around uninitialized variable warning
Subsystems (3)
PATCH 1/1 netfilter: nfnetlink_log: work around uninitialized variable warning
After a recent (correct) change, gcc started warning about the use of the 'flags' variable in nfulnl_recv_config()
net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config':net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] net/netfilter/nfnetlink_log.c:828:6: note: 'flags' was declared here
The warning first shows up in ARM s3c2410_defconfig with gcc-4.3 or higher (including 5.2.1, which is the latest version I checked) I tried working around it by rearranging the code but had no success with that.
As a last resort, this initializes the variable to zero, which shuts up the warning, but means that we don't get a warning if the code is ever changed in a way that actually causes the variable to be used without first being written.
---
net/netfilter/nfnetlink_log.c +1 -1
@@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb,struct net *net =sock_net (ctnl);struct nfnl_log_net *log =nfnl_log_pernet (net);int ret =0 ; -u16 flags; +u16 flags =0 ;if (nfula[NFULA_CFG_CMD ]) {u_int8_t pf = nfmsg->nfgen_family;
Quoted 12 lines · Arnd Bergmann
After a recent (correct) change, gcc started warning about the use of the 'flags' variable in
nfulnl_recv_config()
net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config':net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]net/netfilter/nfnetlink_log.c:828:6: note: 'flags' was declared hereThe warning first shows up in ARM
s3c2410_defconfigwith gcc-4.3 or higher (including 5.2.1, which is the latest version I checked) I tried working around it by rearranging the code but had no success with that.
Quoted 4 lines
As a last resort, this initializes the variable to zero, which shuts up the warning, but means that we don't get a warning if the code is ever changed in a way that actually causes the variable to be used without first being written.
Applied, thanks!