media: i2c: ov08d10: fixups for reset and power management support
Matthias Fend
reviewercover media: i2c: ov08d10: fixups for reset and power management support
Two minor improvements for OV08D10 image sensor driver that have already been discussed, but which don't address any known functional issues.
These changes were already submitted as a fixup commit for the original patch, but this wasn't applied before the merge. Therefore, here they are again as separate commits.
---
Matthias Fend (2):
media: i2c: ov08d10: unconditionally use the startup delay
media: i2c: ov08d10: respect 80 char line limit
drivers/media/i2c/ov08d10.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
---
base-commit: 06cb687a5132fcffe624c0070576ab852ac6b568
change-id: 20260618-ov08d10-fixes-e03096cd7669
Best regards,
Signature · 1 line
Matthias Fend <[email protected]>
Matthias Fend
reviewerPATCH 1/2 media: i2c: ov08d10: unconditionally use the startup delay
Even though the datasheet does not describe the timings for operation without a dedicated hardware reset, it seems sensible to wait for the "XSHUTDN pull up to SCCB start" time even if no reset line is available.
--- drivers/media/i2c/ov08d10.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/i2c/ov08d10.c +3 -3
@@ -1358,11 +1358,11 @@ static int ov08d10_power_on(struct device *dev)fsleep (5 *USEC_PER_MSEC );reset_control_deassert (ov08d10->reset); - -/* Delay from XSHUTDN pull up to SCCB start: 8ms */ -fsleep (8 *USEC_PER_MSEC ); } +/* Delay from XSHUTDN pull up to SCCB start: 8ms */ +fsleep (8 *USEC_PER_MSEC ); +return 0 ; }
Signature · 1 line
2.34.1
Re: [PATCH 1/2] media: i2c: ov08d10: unconditionally use the startup delay
Quoting Matthias Fend (2026-06-18 10:31:12)
Quoted 14 lines
Even though the datasheet does not describe the timings for operation without a dedicated hardware reset, it seems sensible to wait for the "XSHUTDN pull up to SCCB start" time even if no reset line is available.
Signed-off-by Matthias Fend <[email protected]>--- drivers/media/i2c/ov08d10.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/media/i2c/ov08d10.c +0
-0
drivers/media/i2c/ov08d10.c static int ov08d10_power_on(struct device *dev) · line 1363
Quoted 9 lines
drivers/media/i2c/ov08d10.c +1
-3@@ -1358,11 +1358,11 @@ static int ov08d10_power_on(struct device *dev)fsleep (5 *USEC_PER_MSEC );reset_control_deassert (ov08d10->reset); - -/* Delay from XSHUTDN pull up to SCCB start: 8ms */ -fsleep (8 *USEC_PER_MSEC ); } +/* Delay from XSHUTDN pull up to SCCB start: 8ms */
8 ms seems like a long delay at startup... but it was preceeding this patch anyway.
If there's no hardware reset line, then I'd expect the module to have tied that in - so I expect the delay is still required too.
Quoted 9 lines
drivers/media/i2c/ov08d10.c +2
-0+fsleep (8 *USEC_PER_MSEC ); +return 0 ; }Signature · 2 lines
-- 2.34.1
Matthias Fend
reviewerPATCH 2/2 media: i2c: ov08d10: respect 80 char line limit
In reply to Matthias FendFix a violation of the preferred line limit of 80 characters.
--- drivers/media/i2c/ov08d10.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/ov08d10.c +2 -1
@@ -1515,7 +1515,8 @@ static int ov08d10_probe(struct i2c_client *client)return ret; } - ov08d10->reset =devm_reset_control_get_optional_exclusive (ov08d10->dev,NULL ); + ov08d10->reset =devm_reset_control_get_optional_exclusive (ov08d10->dev, +NULL );if (IS_ERR (ov08d10->reset))return dev_err_probe (ov08d10->dev,PTR_ERR (ov08d10->reset),"failed to get reset\n" );
Signature · 1 line
2.34.1
Re: [PATCH 2/2] media: i2c: ov08d10: respect 80 char line limit
Quoting Matthias Fend (2026-06-18 10:31:13)
Quoted 2 lines
Fix a violation of the preferred line limit of 80 characters.
Quoted 23 lines
Signed-off-by Matthias Fend <[email protected]>--- drivers/media/i2c/ov08d10.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/media/i2c/ov08d10.c +2
-1@@ -1515,7 +1515,8 @@ static int ov08d10_probe(struct i2c_client *client)return ret; } - ov08d10->reset =devm_reset_control_get_optional_exclusive (ov08d10->dev,NULL ); + ov08d10->reset =devm_reset_control_get_optional_exclusive (ov08d10->dev, +NULL );if (IS_ERR (ov08d10->reset))return dev_err_probe (ov08d10->dev,PTR_ERR (ov08d10->reset),"failed to get reset\n" );Signature · 2 lines
-- 2.34.1