devlink: Fix a couple parent ref leaks
Subsystems (3)
cover devlink: Fix a couple parent ref leaks
These two patches fix parent ref leaks on errors.
Cosmin Ratiu (2):
devlink: Fix parent ref leak in devl_rate_node_create()
devlink: Fix parent ref leak on tc-bw failure
net/devlink/rate.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
Signature · 1 line
2.53.0
PATCH 1/2 devlink: Fix parent ref leak in devl_rate_node_create()
In the original commit the function bails out on kstrdup failure, forgetting to decrement the refcnt of the parent.
Fix that by moving the parent refcnt setting after kstrdup.
--- net/devlink/rate.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
net/devlink/rate.c +5 -5
@@ -725,11 +725,6 @@ devl_rate_node_create(struct devlink *devlink, void *priv, char *node_name,if (!rate_node)return ERR_PTR (-ENOMEM ); -if (parent) { - rate_node->parent = parent; -refcount_inc (&rate_node->parent->refcnt); - } - rate_node->type =DEVLINK_RATE_TYPE_NODE ; rate_node->devlink = devlink; rate_node->priv = priv;
@@ -740,6 +735,11 @@ devl_rate_node_create(struct devlink *devlink, void *priv, char *node_name,return ERR_PTR (-ENOMEM ); } +if (parent) { + rate_node->parent = parent; +refcount_inc (&rate_node->parent->refcnt); + } +refcount_set (&rate_node->refcnt,1 );list_add (&rate_node->list, &devlink->rate_list);devlink_rate_notify (rate_node,DEVLINK_CMD_RATE_NEW );
Signature · 1 line
2.53.0
PATCH 2/2 devlink: Fix parent ref leak on tc-bw failure
In reply to Cosmin RatiuWhen a node is created via rate-new with tc-bw and a parent node, devlink_nl_rate_set() executes the sequence of ops. It bails out on the first failure and doesn't rollback anything. For most things that is fine (setting some numbers), but the parent set can leak if there's another failure after that.
That is precisely what happens when parent setting isn't the last block in the function. After the referenced "Fixes" commit, when tc-bw fails to be set the function bails out after having set the parent and incremented its refcount.
There are two callers:
- devlink_nl_rate_set_doit() is fine, it just reports the error.
- but devlink_nl_rate_new_doit() frees the newly created node and leaks the parent refcnt.
Fix that by reordering the blocks so parent setting is last and adding a comment explaining this so future modification preserve the ordering (hopefully).
--- net/devlink/rate.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
net/devlink/rate.c +9 -6
@@ -486,16 +486,19 @@ static int devlink_nl_rate_set(struct devlink_rate *devlink_rate, devlink_rate->tx_weight = weight; } - nla_parent = attrs[DEVLINK_ATTR_RATE_PARENT_NODE_NAME ]; -if (nla_parent) { - err =devlink_nl_rate_parent_node_set (devlink_rate, info, - nla_parent); +if (attrs[DEVLINK_ATTR_RATE_TC_BWS ]) { + err =devlink_nl_rate_tc_bw_set (devlink_rate, info);if (err)return err; } -if (attrs[DEVLINK_ATTR_RATE_TC_BWS ]) { - err =devlink_nl_rate_tc_bw_set (devlink_rate, info); +/* Keep parent setting last because it takes a reference. This function +* has no rollback, so failing after taking the ref would leak it. +*/ + nla_parent = attrs[DEVLINK_ATTR_RATE_PARENT_NODE_NAME ]; +if (nla_parent) { + err =devlink_nl_rate_parent_node_set (devlink_rate, info, + nla_parent);if (err)return err; }
Signature · 1 line
2.53.0
Quoted 5 lines · Cosmin Ratiu
These two patches fix parent ref leaks on errors.
Cosmin Ratiu (2):
devlink: Fix parent ref leak indevl_rate_node_create()
devlink: Fix parent ref leak on tc-bw failure
Thanks Cosmin,
For the series:
This series was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Tue, 16 Jun 2026 14:06:31 +0300 you wrote:
These two patches fix parent ref leaks on errors.
Cosmin Ratiu (2):
devlink: Fix parent ref leak indevl_rate_node_create()
devlink: Fix parent ref leak on tc-bw failurenet/devlink/rate.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
Here is the summary with links:
- [net,1/2] devlink: Fix parent ref leak in devl_rate_node_create()
https://git.kernel.org/netdev/net/c/ba45106342bb - [net,2/2] devlink: Fix parent ref leak on tc-bw failure https://git.kernel.org/netdev/net/c/ba81a8b80f04
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html