Skip to contentSkip to conversation

net: sit: require CAP_NET_ADMIN in the device netns for changelink

PATCH Applied Maoyi Xie 4 participants 4 messages Jun 18 – Jun 21

Subsystems (3)
lore
Share & tools
lore

Maoyi Xie

author
#0 lore raw

PATCH 1/1 net: sit: require CAP_NET_ADMIN in the device netns for changelink

ipip6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net.

Gate ipip6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. sit was the one tunnel type not covered by the recent series that added this check to the other changelink() handlers.

Fixes 5e6700b3bf98 ("sit: add support of x-netns")
---
 net/ipv6/sit.c | 3 +++
 1 file changed, 3 insertions(+)
net/ipv6/sit.c +3 -0
index 64f0d1b..a38b24f 100644
@@ -1613,6 +1613,9 @@ static int ipip6_changelink(struct net_device *dev, struct nlattr *tb[],
 	__u32 fwmark = t->fwmark;
 	int err;
 
+	if (!rtnl_dev_link_net_capable(dev, net))
+		return -EPERM;
+
 	if (dev == sitn->fb_tunnel_dev)
 		return -EINVAL;
 

--
2.43.0

Reviewed-by on v1 1/1
#1 lore raw

Le 18/06/2026 à 09:08, Maoyi Xie a écrit :

Quoted 12 lines

ipip6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net.

Gate ipip6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. sit was the one tunnel type not covered by the recent series that added this check to the other changelink() handlers.

Quoted 4 lines
Fixes 5e6700b3bf98 ("sit: add support of x-netns")
Reviewed-by on v1 1/1
#2 lore raw
In reply to Maoyi Xie
Quoted 13 lines · Maoyi Xie

ipip6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net.

Gate ipip6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. sit was the one tunnel type not covered by the recent series that added this check to the other changelink() handlers.

Quoted 4 lines
Fixes 5e6700b3bf98 ("sit: add support of x-netns")
#3 lore raw
In reply to Maoyi Xie
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Thu, 18 Jun 2026 15:08:17 +0800 you wrote:

ipip6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net.

[...]

Here is the summary with links:
- [net] net: sit: require CAP_NET_ADMIN in the device netns for changelink

    https://git.kernel.org/netdev/net/c/27ccb68e7ccc

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html