Bluetooth: ISO: avoid NULL deref of conn in iso_conn_big_sync()
Subsystems (3)
PATCH 1/1 Bluetooth: ISO: avoid NULL deref of conn in iso_conn_big_sync()
iso_conn_big_sync() drops the socket lock to call hci_get_route() and then re-acquires it, but dereferences iso_pi(sk)->conn->hcon afterwards without re-checking that conn is still valid.
While the lock is dropped, the connection can be torn down under the same socket lock: iso_disconn_cfm() -> iso_conn_del() -> iso_chan_del() sets iso_pi(sk)->conn to NULL (and the broadcast teardown path can also clear conn->hcon on its own). When iso_conn_big_sync() re-acquires the lock and reads conn->hcon, conn may be NULL, causing a NULL pointer dereference (hcon is the first member of struct iso_conn).
This path is reached from iso_sock_recvmsg() for a PA-sync broadcast sink socket (BT_SK_DEFER_SETUP | BT_SK_PA_SYNC), so the dropped-lock window can race with connection teardown driven by controller events.
Re-validate iso_pi(sk)->conn and its hcon after re-acquiring the socket lock and bail out if the connection went away, as already done in the sibling iso_sock_rebind_bc().
--- net/bluetooth/iso.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
net/bluetooth/iso.c +12 -1
@@ -1589,6 +1589,7 @@ static void iso_conn_big_sync(struct sock *sk) {int err;struct hci_dev *hdev; +struct iso_conn *conn;bdaddr_t src, dst;u8 src_type;
@@ -1611,8 +1612,17 @@ static void iso_conn_big_sync(struct sock *sk)hci_dev_lock (hdev);lock_sock (sk); +/* The socket lock was dropped for hci_get_route(), so the connection +* may have been torn down meanwhile: iso_chan_del() clears conn and +* the broadcast teardown path can clear conn->hcon on its own. Check +* both before dereferencing conn->hcon. +*/ + conn =iso_pi (sk)->conn; +if (!conn || !conn->hcon) + goto unlock; +if (!test_and_set_bit (BT_SK_BIG_SYNC , &iso_pi (sk)->flags)) { - err = hci_conn_big_create_sync(hdev, iso_pi(sk)->conn->hcon, + err = hci_conn_big_create_sync(hdev, conn->hcon, &iso_pi(sk)->qos, iso_pi(sk)->sync_handle, iso_pi(sk)->bc_num_bis,
@@ -1621,6 +1631,7 @@ static void iso_conn_big_sync(struct sock *sk)bt_dev_err (hdev,"hci_big_create_sync: %d" , err); } +unlock:release_sock (sk);hci_dev_unlock (hdev);hci_dev_put (hdev);
Signature · 1 line
2.54.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1114372
---Test result---
Test Summary:
CheckPatch PASS 1.34 seconds VerifyFixes PASS 0.22 seconds VerifySignedoff PASS 0.21 seconds GitLint PASS 0.61 seconds SubjectPrefix PASS 0.26 seconds BuildKernel PASS 25.71 seconds CheckAllWarning PASS 28.24 seconds CheckSparse PASS 27.09 seconds BuildKernel32 PASS 24.89 seconds CheckKernelLLVM SKIP 0.00 seconds TestRunnerSetup PASS 534.83 seconds TestRunner_iso-tester PASS 78.14 seconds IncrementalBuild PASS 24.42 seconds
Details
##############################
Test: CheckKernelLLVM - SKIP
Desc: Build kernel with LLVM + context analysis
Output:
Clang not found
https://github.com/bluez/bluetooth-next/pull/336
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 4 lines · On Sun, 21 Jun 2026 21:23:05 +0500 you wrote:
iso_conn_big_sync()drops the socket lock to callhci_get_route()and then re-acquires it, but dereferences iso_pi(sk)->conn->hcon afterwards without re-checking that conn is still valid.
Quoted 8 lines
While the lock is dropped, the connection can be torn down under the same socket lock:
iso_disconn_cfm()->iso_conn_del()->iso_chan_del()sets iso_pi(sk)->conn to NULL (and the broadcast teardown path can also clearconn->hconon its own). Wheniso_conn_big_sync()re-acquires the lock and readsconn->hcon, conn may be NULL, causing a NULL pointer dereference (hcon is the first member of structiso_conn).[...]
Here is the summary with links:
- Bluetooth: ISO: avoid NULL deref of conn in iso_conn_big_sync()
https://git.kernel.org/bluetooth/bluetooth-next/c/a0ac2b200be1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html