net/sched: cls_api: Handle TC_ACT_CONSUMED in tcf_qevent_handle
Subsystems (3)
Jamal Hadi Salim
maintainerPATCH 1/1 net/sched: cls_api: Handle TC_ACT_CONSUMED in tcf_qevent_handle
tcf_classify() can return TC_ACT_CONSUMED while the skb is held by the defragmentation engine (e.g. act_ct on out-of-order fragments). When that happens the skb is no longer owned by the caller and must not be touched again.
tcf_qevent_handle() did not handle TC_ACT_CONSUMED: it fell through the switch and returned the skb to the caller as if classification had passed. The only qdisc that wires up qevents today is RED, via three call sites (qe_mark on RED_PROB_MARK/HARD_MARK, qe_early_drop on congestion_drop) red_enqueue() was continuing to operate on an skb it no longer owns in this case -- enqueueing it, dropping it, or updating statistics. Resulting in a UAF.
tc qdisc add dev eth0 root handle 1: red ... qevent early_drop block 10 tc filter add block 10 ... action ct
(with ct defrag enabled and traffic that produces out-of-order fragments, e.g. a fragmented UDP stream)
Handle TC_ACT_CONSUMED in tcf_qevent_handle() the same way the ingress and egress fast paths do: treat it as stolen and return NULL without touching the skb. Unlike the TC_ACT_STOLEN case, the skb must not be dropped/freed here, as it is no longer owned by us.
--- net/sched/cls_api.c | 3 +++ 1 file changed, 3 insertions(+)
net/sched/cls_api.c +3 -0
@@ -4049,6 +4049,9 @@ struct sk_buff *tcf_qevent_handle(struct tcf_qevent *qe, struct Qdisc *sch, struskb_do_redirect (skb); *ret = __NET_XMIT_STOLEN;return NULL ; +case TC_ACT_CONSUMED : + *ret = __NET_XMIT_STOLEN; +return NULL ; }return skb;
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerQuoted 16 lines · Jamal Hadi Salim
tcf_classify()can returnTC_ACT_CONSUMEDwhile the skb is held by the defragmentation engine (e.g.act_cton out-of-order fragments). When that happens the skb is no longer owned by the caller and must not be touched again.
tcf_qevent_handle()did not handleTC_ACT_CONSUMED: it fell through the switch and returned the skb to the caller as if classification had passed. The only qdisc that wires up qevents today is RED, via three call sites (qe_markon RED_PROB_MARK/HARD_MARK,qe_early_droponcongestion_drop)red_enqueue()was continuing to operate on an skb it no longer owns in this case -- enqueueing it, dropping it, or updating statistics. Resulting in a UAF.tc qdisc add dev eth0 root handle 1: red ... qevent
early_dropblock 10 tc filter add block 10 ... action ct
Quoted 8 lines
(with ct defrag enabled and traffic that produces out-of-order fragments, e.g. a fragmented UDP stream)
Handle
TC_ACT_CONSUMEDintcf_qevent_handle()the same way the ingress and egress fast paths do: treat it as stolen and return NULL without touching the skb. Unlike theTC_ACT_STOLENcase, the skb must not be dropped/freed here, as it is no longer owned by us.
I just looked at sashiko claims - one of them (on ebpf) is legit but the one on qdiscs is some BS it is making up. I will address the ebpf one this week.
cheers,
jamal
Quoted 25 lines
Fixes 3f14b377d01d ("net/sched: act_ct: fix skb leak and crash on ooo frags")Reported-by Zero Day Initiative <[email protected]>Tested-by Victor Nogueira <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>--- net/sched/cls_api.c | 3 +++ 1 file changed, 3 insertions(+)net/sched/cls_api.c +3
-1@@ -4049,6 +4049,9 @@ struct sk_buff *tcf_qevent_handle(struct tcf_qevent *qe, struct Qdisc *sch, struskb_do_redirect (skb); *ret = __NET_XMIT_STOLEN;return NULL ; +case TC_ACT_CONSUMED : + *ret = __NET_XMIT_STOLEN; +return NULL ; }return skb; --2.34.1
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 5 lines · On Sat, 20 Jun 2026 09:07:49 -0400 you wrote:
tcf_classify()can returnTC_ACT_CONSUMEDwhile the skb is held by the defragmentation engine (e.g.act_cton out-of-order fragments). When that happens the skb is no longer owned by the caller and must not be touched again.
Quoted 8 lines
tcf_qevent_handle()did not handleTC_ACT_CONSUMED: it fell through the switch and returned the skb to the caller as if classification had passed. The only qdisc that wires up qevents today is RED, via three call sites (qe_markon RED_PROB_MARK/HARD_MARK,qe_early_droponcongestion_drop)red_enqueue()was continuing to operate on an skb it no longer owns in this case -- enqueueing it, dropping it, or updating statistics. Resulting in a UAF.[...]
Here is the summary with links:
- [net,1/1] net/sched: cls_api: Handle TC_ACT_CONSUMED in tcf_qevent_handle
https://git.kernel.org/netdev/net/c/a8a02897f2b4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html