Skip to contentSkip to conversation

doc: announce ethdev operation struct changes

PATCH In review Feifei Wang 6 participants 15 messages Jul 4, 2023 – Aug 1, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: announce ethdev operation struct changes

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +4 -0
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
 * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
   to have another parameter ``qp_id`` to return the queue pair ID
   which got error interrupt to the application,
Signature · 1 line
2.25.1
#1 lore raw
Quoted 38 lines

-----Original Message-----
From: Feifei Wang <[email protected]>
Sent: Tuesday, July 4, 2023 4:10 PM
Cc: [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; Feifei Wang <[email protected]>; Ruifeng Wang <[email protected]>
Subject: [PATCH] doc: announce ethdev operation struct changes

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +5 -1
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be
+updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
 * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
   to have another parameter ``qp_id`` to return the queue pair ID
   which got error interrupt to the application,
--

2.25.1

#2 lore raw
Quoted 40 lines

-----Original Message-----
From: Feifei Wang
Sent: Tuesday, July 4, 2023 4:17 PM
To: Feifei Wang <[email protected]>
Cc: [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; Ruifeng Wang <[email protected]>; Konstantin Ananyev <[email protected]>; [email protected]; Ferruh Yigit <[email protected]>; [email protected]; Andrew Rybchenko <[email protected]>; nd <[email protected]>
Subject: RE: [PATCH] doc: announce ethdev operation struct changes

Quoted 26 lines

-----Original Message-----
From: Feifei Wang <[email protected]>
Sent: Tuesday, July 4, 2023 4:10 PM
Cc: [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; Feifei Wang <[email protected]>; Ruifeng Wang <[email protected]>
Subject: [PATCH] doc: announce ethdev operation struct changes

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 11 lines
Quoted 11 lines
doc/guides/rel_notes/deprecation.rst +6 -1
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev``
+and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be
+updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
 * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
   to have another parameter ``qp_id`` to return the queue pair ID
   which got error interrupt to the application,
--

2.25.1

Ping~

#3 lore raw
Quoted 27 lines

From: Feifei Wang [mailto:[email protected]]
Sent: Thursday, 13 July 2023 04.37

Quoted 24 lines

From: Feifei Wang
Sent: Tuesday, July 4, 2023 4:17 PM

Quoted 21 lines

From: Feifei Wang <[email protected]>
Sent: Tuesday, July 4, 2023 4:10 PM

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 13 lines
Quoted 11 lines
Quoted 11 lines
doc/guides/rel_notes/deprecation.rst +6 -1
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev``
+and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be
+updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
 * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
   to have another parameter ``qp_id`` to return the queue pair ID
   which got error interrupt to the application,
--

2.25.1

Ping~

#4 lore raw
Quoted 41 lines · Morten Brørup
Quoted 27 lines

From: Feifei Wang [mailto:[email protected]]
Sent: Thursday, 13 July 2023 04.37

Quoted 24 lines

From: Feifei Wang
Sent: Tuesday, July 4, 2023 4:17 PM

Quoted 21 lines

From: Feifei Wang <[email protected]>
Sent: Tuesday, July 4, 2023 4:10 PM

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
  doc/guides/rel_notes/deprecation.rst | 4 ++++
  1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices
    The legacy actions should be removed
    once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 13 lines
Quoted 11 lines
Quoted 11 lines
doc/guides/rel_notes/deprecation.rst +6 -1
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev``
+and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be
+updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
  * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
    to have another parameter ``qp_id`` to return the queue pair ID
    which got error interrupt to the application,
--

2.25.1

Ping~

Quoted 2 lines
Acked-by on v1 1/1
#5 lore raw
In reply to Feifei Wang

04/07/2023 09:10, Feifei Wang пишет:

Quoted 14 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
  doc/guides/rel_notes/deprecation.rst | 4 ++++
  1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 127

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +4 -0
@@ -118,6 +118,10 @@ Deprecation Notices
    The legacy actions should be removed
    once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
  * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
    to have another parameter ``qp_id`` to return the queue pair ID
    which got error interrupt to the application,
Acked-by
#6 lore raw
Quoted 21 lines · Konstantin Ananyev

04/07/2023 09:10, Feifei Wang пишет:

Quoted 20 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
  doc/guides/rel_notes/deprecation.rst | 4 ++++

  1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices

    The legacy actions should be removed
    once ``MODIFY_FIELD`` alternative is implemented in drivers. +* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be

Quoted 9 lines
Quoted 6 lines

updated
+  with new fields to support mbufs recycle mode from DPDK 23.11. +
  * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated to have another parameter ``qp_id`` to return the queue pair ID which got error interrupt to the application,

#7 lore raw
In reply to Feifei Wang

04/07/2023 10:10, Feifei Wang:

Quoted 14 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 6 lines
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.

It does seem to be an impacting change for existing applications, except that it is allowed only during ABI breakage window.

I think my patch should be enough:
https://patches.dpdk.org/project/dpdk/patch/[email protected]/

#8 lore raw

28/07/2023 16:56, Thomas Monjalon:

Quoted 18 lines

04/07/2023 10:10, Feifei Wang:

Quoted 17 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index 66431789b0..c7e1ffafb2 100644
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 5 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 3 lines
doc/guides/rel_notes/deprecation.rst +3 -0
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.

It does seem to be an impacting change for existing applications,

I meant "It does NOT seem"

Quoted 4 lines

except that it is allowed only during ABI breakage window.

I think my patch should be enough:
https://patches.dpdk.org/project/dpdk/patch/[email protected]/

This deprecation notice is marked as superseded,
given my patch above should be enough.

#9 lore raw
In reply to Thomas Monjalon
Quoted 22 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 16.57

04/07/2023 10:10, Feifei Wang:

Review

Quoted 10 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/doc/guides/rel_notes/deprecation.rst

Quoted 7 lines

index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst +0 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 3 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 3 lines
doc/guides/rel_notes/deprecation.rst +3 -0
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.

Existing fields will also be moved around [1]:

@@ -83,15 +90,17 @@ struct rte_eth_fp_ops {
* Rx fast-path functions and related data.
* 64-bit systems: occupies first 64B line */
+ /** Rx queues data. */
+ struct rte_ethdev_qdata rxq;
/** PMD receive function. */ eth_rx_burst_t rx_pkt_burst;
/** Get the number of used Rx descriptors. */ eth_rx_queue_count_t rx_queue_count; /** Check the status of a Rx descriptor. */ eth_rx_descriptor_status_t rx_descriptor_status;
- /** Rx queues data. */
- struct rte_ethdev_qdata rxq;
- uintptr_t reserved1[3];
+ /** Refill Rx descriptors with the recycling mbufs. */
+ eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill;
+ uintptr_t reserved1[2];
/**@}*/

/**@{*/
@@ -99,15 +108,17 @@ struct rte_eth_fp_ops {
* Tx fast-path functions and related data.
* 64-bit systems: occupies second 64B line */
+ /** Tx queues data. */
+ struct rte_ethdev_qdata txq;
/** PMD transmit function. */ eth_tx_burst_t tx_pkt_burst;
/** PMD transmit prepare function. */ eth_tx_prep_t tx_pkt_prepare;
/** Check the status of a Tx descriptor. */ eth_tx_descriptor_status_t tx_descriptor_status;
- /** Tx queues data. */
- struct rte_ethdev_qdata txq;
- uintptr_t reserved2[3];
+ /** Copy used mbufs from Tx mbuf ring into Rx. */
+ eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
+ uintptr_t reserved2[2];
/**@}*/

[1]: https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/

Quoted 8 lines

It does seem to be an impacting change for existing applications, except that it is allowed only during ABI breakage window.

I think my patch should be enough:
https://patches.dpdk.org/project/dpdk/patch/20230728142946.1201459-1-
[email protected]/

#10 lore raw

28/07/2023 17:08, Morten Brørup:

Quoted 58 lines
Quoted 22 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 16.57

04/07/2023 10:10, Feifei Wang:

Review

Quoted 10 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/doc/guides/rel_notes/deprecation.rst

Quoted 7 lines

index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst +0 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 3 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 3 lines
doc/guides/rel_notes/deprecation.rst +3 -0
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.

Existing fields will also be moved around [1]:

(quoted diff) +7 -3
@@ -83,15 +90,17 @@  struct rte_eth_fp_ops {
 	 * Rx fast-path functions and related data.
 	 * 64-bit systems: occupies first 64B line
 	 */
+	/** Rx queues data. */
+	struct rte_ethdev_qdata rxq;
 	/** PMD receive function. */
 	eth_rx_burst_t rx_pkt_burst;
 	/** Get the number of used Rx descriptors. */
 	eth_rx_queue_count_t rx_queue_count;
 	/** Check the status of a Rx descriptor. */
 	eth_rx_descriptor_status_t rx_descriptor_status;
-	/** Rx queues data. */
-	struct rte_ethdev_qdata rxq;
-	uintptr_t reserved1[3];
+	/** Refill Rx descriptors with the recycling mbufs. */
+	eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill;
+	uintptr_t reserved1[2];
 	/**@}*/
 
 	/**@{*/
@@ -99,15 +108,17 @@  struct rte_eth_fp_ops {
 	 * Tx fast-path functions and related data.
 	 * 64-bit systems: occupies second 64B line
 	 */
+	/** Tx queues data. */
+	struct rte_ethdev_qdata txq;
 	/** PMD transmit function. */
 	eth_tx_burst_t tx_pkt_burst;
 	/** PMD transmit prepare function. */

Review struct rte_eth_fp_ops { · line 122

Quoted 10 lines
(quoted diff) +3 -3
 	eth_tx_prep_t tx_pkt_prepare;
 	/** Check the status of a Tx descriptor. */
 	eth_tx_descriptor_status_t tx_descriptor_status;
-	/** Tx queues data. */
-	struct rte_ethdev_qdata txq;
-	uintptr_t reserved2[3];
+	/** Copy used mbufs from Tx mbuf ring into Rx. */
+	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
+	uintptr_t reserved2[2];
 	/**@}*/

Removing existing fields should be announced explicitly.

#11 lore raw
Quoted 67 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 17.20

28/07/2023 17:08, Morten Brørup:

Quoted 22 lines
Quoted 22 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 16.57

04/07/2023 10:10, Feifei Wang:

Review

Quoted 10 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/doc/guides/rel_notes/deprecation.rst

Quoted 7 lines

index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst +0 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 2 lines
Quoted 2 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 122

Quoted 2 lines
doc/guides/rel_notes/deprecation.rst +2 -0
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be

updated

Quoted 38 lines
Quoted 1 line

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 1 line
doc/guides/rel_notes/deprecation.rst +1 -0
+  with new fields to support mbufs recycle mode from DPDK 23.11.

Existing fields will also be moved around [1]:

(quoted diff) +7 -4
@@ -83,15 +90,17 @@  struct rte_eth_fp_ops {
 	 * Rx fast-path functions and related data.
 	 * 64-bit systems: occupies first 64B line
 	 */
+	/** Rx queues data. */
+	struct rte_ethdev_qdata rxq;
 	/** PMD receive function. */
 	eth_rx_burst_t rx_pkt_burst;
 	/** Get the number of used Rx descriptors. */
 	eth_rx_queue_count_t rx_queue_count;
 	/** Check the status of a Rx descriptor. */
 	eth_rx_descriptor_status_t rx_descriptor_status;
-	/** Rx queues data. */
-	struct rte_ethdev_qdata rxq;
-	uintptr_t reserved1[3];
+	/** Refill Rx descriptors with the recycling mbufs. */
+	eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill;
+	uintptr_t reserved1[2];
 	/**@}*/
 
 	/**@{*/
@@ -99,15 +108,17 @@  struct rte_eth_fp_ops {
 	 * Tx fast-path functions and related data.
 	 * 64-bit systems: occupies second 64B line
 	 */
+	/** Tx queues data. */
+	struct rte_ethdev_qdata txq;
 	/** PMD transmit function. */
 	eth_tx_burst_t tx_pkt_burst;
 	/** PMD transmit prepare function. */
 	eth_tx_prep_t tx_pkt_prepare;
 	/** Check the status of a Tx descriptor. */
 	eth_tx_descriptor_status_t tx_descriptor_status;
-	/** Tx queues data. */
Quoted 8 lines

Review struct rte_eth_fp_ops { · line 122

Quoted 6 lines
(quoted diff) +3 -2
-	struct rte_ethdev_qdata txq;
-	uintptr_t reserved2[3];
+	/** Copy used mbufs from Tx mbuf ring into Rx. */
+	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
+	uintptr_t reserved2[2];
 	/**@}*/

Removing existing fields should be announced explicitly.

Agreed. And the patch misses this. The "rxq" and "txq" fields are not being removed, they are being moved up in the structures. Your comment about explicit mentioning still applies!

If there's no time to wait for a new patch version from Feifei, perhaps you improve the description while merging.

#12 lore raw

28/07/2023 17:33, Morten Brørup:

Quoted 76 lines
Quoted 67 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 17.20

28/07/2023 17:08, Morten Brørup:

Quoted 22 lines
Quoted 22 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 16.57

04/07/2023 10:10, Feifei Wang:

Review

Quoted 10 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/doc/guides/rel_notes/deprecation.rst

Quoted 7 lines

index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst +0 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 2 lines
Quoted 2 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 122

Quoted 2 lines
doc/guides/rel_notes/deprecation.rst +2 -0
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be

updated

Quoted 38 lines
Quoted 1 line

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 1 line
doc/guides/rel_notes/deprecation.rst +1 -0
+  with new fields to support mbufs recycle mode from DPDK 23.11.

Existing fields will also be moved around [1]:

(quoted diff) +7 -4
@@ -83,15 +90,17 @@  struct rte_eth_fp_ops {
 	 * Rx fast-path functions and related data.
 	 * 64-bit systems: occupies first 64B line
 	 */
+	/** Rx queues data. */
+	struct rte_ethdev_qdata rxq;
 	/** PMD receive function. */
 	eth_rx_burst_t rx_pkt_burst;
 	/** Get the number of used Rx descriptors. */
 	eth_rx_queue_count_t rx_queue_count;
 	/** Check the status of a Rx descriptor. */
 	eth_rx_descriptor_status_t rx_descriptor_status;
-	/** Rx queues data. */
-	struct rte_ethdev_qdata rxq;
-	uintptr_t reserved1[3];
+	/** Refill Rx descriptors with the recycling mbufs. */
+	eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill;
+	uintptr_t reserved1[2];
 	/**@}*/
 
 	/**@{*/
@@ -99,15 +108,17 @@  struct rte_eth_fp_ops {
 	 * Tx fast-path functions and related data.
 	 * 64-bit systems: occupies second 64B line
 	 */
+	/** Tx queues data. */
+	struct rte_ethdev_qdata txq;
 	/** PMD transmit function. */
 	eth_tx_burst_t tx_pkt_burst;
 	/** PMD transmit prepare function. */
 	eth_tx_prep_t tx_pkt_prepare;
 	/** Check the status of a Tx descriptor. */
 	eth_tx_descriptor_status_t tx_descriptor_status;
-	/** Tx queues data. */
Quoted 8 lines

Review struct rte_eth_fp_ops { · line 122

Quoted 6 lines
(quoted diff) +3 -2
-	struct rte_ethdev_qdata txq;
-	uintptr_t reserved2[3];
+	/** Copy used mbufs from Tx mbuf ring into Rx. */
+	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
+	uintptr_t reserved2[2];
 	/**@}*/

Removing existing fields should be announced explicitly.

Quoted 3 lines

Agreed. And the patch misses this. The "rxq" and "txq" fields are not being removed, they are being moved up in the structures. Your comment about explicit mentioning still applies!

If there's no time to wait for a new patch version from Feifei, perhaps you improve the description while merging.

If it's only moving fields, we can skip. The real change is the size of the reserved fields, so it looks acceptable without notice.

#13 lore raw
Quoted 82 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 17.38

28/07/2023 17:33, Morten Brørup:

Quoted 19 lines
Quoted 19 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 17.20

28/07/2023 17:08, Morten Brørup:

Quoted 15 lines
Quoted 15 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 16.57

04/07/2023 10:10, Feifei Wang:

Review

Quoted 10 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/doc/guides/rel_notes/deprecation.rst

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 121

Quoted 8 lines

index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst +1 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev``

and

Quoted 15 lines
Quoted 15 lines
Quoted 1 line
Quoted 1 line

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 122

Quoted 1 line
doc/guides/rel_notes/deprecation.rst +1 -0
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be

updated

Quoted 13 lines
Quoted 1 line

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 123

Quoted 1 line
doc/guides/rel_notes/deprecation.rst +1 -0
+  with new fields to support mbufs recycle mode from DPDK 23.11.

Existing fields will also be moved around [1]:

(quoted diff) +2 -0
@@ -83,15 +90,17 @@  struct rte_eth_fp_ops {
 	 * Rx fast-path functions and related data.
 	 * 64-bit systems: occupies first 64B line
 	 */
+	/** Rx queues data. */
+	struct rte_ethdev_qdata rxq;
 	/** PMD receive function. */
 	eth_rx_burst_t rx_pkt_burst;
 	/** Get the number of used Rx descriptors. */
Quoted 8 lines
Quoted 8 lines

Review struct rte_eth_fp_ops { · line 102

Quoted 8 lines
(quoted diff) +2 -3
 	eth_rx_queue_count_t rx_queue_count;
 	/** Check the status of a Rx descriptor. */
 	eth_rx_descriptor_status_t rx_descriptor_status;
-	/** Rx queues data. */
-	struct rte_ethdev_qdata rxq;
-	uintptr_t reserved1[3];
+	/** Refill Rx descriptors with the recycling mbufs. */
+	eth_recycle_rx_descriptors_refill_t

recycle_rx_descriptors_refill;

Quoted 26 lines
Quoted 25 lines
Quoted 13 lines
(quoted diff) +3 -0
+	uintptr_t reserved1[2];
 	/**@}*/
 
 	/**@{*/
@@ -99,15 +108,17 @@  struct rte_eth_fp_ops {
 	 * Tx fast-path functions and related data.
 	 * 64-bit systems: occupies second 64B line
 	 */
+	/** Tx queues data. */
+	struct rte_ethdev_qdata txq;
 	/** PMD transmit function. */
 	eth_tx_burst_t tx_pkt_burst;
 	/** PMD transmit prepare function. */

Review struct rte_eth_fp_ops { · line 122

Quoted 10 lines
(quoted diff) +3 -3
 	eth_tx_prep_t tx_pkt_prepare;
 	/** Check the status of a Tx descriptor. */
 	eth_tx_descriptor_status_t tx_descriptor_status;
-	/** Tx queues data. */
-	struct rte_ethdev_qdata txq;
-	uintptr_t reserved2[3];
+	/** Copy used mbufs from Tx mbuf ring into Rx. */
+	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
+	uintptr_t reserved2[2];
 	/**@}*/

Removing existing fields should be announced explicitly.

Quoted 8 lines
Quoted 1 line

Agreed. And the patch misses this. The "rxq" and "txq" fields are not being

removed, they are being moved up in the structures. Your comment about explicit mentioning still applies!

Quoted 2 lines

If there's no time to wait for a new patch version from Feifei, perhaps you

improve the description while merging.

If it's only moving fields, we can skip.

OK. Thank you for elaborating.

Quoted 2 lines

The real change is the size of the reserved fields, so it looks acceptable without notice.

Agree.

Thoughts for later: We should perhaps document that changing the size of reserved fields is acceptable. And with that, if completely removing a reserved field is also acceptable or not.

#14 lore raw
Quoted 106 lines

-----Original Message-----
From: Morten Brørup <[email protected]>
Sent: Friday, July 28, 2023 11:55 PM
To: [email protected]
Cc: [email protected]; nd <[email protected]>; Honnappa Nagarahalli <[email protected]>; Feifei Wang <[email protected]>; Ruifeng Wang <[email protected]>; Feifei Wang <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH] doc: announce ethdev operation struct changes

Quoted 93 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 17.38

28/07/2023 17:33, Morten Brørup:

Quoted 26 lines
Quoted 26 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 17.20

28/07/2023 17:08, Morten Brørup:

Quoted 22 lines
Quoted 22 lines

From: Thomas Monjalon [mailto:[email protected]]
Sent: Friday, 28 July 2023 16.57

04/07/2023 10:10, Feifei Wang:

Review

Quoted 10 lines

To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11.

---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/doc/guides/rel_notes/deprecation.rst

Quoted 7 lines

index 66431789b0..c7e1ffafb2 100644

doc/guides/rel_notes/deprecation.rst +0 -0
@@ -118,6 +118,10 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 122

Quoted 2 lines
doc/guides/rel_notes/deprecation.rst +2 -0
+* ethdev: The Ethernet device data structure ``struct
+rte_eth_dev``

and

Quoted 16 lines
Quoted 16 lines
Quoted 2 lines
Quoted 2 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 124

Quoted 2 lines
doc/guides/rel_notes/deprecation.rst +2 -0
+  the fast-path ethdev flat array ``struct rte_eth_fp_ops``
+ will be

updated

Quoted 13 lines
Quoted 1 line

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 125

Quoted 1 line
doc/guides/rel_notes/deprecation.rst +1 -0
+  with new fields to support mbufs recycle mode from DPDK 23.11.

Existing fields will also be moved around [1]:

(quoted diff) +2 -0
@@ -83,15 +90,17 @@  struct rte_eth_fp_ops {
 	 * Rx fast-path functions and related data.
 	 * 64-bit systems: occupies first 64B line
 	 */
+	/** Rx queues data. */
+	struct rte_ethdev_qdata rxq;
 	/** PMD receive function. */
 	eth_rx_burst_t rx_pkt_burst;
 	/** Get the number of used Rx descriptors. */
Quoted 8 lines
Quoted 8 lines

Review struct rte_eth_fp_ops { · line 102

Quoted 8 lines
(quoted diff) +2 -3
 	eth_rx_queue_count_t rx_queue_count;
 	/** Check the status of a Rx descriptor. */
 	eth_rx_descriptor_status_t rx_descriptor_status;
-	/** Rx queues data. */
-	struct rte_ethdev_qdata rxq;
-	uintptr_t reserved1[3];
+	/** Refill Rx descriptors with the recycling mbufs. */
+	eth_recycle_rx_descriptors_refill_t

recycle_rx_descriptors_refill;

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
(quoted diff) +3 -1
+	uintptr_t reserved1[2];
 	/**@}*/
 
 	/**@{*/
@@ -99,15 +108,17 @@  struct rte_eth_fp_ops {
 	 * Tx fast-path functions and related data.
 	 * 64-bit systems: occupies second 64B line
 	 */
+	/** Tx queues data. */
+	struct rte_ethdev_qdata txq;
 	/** PMD transmit function. */
 	eth_tx_burst_t tx_pkt_burst;
 	/** PMD transmit prepare function. */
 	eth_tx_prep_t tx_pkt_prepare;
 	/** Check the status of a Tx descriptor. */
 	eth_tx_descriptor_status_t tx_descriptor_status;
-	/** Tx queues data. */
Quoted 8 lines

Review struct rte_eth_fp_ops { · line 122

Quoted 6 lines
(quoted diff) +3 -2
-	struct rte_ethdev_qdata txq;
-	uintptr_t reserved2[3];
+	/** Copy used mbufs from Tx mbuf ring into Rx. */
+	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
+	uintptr_t reserved2[2];
 	/**@}*/

Removing existing fields should be announced explicitly.

Quoted 2 lines

Agreed. And the patch misses this. The "rxq" and "txq" fields are not being

removed, they are being moved up in the structures. Your comment about explicit mentioning still applies!

Quoted 3 lines

If there's no time to wait for a new patch version from Feifei, perhaps you

improve the description while merging.

Quoted 8 lines
Quoted 1 line

If it's only moving fields, we can skip.

OK. Thank you for elaborating.

Quoted 2 lines

The real change is the size of the reserved fields, so it looks acceptable without notice.

Agree.

Sorry for my late. Agree with this change. And then, I will update a new version of recycle mbufs mode for dpdk 23.11

Quoted 4 lines

Thoughts for later: We should perhaps document that changing the size of reserved fields is acceptable. And with that, if completely removing a reserved field is also acceptable or not.