gitk errors out if launched in a subdirectory
PATCH 1/1 gitk errors out if launched in a subdirectory
Make gitk use git-rev-parse --git-dir to find the repository.
--- gitk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
gitk +1 -1
@@ -12,7 +12,7 @@ proc gitdir {} { if {[info exists env(GIT_DIR)]} { return $env(GIT_DIR) } else { - return ".git" + return [exec git rev-parse --git-dir] } }
Signature · 1 line
1.4.4.2
Is there something obviously wrong with this patch? It is the second time I send this (or a slight variant; last time I even removed the enviroment checking) and nobody answered.
Please say so if it is NAKed.
-Peter
Quoted 23 lines · Peter Baumann
Make gitk use git-rev-parse --git-dir to find the repository.
Signed-off-by Peter Baumann <[email protected]>--- gitk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)gitk +1
-1@@ -12,7 +12,7 @@ proc gitdir {} { if {[info exists env(GIT_DIR)]} { return $env(GIT_DIR) } else { - return ".git" + return [exec git rev-parse --git-dir] } }Signature · 1 line
1.4.4.2
Quoted 5 lines · Peter Baumann
Is there something obviously wrong with this patch? It is the second time I send this (or a slight variant; last time I even removed the enviroment checking) and nobody answered.
Please say so if it is NAKed.
No, it looks fine. It's just that gitk takes a lower priority than some other things in my life.
Paul.
Quoted 6 lines · Paul Mackerras
Quoted 4 lines · Peter Baumann
Is there something obviously wrong with this patch? It is the second time I send this (or a slight variant; last time I even removed the enviroment checking) and nobody answered.
Quoted 7 lines
Quoted 1 line
Please say so if it is NAKed.
No, it looks fine. It's just that gitk takes a lower priority than some other things in my life.
Paul.
Ok. No problem then. I just felt a little bit stupid after posting the this simple fix the second time and nobody carred.
-Peter
Quoted 5 lines · Peter Baumann
Is there something obviously wrong with this patch? It is the second time I send this (or a slight variant; last time I even removed the enviroment checking) and nobody answered.
Please say so if it is NAKed.
I am Ok with it if Paul is. I think it makes sense.