Skip to contentSkip to conversation

l2test: Fix calling getsockopt(BT_PHY)

PATCH Applied Luiz Augusto von Dentz 3 participants 3 messages Jul 7 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH v2 1/1 l2test: Fix calling getsockopt(BT_PHY)

From: Luiz Augusto von Dentz <[email protected]>

getsockopt(BT_PHY) expectes a 32 bits argument not a sizeof(struct sockaddr_l2).

---
 tools/l2test.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tools/l2test.c +4 -1
index aa05f5247c5e..08d2269936b9 100644
@@ -358,7 +358,8 @@ static int print_info(int sk, struct l2cap_options *opts)
 	struct sockaddr_l2 addr;
 	socklen_t optlen;
 	struct l2cap_conninfo conn;
-	int prio, phy;
+	int prio;
+	uint32_t phy;
 	char ba[18];
 
 	/* Get connection information */
@@ -414,6 +415,8 @@ static int print_info(int sk, struct l2cap_options *opts)
 		conn.dev_class[0], prio, rcvbuf);
 
 
+	optlen = sizeof(phy);
+
 	if (!getsockopt(sk, SOL_BLUETOOTH, BT_PHY, &phy, &optlen)) {
 		syslog(LOG_INFO, "Supported PHY: 0x%08x", phy);
 		print_bitfield(2, phy, phy_table);
Signature · 1 line
2.54.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1123158

---Test result---

Test Summary:

CheckPatch                    PASS      0.28 seconds
GitLint                       PASS      0.31 seconds
BuildEll                      PASS      20.94 seconds
BluezMake                     PASS      569.33 seconds
CheckSmatch                   PASS      315.20 seconds
bluezmakeextell               PASS      102.60 seconds
IncrementalBuild              PASS      557.19 seconds
ScanBuild                     PASS      988.52 seconds

https://github.com/bluez/bluez/pull/2276

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 7 lines · On Tue, 7 Jul 2026 10:55:36 -0400 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

getsockopt(BT_PHY) expectes a 32 bits argument not a sizeof(struct sockaddr_l2).

---
 tools/l2test.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ,v2] l2test: Fix calling getsockopt(BT_PHY)

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b84aa8949210

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html