Skip to contentSkip to conversation

dt-bindings: watchdog: microchip,pic32mzda-wdt: Convert to DT schema

PATCH Applied Udaya Kiran Challa 2 participants 5 messages Jun 24 – Aug 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: watchdog: microchip,pic32mzda-wdt: Convert to DT schema

Convert Microchip PIC32 Watchdog Timer devicetree binding from legacy text format to DT schema.

---
Changelog:

Changes since v1:
- Fix example indentation
- Correct example clock specifier from REF2CLK to LPRCCLK

Link to v1:https://lore.kernel.org/all/[email protected]/

---
 .../bindings/watchdog/microchip,pic32-wdt.txt | 18 --------
 .../watchdog/microchip,pic32mzda-wdt.yaml     | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32mzda-wdt.yaml
Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt deleted +0 -18
deleted file mode 100644
index f03a29a1b323..000000000000
@@ -1,18 +0,0 @@
-* Microchip PIC32 Watchdog Timer
-
-When enabled, the watchdog peripheral can be used to reset the device if the
-WDT is not cleared periodically in software.
-
-Required properties:
-- compatible: must be "microchip,pic32mzda-wdt".
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- clocks: phandle of source clk. Should be <&rootclk LPRCCLK>.
-
-Example:
-
-	watchdog@1f800800 {
-		compatible = "microchip,pic32mzda-wdt";
-		reg = <0x1f800800 0x200>;
-		clocks = <&rootclk LPRCCLK>;
-	};
Documentation/devicetree/bindings/watchdog/microchip,pic32mzda-wdt.yaml new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 12 lines · Udaya Kiran Challa

Convert Microchip PIC32 Watchdog Timer devicetree binding from legacy text format to DT schema.

---
Changelog:

Changes since v1:
- Fix example indentation
- Correct example clock specifier from REF2CLK to LPRCCLK

Quoted 8 lines

Link to v1:https://lore.kernel.org/all/[email protected]/

---
 .../bindings/watchdog/microchip,pic32-wdt.txt | 18 --------
 .../watchdog/microchip,pic32mzda-wdt.yaml     | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32mzda-wdt.yaml

Applied, thanks!

author
#2 lore raw
Quoted 24 lines · Rob Herring (Arm)
Quoted 12 lines · Udaya Kiran Challa

Convert Microchip PIC32 Watchdog Timer devicetree binding from legacy text format to DT schema.

---
Changelog:

Changes since v1:
- Fix example indentation
- Correct example clock specifier from REF2CLK to LPRCCLK

Quoted 8 lines

Link to v1:https://lore.kernel.org/all/[email protected]/

---
 .../bindings/watchdog/microchip,pic32-wdt.txt | 18 --------
 .../watchdog/microchip,pic32mzda-wdt.yaml     | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32mzda-wdt.yaml
Quoted 2 lines

Applied, thanks!

Thank you, Rob. There are similar microchip, pic32mzda patches related to spi, sqi & rtc which are reviewed/acknowledged.

1. microchip,pic32mzda-spi.yaml
https://lore.kernel.org/all/20260622-ingenious-finch-of-fantasy-7bafaf@quoll/

2. microchip,pic32mzda-sqi.yaml
https://lore.kernel.org/all/20260625-omen-stark-6bb827ebcc43@spud/

3. microchip,pic32mzda-rtc.yaml
https://lore.kernel.org/all/20260703-identify-cringe-ef88079923cd@spud/

Please let me know if any further action is required from my end to merge in the
mainline.

Regards,
Udaya Kiran Challa

maintainer
#3 lore raw
Quoted 25 lines · Uday Kiran
Quoted 24 lines · Rob Herring (Arm)
Quoted 20 lines · Udaya Kiran Challa

Convert Microchip PIC32 Watchdog Timer devicetree binding from legacy text format to DT schema.

---
Changelog:

Changes since v1:
- Fix example indentation
- Correct example clock specifier from REF2CLK to LPRCCLK

Link to v1:https://lore.kernel.org/all/[email protected]/

---
 .../bindings/watchdog/microchip,pic32-wdt.txt | 18 --------
 .../watchdog/microchip,pic32mzda-wdt.yaml     | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/microchip,pic32mzda-wdt.yaml
Quoted 5 lines
Quoted 2 lines

Applied, thanks!

Thank you, Rob. There are similar microchip, pic32mzda patches related to spi, sqi & rtc which are reviewed/acknowledged.

I picked up watchdog only because watchdog DT patches have a tendency to get missed.

Quoted 5 lines

1. microchip,pic32mzda-spi.yaml
https://lore.kernel.org/all/20260622-ingenious-finch-of-fantasy-7bafaf@quoll/

2. microchip,pic32mzda-sqi.yaml
https://lore.kernel.org/all/20260625-omen-stark-6bb827ebcc43@spud/

You missed sending to linux-spi and/or Mark B on these. You'll need to send another version.

Quoted 3 lines

3. microchip,pic32mzda-rtc.yaml
https://lore.kernel.org/all/20260703-identify-cringe-ef88079923cd@spud/

You missed Alexandre.

In general, use what get_maintainers.pl gives you.

Rob

author
#4 lore raw
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

Applied, thanks!

Thank you, Rob. There are similar microchip, pic32mzda patches related to spi, sqi & rtc which are reviewed/acknowledged.

I picked up watchdog only because watchdog DT patches have a tendency to get missed.

Understood Rob. Thank you very much for picking up the patches.

Quoted 9 lines
Quoted 6 lines

1. microchip,pic32mzda-spi.yaml
https://lore.kernel.org/all/20260622-ingenious-finch-of-fantasy-7bafaf@quoll/

2. microchip,pic32mzda-sqi.yaml
https://lore.kernel.org/all/20260625-omen-stark-6bb827ebcc43@spud/

You missed sending to linux-spi and/or Mark B on these. You'll need to send another version.

Sorry, I missed to include SPI subsystem maintainers. I will include and send updated patches.

Quoted 6 lines
Quoted 4 lines

3. microchip,pic32mzda-rtc.yaml
https://lore.kernel.org/all/20260703-identify-cringe-ef88079923cd@spud/

You missed Alexandre.

Alexandre Belloni <[email protected]> is in the send list. Not sure why it is not picked up.

Regards,
Udaya Kiran Challa