mpls: fix NULL deref in mpls_valid_fib_dump_req() on CONFIG_INET=n
Subsystems (2)
PATCH 1/1 mpls: fix NULL deref in mpls_valid_fib_dump_req() on CONFIG_INET=n
On CONFIG_INET=n builds, mpls_valid_fib_dump_req() walks the parsed attribute table itself instead of calling ip_valid_fib_dump_req(). The RTA_OIF arm passes tb[RTA_OIF] to nla_get_u32() without checking it is present, so an RTM_GETROUTE dump for AF_MPLS with strict checking and no RTA_OIF hits a NULL dereference.
RTM_GETROUTE is RTNL_KIND_GET, which rtnetlink_rcv_msg() permits without CAP_NET_ADMIN, so an unprivileged user can trigger it.
Oops: general protection fault, probably for non-canonical address
0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
RIP: 0010:mpls_valid_fib_dump_req (net/mpls/af_mpls.c:2189)
Call Trace:
mpls_dump_routes (net/mpls/af_mpls.c:2236)
netlink_dump (net/netlink/af_netlink.c:2331)
__netlink_dump_start (net/netlink/af_netlink.c:2446)
rtnetlink_rcv_msg (net/core/rtnetlink.c:7033)
netlink_rcv_skb (net/netlink/af_netlink.c:2556)
netlink_unicast (net/netlink/af_netlink.c:1345)
netlink_sendmsg (net/netlink/af_netlink.c:1900)
__sock_sendmsg (net/socket.c:790)
____sys_sendmsg (net/socket.c:2684)
___sys_sendmsg (net/socket.c:2738)
__sys_sendmsg (net/socket.c:2770)
do_syscall_64 (arch/x86/entry/syscall_64.c:94)
entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:121)Skip unset attributes, as ip_valid_fib_dump_req() does.
--- net/mpls/af_mpls.c | 3 +++ 1 file changed, 3 insertions(+)
net/mpls/af_mpls.c +3 -0
@@ -2186,6 +2186,9 @@ static int mpls_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh,int ifindex;if (i ==RTA_OIF ) { +if (!tb[i]) +continue ; + ifindex =nla_get_u32 (tb[i]); filter->dev =dev_get_by_index_rcu (net, ifindex);if (!filter->dev)
Signature · 1 line
2.43.0
Quoted 43 lines · Weiming Shi
On
CONFIG_INET=nbuilds,mpls_valid_fib_dump_req()walks the parsed attribute table itself instead of callingip_valid_fib_dump_req(). TheRTA_OIFarm passes tb[RTA_OIF] tonla_get_u32()without checking it is present, so anRTM_GETROUTEdump forAF_MPLSwith strict checking and noRTA_OIFhits a NULL dereference.
RTM_GETROUTEisRTNL_KIND_GET, whichrtnetlink_rcv_msg()permits withoutCAP_NET_ADMIN, so an unprivileged user can trigger it.Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] RIP: 0010:mpls_valid_fib_dump_req (net/mpls/af_mpls.c:2189) Call Trace: mpls_dump_routes (net/mpls/af_mpls.c:2236) netlink_dump (net/netlink/af_netlink.c:2331) __netlink_dump_start (net/netlink/af_netlink.c:2446) rtnetlink_rcv_msg (net/core/rtnetlink.c:7033) netlink_rcv_skb (net/netlink/af_netlink.c:2556) netlink_unicast (net/netlink/af_netlink.c:1345) netlink_sendmsg (net/netlink/af_netlink.c:1900) __sock_sendmsg (net/socket.c:790) ____sys_sendmsg (net/socket.c:2684) ___sys_sendmsg (net/socket.c:2738) __sys_sendmsg (net/socket.c:2770) do_syscall_64 (arch/x86/entry/syscall_64.c:94) entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:121)Skip unset attributes, as
ip_valid_fib_dump_req()does.Fixes 196cfebf8972 ("net/mpls: Handle kernel side filtering of route dumps")Assisted-by Claude:claude-opus-4-8Reported-by Xiang Mei <[email protected]>Signed-off-by Weiming Shi <[email protected]>--- net/mpls/af_mpls.c | 3 +++ 1 file changed, 3 insertions(+)net/mpls/af_mpls.c +0
-0
net/mpls/af_mpls.c static int mpls_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh, · line 2194
Quoted 9 lines
net/mpls/af_mpls.c +3
-0@@ -2186,6 +2186,9 @@ static int mpls_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh,int ifindex;if (i ==RTA_OIF ) { +if (!tb[i]) +continue ; + ifindex =nla_get_u32 (tb[i]); filter->dev =dev_get_by_index_rcu (net, ifindex);if (!filter->dev)
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 10 lines · On Sat, 11 Jul 2026 04:50:00 -0700 you wrote:
On
CONFIG_INET=nbuilds,mpls_valid_fib_dump_req()walks the parsed attribute table itself instead of callingip_valid_fib_dump_req(). TheRTA_OIFarm passes tb[RTA_OIF] tonla_get_u32()without checking it is present, so anRTM_GETROUTEdump forAF_MPLSwith strict checking and noRTA_OIFhits a NULL dereference.
RTM_GETROUTEisRTNL_KIND_GET, whichrtnetlink_rcv_msg()permits withoutCAP_NET_ADMIN, so an unprivileged user can trigger it.[...]
Here is the summary with links:
- [net] mpls: fix NULL deref in mpls_valid_fib_dump_req() on CONFIG_INET=n
https://git.kernel.org/netdev/net/c/56d96fededd6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html