rxrpc: fix io_thread race in rxrpc_wake_up_io_thread()
Subsystems (3)
PATCH 1/1 rxrpc: fix io_thread race in rxrpc_wake_up_io_thread()
From: Xuanqiang Luo <[email protected]>
rxrpc_wake_up_io_thread() checks local->io_thread before waking it, but then reloads the pointer for wake_up_process().
local->io_thread is cleared with WRITE_ONCE() when the I/O thread exits, so the second load can see NULL even if the first load did not.
Take a READ_ONCE() snapshot and use it for both the NULL check and the wake_up_process() call, as rxrpc_encap_rcv() already does.
--- net/rxrpc/ar-internal.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/rxrpc/ar-internal.h +4 -2
@@ -1285,9 +1285,11 @@ int rxrpc_io_thread(void *data);void rxrpc_post_response (struct rxrpc_connection *conn,struct sk_buff *skb);static inline void rxrpc_wake_up_io_thread (struct rxrpc_local *local) { -if (!local->io_thread) +struct task_struct *io_thread =READ_ONCE (local->io_thread); + +if (!io_thread)return ; -wake_up_process (READ_ONCE (local->io_thread)); +wake_up_process (io_thread); }static inline bool rxrpc_protocol_error (struct sk_buff *skb,enum rxrpc_abort_reason why)
Signature · 1 line
2.43.0
Quoted 5 lines · On Wed, Jul 08, 2026 at 05:35:34PM +0800, [email protected] wrote:
From: Xuanqiang Luo <[email protected]>
rxrpc_wake_up_io_thread()checkslocal->io_threadbefore waking it, but then reloads the pointer forwake_up_process().
Quoted 8 lines
local->io_threadis cleared withWRITE_ONCE()when the I/O thread exits, so the second load can see NULL even if the first load did not.Take a
READ_ONCE()snapshot and use it for both the NULL check and thewake_up_process()call, asrxrpc_encap_rcv()already does.Fixes 5800b1cf3fd8 ("rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE")Signed-off-by Xuanqiang Luo <[email protected]>
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 9 lines · On Wed, 8 Jul 2026 17:35:34 +0800 you wrote:
From: Xuanqiang Luo <[email protected]>
rxrpc_wake_up_io_thread()checkslocal->io_threadbefore waking it, but then reloads the pointer forwake_up_process().
local->io_threadis cleared withWRITE_ONCE()when the I/O thread exits, so the second load can see NULL even if the first load did not.[...]
Here is the summary with links:
- [net,v1] rxrpc: fix io_thread race in rxrpc_wake_up_io_thread()
https://git.kernel.org/netdev/net/c/745fb794c3e9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html