net: airoha: Fix potential use-after-free in airoha_ppe_deinit()
Subsystems (4)
PATCH 1/1 net: airoha: Fix potential use-after-free in airoha_ppe_deinit()
airoha_ppe_deinit() replaces the NPU pointer with NULL via rcu_replace_pointer() but does not wait for existing RCU readers to exit before calling ppe_deinit() and airoha_npu_put(). This can cause a use-after-free if a reader in an RCU read-side critical section still holds a reference to the NPU when it is freed.
The init path (airoha_ppe_init) already calls synchronize_rcu() after rcu_assign_pointer(), but the deinit path introduced in commit 6abcf751bc08 ("net: airoha: Fix schedule while atomic in airoha_ppe_deinit()") omitted the matching barrier when switching from rcu_read_lock()/rcu_dereference() to rcu_replace_pointer().
Add synchronize_rcu() before ppe_deinit() to ensure all existing RCU readers have completed before the NPU resources are released.
--- drivers/net/ethernet/airoha/airoha_ppe.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/airoha/airoha_ppe.c +1 -0
@@ -1659,6 +1659,7 @@ void airoha_ppe_deinit(struct airoha_eth *eth) npu =rcu_replace_pointer (eth->npu,NULL ,lockdep_is_held (&flow_offload_mutex));if (npu) { +synchronize_rcu (); npu->ops.ppe_deinit (npu);airoha_npu_put (npu); }
Signature · 1 line
2.51.0
Quoted 12 lines
airoha_ppe_deinit()replaces the NPU pointer with NULL viarcu_replace_pointer()but does not wait for existing RCU readers to exit before callingppe_deinit()andairoha_npu_put(). This can cause a use-after-free if a reader in an RCU read-side critical section still holds a reference to the NPU when it is freed.The init path (
airoha_ppe_init) already callssynchronize_rcu()afterrcu_assign_pointer(), but the deinit path introduced in commit6abcf751bc08("net: airoha: Fix schedule while atomic inairoha_ppe_deinit()") omitted the matching barrier when switching from rcu_read_lock()/rcu_dereference() torcu_replace_pointer().
Quoted 5 lines
Add
synchronize_rcu()beforeppe_deinit()to ensure all existing RCU readers have completed before the NPU resources are released.Fixes 6abcf751bc084804a9e5b3051442e8a2ce67f48a ("net: airoha: Fix schedule while atomic in airoha_ppe_deinit()")Signed-off-by Wayen Yan <[email protected]>
Quoted 20 lines
--- drivers/net/ethernet/airoha/airoha_ppe.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/airoha/airoha_ppe.c +1
-0@@ -1659,6 +1659,7 @@ void airoha_ppe_deinit(struct airoha_eth *eth) npu =rcu_replace_pointer (eth->npu,NULL ,lockdep_is_held (&flow_offload_mutex));if (npu) { +synchronize_rcu (); npu->ops.ppe_deinit (npu);airoha_npu_put (npu); }Signature · 1 line
2.51.0
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 6 lines · On Wed, 8 Jul 2026 19:16:16 +0800 you wrote:
airoha_ppe_deinit()replaces the NPU pointer with NULL viarcu_replace_pointer()but does not wait for existing RCU readers to exit before callingppe_deinit()andairoha_npu_put(). This can cause a use-after-free if a reader in an RCU read-side critical section still holds a reference to the NPU when it is freed.
Quoted 7 lines
The init path (
airoha_ppe_init) already callssynchronize_rcu()afterrcu_assign_pointer(), but the deinit path introduced in commit6abcf751bc08("net: airoha: Fix schedule while atomic inairoha_ppe_deinit()") omitted the matching barrier when switching from rcu_read_lock()/rcu_dereference() torcu_replace_pointer().[...]
Here is the summary with links:
- [net] net: airoha: Fix potential use-after-free in airoha_ppe_deinit()
https://git.kernel.org/netdev/net/c/2484568a335c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html