fou: Fix use-after-free in fou_create()
Subsystems (3)
PATCH 1/1 fou: Fix use-after-free in fou_create()
From: Xuanqiang Luo <[email protected]>
fou_create() publishes struct fou through sk_user_data before adding the new FOU port to the per-netns list. If fou_add_to_port_list() fails, the error path frees fou while it is still reachable through sk_user_data. A concurrent receive can then dereference the freed object in fou_from_sock().
This ordering issue was previously noted in the linked discussion.
The failure is reachable when local port 0 is requested. Each socket binds to a different ephemeral port, but fou_cfg_cmp() compares the requested port 0 and reports -EALREADY once an entry already exists.
Release the tunnel socket before freeing fou so sk_user_data is cleared first, and defer reclamation with kfree_rcu() to protect concurrent RCU readers. This matches the lifetime handling in fou_release().
--- net/ipv4/fou_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/fou_core.c +1 -1
@@ -629,9 +629,9 @@ static int fou_create(struct net *net, struct fou_cfg *cfg,return 0 ; error: -kfree (fou);if (sock)udp_tunnel_sock_release (sock->sk); +kfree_rcu (fou, rcu);return err; }
Signature · 1 line
2.43.0
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 9 lines · On Wed, 22 Jul 2026 16:38:58 +0800 you wrote:
From: Xuanqiang Luo <[email protected]>
fou_create()publishes struct fou throughsk_user_databefore adding the new FOU port to the per-netns list. Iffou_add_to_port_list()fails, the error path frees fou while it is still reachable throughsk_user_data. A concurrent receive can then dereference the freed object infou_from_sock().[...]
Here is the summary with links:
- [net,v1] fou: Fix use-after-free in fou_create()
https://git.kernel.org/netdev/net/c/b14361aca635
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html