bap: fixed the return value of GIOFunc
PATCH v2 1/1 bap: fixed the return value of GIOFunc
The GIOFunc should return FALSE if the event source should be removed.
---
Changes in v2:
- Fix BAD_FIXES_TAG
- Link to v1: https://patch.msgid.link/[email protected]
--- profiles/audio/bap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
profiles/audio/bap.c +1 -3
@@ -3683,7 +3683,6 @@ static gboolean iso_do_big_sync(GIOChannel *io, GIOCondition cond, BT_IO_OPT_INVALID)) {error ("bt_io_set: %s" , err->message);g_error_free (err); -return FALSE; } if (!bt_io_bcast_accept(io,
@@ -3694,10 +3693,9 @@ static gboolean iso_do_big_sync(GIOChannel *io, GIOCondition cond, iso_bc_addr.bc_bis, BT_IO_OPT_INVALID)) {error ("bt_io_bcast_accept: %s" , err->message);g_error_free (err); -return FALSE; } -return TRUE; +return FALSE; }static void long_pa_sync_confirm_cb (GIOChannel *io,void *user_data)
---
base-commit: 729f96089cf66831d911385623ca932e0c245913
change-id: 20260729-fix_iofunc-e62cecc52b8e
Best regards,
Signature · 1 line
Yang Li <[email protected]>
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1136408
---Test result---
Test Summary:
CheckPatch FAIL 0.41 seconds GitLint PASS 0.30 seconds BuildEll PASS 21.06 seconds BluezMake PASS 551.31 seconds MakeCheck PASS 3.73 seconds MakeDistcheck PASS 162.74 seconds CheckValgrind PASS 161.22 seconds CheckSmatch PASS 317.67 seconds bluezmakeextell PASS 103.40 seconds IncrementalBuild PASS 552.80 seconds ScanBuild PASS 991.92 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,bluez,v2] bap: fixed the return value of GIOFunc
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 322c39a64323 ("bap: Start BIG sync after receiving BIGInfo")' #77:
/github/workspace/src/patch/14717383.patch total: 0 errors, 1 warnings, 18 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/patch/14717383.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
https://github.com/bluez/bluez/pull/2358
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 9 lines · On Wed, 29 Jul 2026 14:51:43 +0800 you wrote:
From: Yang Li <[email protected]>
The GIOFunc should return FALSE if the event source should be removed.
Fixes 322c39a64 ("bap: Start BIG sync after receiving BIGInfo")Signed-off-by Yang Li <[email protected]>[...]
Here is the summary with links:
- [BlueZ,bluez,v2] bap: fixed the return value of GIOFunc
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=66d19bb2a027
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html