ipvlan: inherit needed_headroom and needed_tailroom from phy_dev
Subsystems (2)
PATCH v2 1/1 ipvlan: inherit needed_headroom and needed_tailroom from phy_dev
ipvlan devices inherit hard_header_len from phy_dev during ipvlan_init(), but leave needed_headroom and needed_tailroom set to 0.
When the underlying phy_dev (or stacked lower device) requires extra headroom or tailroom for headers/trailers (e.g. macsec, ipsec, wireguard, tunnels, or veth with rx headroom), upper layers calculating packet headroom and tailroom fail to reserve sufficient space.
This can result in reallocation overhead, skb headroom underflows, or KASAN slab-use-after-free crashes when dev_hard_header() / ipvlan_hard_header() prepends header data or when lower devices append tailroom.
Fix this by:
1. Inheriting needed_headroom and needed_tailroom from phy_dev in ipvlan_init().
2. Propagating needed_headroom and needed_tailroom updates to attached ipvlans in ipvlan_device_event() when receiving NETDEV_FEAT_CHANGE events.
---
v2: also inherit needed_tailroom (Sashiko)
v1: https://lore.kernel.org/netdev/CANn89iLr4EQxBAKikZCeXbXEk-pjmT4mq3d=D2P01MtNSUgwrg@mail.gmail.com/T/#t
drivers/net/ipvlan/ipvlan_main.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ipvlan/ipvlan_main.c +4 -0
@@ -146,6 +146,8 @@ static int ipvlan_init(struct net_device *dev) dev->lltx = true;netif_inherit_tso_max (dev, phy_dev); dev->hard_header_len = phy_dev->hard_header_len; + dev->needed_headroom = phy_dev->needed_headroom; + dev->needed_tailroom = phy_dev->needed_tailroom;netdev_lockdep_set_classes (dev);
@@ -773,6 +775,8 @@ static int ipvlan_device_event(struct notifier_block *unused,case NETDEV_FEAT_CHANGE :list_for_each_entry (ipvlan, &port->ipvlans, pnode) {netif_inherit_tso_max (ipvlan->dev, dev); + ipvlan->dev->needed_headroom = dev->needed_headroom; + ipvlan->dev->needed_tailroom = dev->needed_tailroom;netdev_update_features (ipvlan->dev); }break ;
Signature · 1 line
2.55.0.629.g250fe7f194-goog
Quoted 55 lines · Eric Dumazet
ipvlan devices inherit
hard_header_lenfromphy_devduringipvlan_init(), but leaveneeded_headroomandneeded_tailroomset to 0.When the underlying
phy_dev(or stacked lower device) requires extra headroom or tailroom for headers/trailers (e.g. macsec, ipsec, wireguard, tunnels, or veth with rx headroom), upper layers calculating packet headroom and tailroom fail to reserve sufficient space.This can result in reallocation overhead, skb headroom underflows, or KASAN slab-use-after-free crashes when
dev_hard_header()/ipvlan_hard_header()prepends header data or when lower devices append tailroom.Fix this by:
1. Inheritingneeded_headroomandneeded_tailroomfromphy_devinipvlan_init().
2. Propagatingneeded_headroomandneeded_tailroomupdates to attached ipvlans inipvlan_device_event()when receivingNETDEV_FEAT_CHANGEevents.Fixes 2ad7bfab3016 ("ipvlan: Initial check-in of the IPVLAN driver.")Reported-by [email protected]Reported-by Tangxin Xie <[email protected]>Closes https://lore.kernel.org/netdev/CANn89i+1EW-sFNK8xoq98gMbPCeLS7e=+rs9gHfLg5Wj+4x0sw@mail.gmail.com/T/#mcc6307f115e500df23ea2980d5669fe95f20b6b4 open hereSigned-off-by Eric Dumazet <[email protected]>---
v2: also inheritneeded_tailroom(Sashiko)
v1: https://lore.kernel.org/netdev/CANn89iLr4EQxBAKikZCeXbXEk-pjmT4mq3d=D2P01MtNSUgwrg@mail.gmail.com/T/#t
drivers/net/ipvlan/ipvlan_main.c| 4 ++++1 file changed, 4 insertions(+)drivers/net/ipvlan/ipvlan_main.c +4
-0@@ -146,6 +146,8 @@ static int ipvlan_init(struct net_device *dev) dev->lltx = true;netif_inherit_tso_max (dev, phy_dev); dev->hard_header_len = phy_dev->hard_header_len; + dev->needed_headroom = phy_dev->needed_headroom; + dev->needed_tailroom = phy_dev->needed_tailroom;netdev_lockdep_set_classes (dev);@@ -773,6 +775,8 @@ static int ipvlan_device_event(struct notifier_block *unused,case NETDEV_FEAT_CHANGE :list_for_each_entry (ipvlan, &port->ipvlans, pnode) {netif_inherit_tso_max (ipvlan->dev, dev); + ipvlan->dev->needed_headroom = dev->needed_headroom; + ipvlan->dev->needed_tailroom = dev->needed_tailroom;netdev_update_features (ipvlan->dev); }break ;Signature · 1 line
2.55.0.629.g250fe7f194-goog
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 6 Aug 2026 10:38:57 +0000 you wrote:
ipvlan devices inherit
hard_header_lenfromphy_devduringipvlan_init(), but leaveneeded_headroomandneeded_tailroomset to 0.When the underlying
phy_dev(or stacked lower device) requires extra headroom or tailroom for headers/trailers (e.g. macsec, ipsec, wireguard, tunnels, or veth with rx headroom), upper layers calculating packet headroom and tailroom fail to reserve sufficient space.[...]
Here is the summary with links:
- [v2,net] ipvlan: inherit needed_headroom and needed_tailroom from phy_dev
https://git.kernel.org/netdev/net/c/e16e960d55a4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html