Skip to contentSkip to conversation

iplink/can: fix format string warnings

PATCH Applied Stephen Hemminger 2 participants 2 messages Aug 24 – Aug 25

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iplink/can: fix format string warnings

Clang complains about non-literal format string

iplink_can.c:531:36: warning: format string is not a string literal

        [-Wformat-nonliteral]
    531 |                 can_print_timing_min_max("tdcv", tdcv, *tdcv_min, *...
        |                                                  ^~~~

Small change to use "%s" in can_print_timing_min_max.

---
 ip/iplink_can.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
ip/iplink_can.c +2 -2
index f631aab8..450a19b9 100644
@@ -448,11 +448,11 @@ static void can_print_nl_indent(void)
 	print_string(PRINT_FP, NULL, "%s", "\t ");
 }
 
-static void __attribute__((format(printf, 2, 0)))
+static void
 can_print_timing_min_max(const char *json_attr, const char *fp_attr,
 			 int min, int max)
 {
-	print_null(PRINT_FP, NULL, fp_attr, NULL);
+	print_string(PRINT_FP, NULL, "%s", fp_attr);
 	open_json_object(json_attr);
 	print_uint(PRINT_ANY, "min", " %d", min);
 	print_uint(PRINT_ANY, "max", "..%d", max);
Signature · 1 line
2.53.0
#1 lore raw
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Hello:

This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Quoted 8 lines · On Mon, 24 Aug 2026 09:49:22 -0700 you wrote:

Clang complains about non-literal format string

iplink_can.c:531:36: warning: format string is not a string literal

        [-Wformat-nonliteral]
    531 |                 can_print_timing_min_max("tdcv", tdcv, *tdcv_min, *...
        |                                                  ^~~~

[...]

Here is the summary with links:
- [iproute2] iplink/can: fix format string warnings

    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=4766edf1462e

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html