Skip to contentSkip to conversation

Media CODEC Fixes 2025-10-17

GIT PULL Nicolas Dufresne 2 participants 3 messages Oct 17, 2025 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro, Hans,

This pull request contains a collection of bug fixes in various codec drivers and an improved validation of AV1 sequence parameters.

cheers,
Nicolas

p.s. sorry for the previous empty subject request.

---

The following changes since commit 082b86919b7a94de01d849021b4da820a6cb89dc:

media: v4l2-mem2mem: Fix outdated documentation (2025-10-14 15:07:37 +0200)

are available in the Git repository at:

https://gitlab.freedesktop.org/linux-media/users/ndufresne.git tags/for-6.19-media-codec-fixes-2025-10-17

for you to fetch changes up to 60d4fac49415810bd4d07b18570065999e318a7b:

media: allegro: fix race conditions in channel handling (2025-10-16 09:32:55 -0400)

----------------------------------------------------------------
Various CODEC bug fixes

----------------------------------------------------------------
Chen-Yu Tsai (1):
media: mediatek: vcodec: Use spinlock for context list protection lock

Haoxiang Li (1):
media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()

Johan Hovold (1):
media: platform: mtk-mdp3: fix device leaks at probe

Matthias Fend (3):
media: allegro: print warning if channel creation timeout occurs
media: allegro: process all pending status mbox messages
media: allegro: fix race conditions in channel handling

Ming Qian (2):
media: amphion: Remove vpu_vb_is_codecconfig
media: amphion: Cancel message work before releasing the VPU core

Nicolas Dufresne (2):
media: verisilicon: Fix CPU stalls on G2 bus error
media: verisilicon: Protect G2 HEVC decoder against invalid DPB index

Pavan Bobba (1):
media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

 drivers/media/platform/allegro-dvt/allegro-core.c                   | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------
 drivers/media/platform/amphion/vpu_malone.c                         |  23 +++--------------------
 drivers/media/platform/amphion/vpu_v4l2.c                           |  16 +++-------------
 drivers/media/platform/amphion/vpu_v4l2.h                           |  10 ----------
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c                |  14 ++++++++++++++
 drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c   |  14 +++++++++-----
 drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c |  12 +++++++-----
 drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h |   2 +-
 drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c        |   5 +++--
 drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c |  12 +++++++-----
 drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.h |   2 +-
 drivers/media/platform/mediatek/vcodec/encoder/venc_vpu_if.c        |   5 +++--
 drivers/media/platform/verisilicon/hantro_g2.c                      |  88 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c             |  17 +++++++++++++----
 drivers/media/platform/verisilicon/hantro_g2_regs.h                 |  13 +++++++++++++
 drivers/media/platform/verisilicon/hantro_g2_vp9_dec.c              |   2 --
 drivers/media/platform/verisilicon/hantro_hw.h                      |   1 +
 drivers/media/platform/verisilicon/imx8m_vpu_hw.c                   |   2 ++
 drivers/media/v4l2-core/v4l2-ctrls-core.c                           | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------
 19 files changed, 340 insertions(+), 137 deletions(-)
Signature · 6 lines
Nicolas Dufresne
Principal Engineer at Collabora

-- 
Nicolas Dufresne
Principal Engineer at Collabora
#1 lore raw

Hi,

Quoted 5 lines · Nicolas Dufresne

Hi Mauro, Hans,

This pull request contains a collection of bug fixes in various codec drivers and an improved validation of AV1 sequence parameters.

Is it possible to fast track these for 6.18? Some of these fix fatal errors.

Quoted 17 lines

cheers,
Nicolas

p.s. sorry for the previous empty subject request.

---

The following changes since commit 082b86919b7a94de01d849021b4da820a6cb89dc:

media: v4l2-mem2mem: Fix outdated documentation (2025-10-14 15:07:37 +0200)

are available in the Git repository at:

https://gitlab.freedesktop.org/linux-media/users/ndufresne.git tags/for-6.19-media-codec-fixes-2025-10-17

for you to fetch changes up to 60d4fac49415810bd4d07b18570065999e318a7b:

Quoted 8 lines

media: allegro: fix race conditions in channel handling (2025-10-16 09:32:55 -0400)

----------------------------------------------------------------
Various CODEC bug fixes

----------------------------------------------------------------
Chen-Yu Tsai (1):
media: mediatek: vcodec: Use spinlock for context list protection lock

This one.

Quoted 12 lines

Haoxiang Li (1):
media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()

Johan Hovold (1):
media: platform: mtk-mdp3: fix device leaks at probe

Matthias Fend (3):
media: allegro: print warning if channel creation timeout occurs
media: allegro: process all pending status mbox messages
media: allegro: fix race conditions in channel handling

Quoted 6 lines

Ming Qian (2):
media: amphion: Remove vpu_vb_is_codecconfig
media: amphion: Cancel message work before releasing the VPU core

Nicolas Dufresne (2):
media: verisilicon: Fix CPU stalls on G2 bus error

This one.

Quoted 1 line

media: verisilicon: Protect G2 HEVC decoder against invalid DPB index

And maybe this one?

Thanks
ChenYu

Quoted 32 lines

Pavan Bobba (1):
media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

 drivers/media/platform/allegro-dvt/allegro-core.c                   | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------
 drivers/media/platform/amphion/vpu_malone.c                         |  23 +++--------------------
 drivers/media/platform/amphion/vpu_v4l2.c                           |  16 +++-------------
 drivers/media/platform/amphion/vpu_v4l2.h                           |  10 ----------
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c                |  14 ++++++++++++++
 drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c   |  14 +++++++++-----
 drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c |  12 +++++++-----
 drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h |   2 +-
 drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c        |   5 +++--
 drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c |  12 +++++++-----
 drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.h |   2 +-
 drivers/media/platform/mediatek/vcodec/encoder/venc_vpu_if.c        |   5 +++--
 drivers/media/platform/verisilicon/hantro_g2.c                      |  88 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c             |  17 +++++++++++++----
 drivers/media/platform/verisilicon/hantro_g2_regs.h                 |  13 +++++++++++++
 drivers/media/platform/verisilicon/hantro_g2_vp9_dec.c              |   2 --
 drivers/media/platform/verisilicon/hantro_hw.h                      |   1 +
 drivers/media/platform/verisilicon/imx8m_vpu_hw.c                   |   2 ++
 drivers/media/v4l2-core/v4l2-ctrls-core.c                           | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------
 19 files changed, 340 insertions(+), 137 deletions(-)

--
Nicolas Dufresne
Principal Engineer at Collabora

--
Nicolas Dufresne
Principal Engineer at Collabora

#2 lore raw

Hi Wens,

Le samedi 18 octobre 2025 à 01:35 +0800, Chen-Yu Tsai a écrit :

Quoted 5 lines

Hi,

Quoted 1 line · Nicolas Dufresne
Quoted 7 lines
Quoted 5 lines

Hi Mauro, Hans,

This pull request contains a collection of bug fixes in various codec drivers
and an improved validation of AV1 sequence parameters.

Is it possible to fast track these for 6.18? Some of these fix fatal errors.

I'm afraid this is as fast as it can go. These have been broken for several releases before someone picked it up, so it makes little sense to complicate the process.

Quoted 49 lines
Quoted 23 lines

cheers,
Nicolas

p.s. sorry for the previous empty subject request.

---

The following changes since commit 082b86919b7a94de01d849021b4da820a6cb89dc:

  media: v4l2-mem2mem: Fix outdated documentation (2025-10-14 15:07:37 +0200)

are available in the Git repository at:

  https://gitlab.freedesktop.org/linux-media/users/ndufresne.git tags/for-
6.19-media-codec-fixes-2025-10-17

for you to fetch changes up to 60d4fac49415810bd4d07b18570065999e318a7b:

  media: allegro: fix race conditions in channel handling (2025-10-16 09:32:55 -0400)

Quoted 6 lines

----------------------------------------------------------------
Various CODEC bug fixes

----------------------------------------------------------------
Chen-Yu Tsai (1):
      media: mediatek: vcodec: Use spinlock for context list protection lock

This one.

Quoted 17 lines

Haoxiang Li (1):
      media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()

Johan Hovold (1):
      media: platform: mtk-mdp3: fix device leaks at probe

Matthias Fend (3):
      media: allegro: print warning if channel creation timeout occurs
      media: allegro: process all pending status mbox messages
      media: allegro: fix race conditions in channel handling

Ming Qian (2):
      media: amphion: Remove vpu_vb_is_codecconfig
      media: amphion: Cancel message work before releasing the VPU core

Quoted 8 lines
Quoted 2 lines

Nicolas Dufresne (2):
      media: verisilicon: Fix CPU stalls on G2 bus error

This one.

Quoted 1 line

      media: verisilicon: Protect G2 HEVC decoder against invalid DPB index

And maybe this one?

I don't disagree with you these are (for Hantro G2 users) quite bad when hit. For a little more context, the first makes the error non-fatal, and the second makes the error go away (at least the one I could narrow down using skippable frames at the start of a gop).

cheers,
Nicolas

Quoted 59 lines

Thanks
ChenYu

Quoted 54 lines

Pavan Bobba (1):
      media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

 drivers/media/platform/allegro-dvt/allegro-core.c                   | 114
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+++++++++++++++-----------------------
 drivers/media/platform/amphion/vpu_malone.c                         |  23
+++--------------------
 drivers/media/platform/amphion/vpu_v4l2.c                           |  16
+++-------------
 drivers/media/platform/amphion/vpu_v4l2.h                           |  10 -
---------
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c                |  14
++++++++++++++
 drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c   |  14
+++++++++-----
 drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c |  12
+++++++-----
 drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h |   2

+-
 drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c        |   5

+++--
 drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c |  12
+++++++-----
 drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.h |   2

+-
 drivers/media/platform/mediatek/vcodec/encoder/venc_vpu_if.c        |   5

+++--
 drivers/media/platform/verisilicon/hantro_g2.c                      |  88
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
------------
 drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c             |  17
+++++++++++++----
 drivers/media/platform/verisilicon/hantro_g2_regs.h                 |  13
+++++++++++++
 drivers/media/platform/verisilicon/hantro_g2_vp9_dec.c              |   2 - -
 drivers/media/platform/verisilicon/hantro_hw.h                      |   1 + drivers/media/platform/verisilicon/imx8m_vpu_hw.c                   |   2 ++
 drivers/media/v4l2-core/v4l2-ctrls-core.c                           | 125
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++++++++-------------------------

 19 files changed, 340 insertions(+), 137 deletions(-)

--
Nicolas Dufresne
Principal Engineer at Collabora

--
Nicolas Dufresne
Principal Engineer at Collabora