exportfs cleanups
Subsystems (2)
cover exportfs cleanups
This patch series has 8 patches to clean up the code flow of fs/exportfs/expfs.c, and it's interface to the NFS server.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 2 lines · On Wednesday March 7, [email protected] wrote:
This patch series has 8 patches to clean up the code flow of
fs/exportfs/expfs.c, and it's interface to the NFS server.
Thanks for these. They look good. That code certainly need some cleaning up.
I didn't get 6/8. Could you resend?
Patch 5/8 removes a number of comments without adding any.
Do you think it would be valuable to add a comment explaining the subtleties for why directories and files are handled differently.
Patch 8/8 I should look through again to make sure all the dentry references look right (I found them easy to get wrong). Splitting up find_exported_dentry was definitely a good idea.
You left in a comment in "If we weren't after a directory" in a place were we know we weren't, so at least it should be "Since we weren't....".
The rest all look fine.
Thanks,
NeilBrown
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 8 lines · Neil Brown
Quoted 2 lines · On Wednesday March 7, [email protected] wrote:
This patch series has 8 patches to clean up the code flow of
fs/exportfs/expfs.c, and it's interface to the NFS server.Thanks for these. They look good. That code certainly need some cleaning up.
I didn't get 6/8. Could you resend?
Done.
Quoted 3 lines
Patch 5/8 removes a number of comments without adding any.
Do you think it would be valuable to add a comment explaining the subtleties for why directories and files are handled differently.
To me the new code was clear enough to explain what's going on, but I can send another patch ontop of the patch series adding and updating some comments.
Quoted 6 lines
Patch 8/8 I should look through again to make sure all the dentry references look right (I found them easy to get wrong). Splitting up
find_exported_dentrywas definitely a good idea.
You left in a comment in "If we weren't after a directory" in a place were we know we weren't, so at least it should be "Since we weren't....".
Yes. I noticed this and remove it in an so far unsubmitted patch later in the series, but it really should be in that patch.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs