net: stmmac: Disable unsolicited checksum insertion for AF_XDP TX
Subsystems (4)
PATCH 1/1 net: stmmac: Disable unsolicited checksum insertion for AF_XDP TX
stmmac enables TX checksum insertion for every AF_XDP packet on queues that support it. The driver does not implement tmo_request_checksum(), so it enables the offload regardless of whether the application requested it and ignores the requested checksum offsets.
Disable checksum insertion in the AF_XDP TX path. Applications must supply complete checksums until the driver can honor AF_XDP checksum metadata.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 -2
@@ -2683,7 +2683,6 @@ static bool stmmac_xdp_xmit_zc(struct stmmac_priv *priv, u32 queue, u32 budget)struct netdev_queue *nq =netdev_get_tx_queue (priv->dev, queue);struct stmmac_tx_queue *tx_q = &priv->dma_conf.tx_queue[queue];struct stmmac_txq_stats *txq_stats = &priv->xstats.txq_stats[queue]; -bool csum = !priv->plat->tx_queues_cfg[queue].coe_unsupported;struct xsk_buff_pool *pool = tx_q->xsk_pool;unsigned int entry = tx_q->cur_tx;struct dma_desc *tx_desc =NULL ;
@@ -2762,7 +2761,7 @@ static bool stmmac_xdp_xmit_zc(struct stmmac_priv *priv, u32 queue, u32 budget) }stmmac_prepare_tx_desc (priv, tx_desc,1 , xdp_desc.len, - csum, priv->descriptor_mode, true, true, + false, priv->descriptor_mode, true, true, xdp_desc.len);stmmac_enable_dma_transmission (priv, priv->ioaddr, queue);
Signature · 1 line
2.53.0
[email protected]
AI reviewThis is an automated message. This series looks like a fix, but its commit messages seem to be missing some information:
Hi!
This is an automated message. This series looks like a fix, but its commit messages seem to be missing some information:
- How the issue was discovered, e.g. hit in production, hit during development, syzbot report, manual code inspection, LLM or static analysis tool scan.
- Whether the issue was actually triggered, or is only theoretical (e.g. found by code inspection). If it was triggered please include the symptoms, like the stack trace or error messages.
- What hardware the change was tested on. For driver fixes please mention the device (and if relevant firmware version) used for testing, or say that the change was not tested on real hardware.
Please do not repost the series just to address the above. Instead, reply to this email with the missing information, so that reviewers can take it into account. If the series needs another revision for other reasons, please include the information in the commit messages then.
The evaluation is done by an LLM so it may be wrong, if you think that is the case please reply and explain.
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Tue, 29 Sep 2026 20:10:32 +0800 you wrote:
stmmac enables TX checksum insertion for every
AF_XDPpacket on queues that support it. The driver does not implementtmo_request_checksum(), so it enables the offload regardless of whether the application requested it and ignores the requested checksum offsets.Disable checksum insertion in the
AF_XDPTX path. Applications must supply complete checksums until the driver can honorAF_XDPchecksum metadata.[...]
Here is the summary with links:
- net: stmmac: Disable unsolicited checksum insertion for AF_XDP TX
https://git.kernel.org/netdev/net-next/c/ecf5985006dd
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html