Skip to contentSkip to conversation

net: alacritech: fix dma_free_coherent() in error path

PATCH Applied Thomas Fourier 5 participants 5 messages Oct 6 – Oct 13

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: alacritech: fix dma_free_coherent() in error path

In slic_init_stat_queue(), a series of coherent buffers is allocated with the length size. The size is then stored in stq->mem_size for normal deallocation. However, in the error path, stq->mem_size is also used but is not initialized. This error may leave the freed buffers mapped, leaking a resource and allowing the device to access freed memory.

Change the length in error path to size.

Fixes 60c140df15db ("net: ethernet: slicoss: add slicoss gigabit ethernet driver")
---
 drivers/net/ethernet/alacritech/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/alacritech/slicoss.c +1 -1
index c1949ca060ca..311a9d1d9071 100644
@@ -813,7 +813,7 @@ static int slic_init_stat_queue(struct slic_device *sdev)
 
 free_descs:
 	while (i--) {
-		dma_free_coherent(&sdev->pdev->dev, stq->mem_size,
+		dma_free_coherent(&sdev->pdev->dev, size,
 				  stq->descs[i] - stq->addr_offset[i],
 				  stq->paddr[i] - stq->addr_offset[i]);
 	}
Signature · 1 line
2.43.0
#1 lore raw
This is an automated message. This series looks like a fix, but its commit messages seem to be missing some information:

Hi!

This is an automated message. This series looks like a fix, but its commit messages seem to be missing some information:

- How the issue was discovered, e.g. hit in production, hit during development, syzbot report, manual code inspection, LLM or static analysis tool scan.

- Whether the issue was actually triggered, or is only theoretical (e.g. found by code inspection). If it was triggered please include the symptoms, like the stack trace or error messages.

- What hardware the change was tested on. For driver fixes please mention the device (and if relevant firmware version) used for testing, or say that the change was not tested on real hardware.

Please do not repost the series just to address the above. Instead, reply to this email with the missing information, so that reviewers can take it into account. If the series needs another revision for other reasons, please include the information in the commit messages then.

The evaluation is done by an LLM so it may be wrong, if you think that is the case please reply and explain.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Fourier
Quoted 9 lines

In slic_init_stat_queue(), a series of coherent buffers is allocated with the length size. The size is then stored in stq->mem_size for normal deallocation. However, in the error path, stq->mem_size is also used but is not initialized. This error may leave the freed buffers mapped, leaking a resource and allowing the device to access freed memory.

Change the length in error path to size.

maintainer
#3 lore raw
In reply to Thomas Fourier
Quoted 7 lines · Thomas Fourier

In slic_init_stat_queue(), a series of coherent buffers is allocated with the length size. The size is then stored in stq->mem_size for normal deallocation. However, in the error path, stq->mem_size is also used but is not initialized. This error may leave the freed buffers mapped, leaking a resource and allowing the device to access freed memory.

Quoted 5 lines

Change the length in error path to size.

Fixes 60c140df15db ("net: ethernet: slicoss: add slicoss gigabit ethernet driver")

FTR, bad things in NIC error path for old drivers is the exact prototype of things we are actively redirecting to net-next at this point of the cycle. Also stripping the stable tag.

/P

#4 lore raw
In reply to Thomas Fourier
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Tue, 6 Oct 2026 16:09:09 +0200 you wrote:

In slic_init_stat_queue(), a series of coherent buffers is allocated with the length size. The size is then stored in stq->mem_size for normal deallocation. However, in the error path, stq->mem_size is also used but is not initialized. This error may leave the freed buffers mapped, leaking a resource and allowing the device to access freed memory.

[...]

Here is the summary with links:
- [net] net: alacritech: fix dma_free_coherent() in error path

    https://git.kernel.org/netdev/net-next/c/05b5019b01fb

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html