Skip to contentSkip to conversation

graph-depends: add missing -show-depends targets in Makefile

PATCH New Thomas De Schampheleire 2 participants 3 messages Jun 30, 2014 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 graph-depends: add missing -show-depends targets in Makefile

When running 'make graph-depends' on a configuration selecting toolchain-eclipse-register or target-generatelocales, the command fails:

make[1]: *** No rule to make target `target-generatelocales-show-depends'. Stop.

This patch adds the missing -show-depends targets.

---
 Makefile |  6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Makefile +6 -0
diff -r 4d6d2ac6a601 -r 179177855010 Makefile
@@ -621,6 +621,9 @@
 			-i $${inputfile} -f $${charmap} \
 			$${locale} ; \
 	done
+
+target-generatelocales-show-depends:
+	@echo host-localedef toolchain
 endif
 
 target-post-image: $(TARGETS_ROOTFS) target-finalize
@@ -631,6 +634,9 @@
 toolchain-eclipse-register: toolchain
 	./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)
 
+toolchain-eclipse-register-show-depends:
+	@echo toolchain
+
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)
 
 external-deps:
#1 lore raw

PATCH 1/1 graph-depends: add missing -show-depends targets in Makefile

Dear Thomas De Schampheleire,

Quoted 28 lines · Thomas De Schampheleire

When running 'make graph-depends' on a configuration selecting toolchain-eclipse-register or target-generatelocales, the command fails:

make[1]: *** No rule to make target `target-generatelocales-show-depends'. Stop.

This patch adds the missing -show-depends targets.

---
 Makefile |  6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff -r 4d6d2ac6a601 -r 179177855010 Makefile

Makefile +3 -0
@@ -621,6 +621,9 @@
 			-i $${inputfile} -f $${charmap} \
 			$${locale} ; \
 	done
+
+target-generatelocales-show-depends:
+	@echo host-localedef toolchain
 endif
 
 target-post-image: $(TARGETS_ROOTFS) target-finalize

Makefile line 640

Quoted 7 lines
Makefile +3 -0
@@ -631,6 +634,9 @@
 toolchain-eclipse-register: toolchain
 	./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)
 
+toolchain-eclipse-register-show-depends:
+	@echo toolchain
+
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)

Your tree is not up-to-date, both of these targets have been converted to TARGET_FINALIZE_HOOKS, so the problem you're seeing shouldn't occur I believe. Am I missing something?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 graph-depends: add missing -show-depends targets in Makefile

Quoted 34 lines · Thomas Petazzoni

Dear Thomas De Schampheleire,

Quoted 31 lines · Thomas De Schampheleire

When running 'make graph-depends' on a configuration selecting toolchain-eclipse-register or target-generatelocales, the command fails:

make[1]: *** No rule to make target `target-generatelocales-show-depends'. Stop.

This patch adds the missing -show-depends targets.

---
 Makefile |  6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff -r 4d6d2ac6a601 -r 179177855010 Makefile

Makefile Mon Jun 30 13:11:11 2014 +0200 renamed from Makefile Thu Jun 19 18:13:36 2014 +0200 +3 -0
@@ -621,6 +621,9 @@
                      -i $${inputfile} -f $${charmap} \
                      $${locale} ; \
      done
+
+target-generatelocales-show-depends:
+     @echo host-localedef toolchain
 endif
 
 target-post-image: $(TARGETS_ROOTFS) target-finalize
@@ -631,6 +634,9 @@
 toolchain-eclipse-register: toolchain
      ./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)
 
Quoted 8 lines

Makefile Mon Jun 30 13:11:11 2014 +0200 line 640

Quoted 4 lines
Makefile Mon Jun 30 13:11:11 2014 +0200 renamed from Makefile Thu Jun 19 18:13:36 2014 +0200 +3 -0
+toolchain-eclipse-register-show-depends:
+     @echo toolchain
+
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)

Your tree is not up-to-date, both of these targets have been converted to TARGET_FINALIZE_HOOKS, so the problem you're seeing shouldn't occur I believe. Am I missing something?

Grumbl, yes this seems to have been committed yesterday after I last synced. Nevermind then, I'll mark the patch as Rejected in patchwork.

Best regards,
Thomas