Skip to contentSkip to conversation

riscv: dts: spacemit: k3: fix IMSIC num-guest-ids

PATCH Applied Guo Ren 4 participants 5 messages Aug 17 – Nov 1

Subsystems (4)
lore
Share & tools
lore

Guo Ren

author
#0 lore raw

PATCH v2 1/1 riscv: dts: spacemit: k3: fix IMSIC num-guest-ids

From: "GUO Ren (XuanTie)" <[email protected]>

The initial K3 device tree used generic/placeholder values for the IMSIC guest configuration:

  riscv,num-guest-ids    = <511>;

According to the SpacemiT K3 User Manual this values is incorrect for the X100 cores:

- Advanced Interrupt Architecture (AIA):
- M-mode MSI: 512
- S-mode MSI: 512
- VS-mode MSI: 64

Therefore, S-mode IMSIC (simsic) needs num-guest-ids = 63.

Fixes 56f37e391a62 ("riscv: dts: spacemit: add initial support for K3 SoC")
Cc Guodong Xu <[email protected]>
Cc Yixun Lan <[email protected]>

---
V2:
- Drop the riscv,guest-index-bits change for simsic: the property describes the number of guest index bits in the MSI target address, and the per-hart stride on K3 is 0x40000 = 2^(6 + 12), so 6 is correct as is.
- Drop the mimsic changes: already fixed by Junhui.
- Reword the subject and commit log accordingly.

---
 arch/riscv/boot/dts/spacemit/k3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k3.dtsi +1 -1
index 19fc9b49668e..4a4a9ec7c981 100644
@@ -1129,7 +1129,7 @@ simsic: interrupt-controller@e0400000 {
 			msi-controller;
 			riscv,guest-index-bits = <6>;
 			riscv,hart-index-bits = <4>;
-			riscv,num-guest-ids = <511>;
+			riscv,num-guest-ids = <63>;
 			riscv,num-ids = <511>;
 		};
 
Signature · 1 line
2.43.0
maintainer Reviewed-by on v2 1/1
#1 lore raw

Hi Guo

Quoted 30 lines · Guo Ren

From: "GUO Ren (XuanTie)" <[email protected]>

The initial K3 device tree used generic/placeholder values for the IMSIC guest configuration:

  riscv,num-guest-ids    = <511>;

According to the SpacemiT K3 User Manual this values is incorrect for the X100 cores:

- Advanced Interrupt Architecture (AIA):
- M-mode MSI: 512
- S-mode MSI: 512
- VS-mode MSI: 64

Therefore, S-mode IMSIC (simsic) needs num-guest-ids = 63.

Fixes 56f37e391a62 ("riscv: dts: spacemit: add initial support for K3 SoC")
Cc Guodong Xu <[email protected]>
Cc Yixun Lan <[email protected]>

---
V2:
- Drop the riscv,guest-index-bits change for simsic: the property describes the number of guest index bits in the MSI target address, and the per-hart stride on K3 is 0x40000 = 2^(6 + 12), so 6 is correct as is.
- Drop the mimsic changes: already fixed by Junhui.
- Reword the subject and commit log accordingly.

Quoted 4 lines
---
 arch/riscv/boot/dts/spacemit/k3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
Yixun Lan (dlan)
Reviewed-by on v2 1/1
#2 lore raw
In reply to Guo Ren

Hi Guo,

Quoted 15 lines · Guo Ren

From: "GUO Ren (XuanTie)" <[email protected]>

The initial K3 device tree used generic/placeholder values for the IMSIC guest configuration:

  riscv,num-guest-ids    = <511>;

According to the SpacemiT K3 User Manual this values is incorrect for the X100 cores:

- Advanced Interrupt Architecture (AIA):
- M-mode MSI: 512
- S-mode MSI: 512
- VS-mode MSI: 64

Quoted 7 lines

Therefore, S-mode IMSIC (simsic) needs num-guest-ids = 63.

Fixes 56f37e391a62 ("riscv: dts: spacemit: add initial support for K3 SoC")
Cc Guodong Xu <[email protected]>
Cc Yixun Lan <[email protected]>
Signature · 2 lines
Best regards,
Junhui Liu
maintainer Applied
#3 lore raw
In reply to Guo Ren
Quoted 9 lines · Guo Ren

The initial K3 device tree used generic/placeholder values for the IMSIC guest configuration:

  riscv,num-guest-ids    = <511>;

According to the SpacemiT K3 User Manual this values is incorrect for the X100 cores:

[...]

Applied, thanks!

[1/1] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids

      https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=69f95409f0053f787ad60175944080621a8b7d95

Best regards,

Signature · 1 line
Yixun Lan <[email protected]>
#4 lore raw
In reply to Guo Ren
This patch was applied to riscv/linux.git (fixes) by Yixun Lan <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (fixes)
by Yixun Lan <[email protected]>:

Quoted 8 lines · On Mon, 17 Aug 2026 03:30:38 +0000 you wrote:

From: "GUO Ren (XuanTie)" <[email protected]>

The initial K3 device tree used generic/placeholder values for the IMSIC guest configuration:

  riscv,num-guest-ids    = <511>;

[...]

Here is the summary with links:
- [V2] riscv: dts: spacemit: k3: fix IMSIC num-guest-ids

    https://git.kernel.org/riscv/c/69f95409f005

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html