Skip to contentSkip to conversation

drm/bridge: tc358767: register DP aux bus even in DRM_BRIDGE_ATTACH_NO_CONNECTOR case

PATCH Applied Alexander Stein 2 participants 3 messages Sep 29 – Nov 11

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/bridge: tc358767: register DP aux bus even in DRM_BRIDGE_ATTACH_NO_CONNECTOR case

Even if DRM_BRIDGE_ATTACH_NO_CONNECTOR is set the DP aux bus has to be registered. Move the flags check after registration.

---
Changes in v2:
* Drop other patches. With commit b6829ee511c77 ("drm/bridge: tc358767: don't create a panel_bridge") in linux-next the other patches are no longer necessary.

 drivers/gpu/drm/bridge/tc358767.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/bridge/tc358767.c +3 -3
index 51f4baa62a53e..9b8d3d3ceb8c8 100644
@@ -1831,14 +1831,14 @@ static int tc_edp_bridge_attach(struct drm_bridge *bridge,
 			return ret;
 	}
 
-	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
-		return 0;
-
 	tc->aux.drm_dev = drm;
 	ret = drm_dp_aux_register(&tc->aux);
 	if (ret < 0)
 		return ret;
 
+	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
+		return 0;
+
 	/* Create DP/eDP connector */
 	drm_connector_helper_add(&tc->connector, &tc_connector_helper_funcs);
 	ret = drm_connector_init(drm, &tc->connector, &tc_connector_funcs, tc->bridge.type);
Signature · 1 line
2.55.0
reviewer Applied
#2 lore raw
In reply to Alexander Stein
Quoted 2 lines · Alexander Stein

Even if DRM_BRIDGE_ATTACH_NO_CONNECTOR is set the DP aux bus has to be registered. Move the flags check after registration.

Applied, thanks!

[1/1] drm/bridge: tc358767: register DP aux bus even in DRM_BRIDGE_ATTACH_NO_CONNECTOR case

      commit: d360c8eba0f174ae81d2a1343a7371bd7514429d

Best regards,

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com