Skip to contentSkip to conversation

Some settings can not be set back from "Good" to "Bad"

Powertop Martin Walch 2 participants 2 messages Apr 23, 2016 – Apr 26, 2016

lore
Share & tools
lore

Martin Walch

author
#0 lore raw

Hi,

it is possible to toggle some settings like "Enable Audio codec power management" from "Bad" to "Good" and back again. However, when exiting powertop while it is set to "Good", and then re-running powertop, the value is stuck at "Good", i.e. it is not possible to toggle it to "Bad". When trying to do so, the status line only shows ">> (null)" instead of something like "echo '' > '/sys/module/snd_hda_intel/parameters/power_save';".

This is probably because sysfs_tunable::bad_value is initialized with "\0" and does not change its value if it is already set to "Good" when starting up powertop. When now calling sysfs_tunable::toggle(void), strlen(bad_value) is 0 and the write_sysfs line is not executed.

Is it possible to fix this?

Regards,
Martin Walch

#1 lore raw

Hi Martin,

It is possible-- it's just a matter of time and scarcity thereof (in my case, anyway). If you'd like to file a bug report (doesn't have to be elaborate), we could see how the community may be able to help:

https://app.devzing.com/powertopbugs/bugzilla

Cheers, hth

Quoted 24 lines · Martin Walch

Hi,

it is possible to toggle some settings like "Enable Audio codec power management" from "Bad" to "Good" and back again. However, when exiting powertop while it is set to "Good", and then re-running powertop, the value is stuck at "Good", i.e. it is not possible to toggle it to "Bad". When trying to do so, the status line only shows ">> (null)" instead of something like "echo '' > '/sys/module/snd_hda_intel/parameters/power_save';".

This is probably because sysfs_tunable::bad_value is initialized with "\0" and does not change its value if it is already set to "Good" when starting up powertop. When now calling sysfs_tunable::toggle(void), strlen(bad_value) is 0 and the write_sysfs line is not executed.

Is it possible to fix this?

Regards,
Martin Walch

Signature · 4 lines
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop