Skip to contentSkip to conversation

ixgbe: Fix phy errors in stats->ierrors

PATCH Applied Maryam Tahhan 5 participants 5 messages Jul 20, 2015 – Jul 23, 2015 Network drivers

lore
Share & tools
lore

Maryam Tahhan

author
#0 lore raw

PATCH v2 1/1 ixgbe: Fix phy errors in stats->ierrors

Fixes f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove

(rxnfgpc - hw_stats->gprc) which does not account for phy errors. hw_stats->gprc is the Number of good (non-erred) Rx packets (from the network) that pass L2 filtering and has a legal length as defined by LongPacketEnable. While rxnfgpc is the Number of good (non-erred with legal length) Rx packets (from the network) regardless of packet filtering and receive enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation should be removed from the calculation of ierrors. Validated with testpmd by sending packets to the interface without forwarding enabled - packets should be dropped and the error counters incremented.

v2:
- specified the commit that this bug fix fixes.

Signed-off-by Maryam Tahhan <[email protected]>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_ethdev.c +1 -2
index 3a8cff0..09fac25 100644
@@ -2143,8 +2143,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	                  hw_stats->rfc +
 	                  hw_stats->rjc +
 	                  hw_stats->fccrc +
-	                  hw_stats->fclast +
-	                  (rxnfgpc - hw_stats->gprc); /* PHY Errors*/
+	                  hw_stats->fclast;
 
 	/* Tx Errors */
 	/*txdgpc: packets that are DMA'ed*/
Signature · 1 line
2.4.3
#1 lore raw

PATCH v2 1/1 ixgbe: Fix phy errors in stats->ierrors

Quoted 12 lines
Fixes f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove

(rxnfgpc - hw_stats->gprc) which does not account for phy errors. hw_stats->gprc is the Number of good (non-erred) Rx packets (from the network) that pass L2 filtering and has a legal length as defined by LongPacketEnable. While rxnfgpc is the Number of good (non-erred with legal length) Rx packets (from the network) regardless of packet filtering and receive enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation should be removed from the calculation of ierrors. Validated with testpmd by sending packets to the interface without forwarding enabled - packets should be dropped and the error counters incremented.

Quoted 2 lines

v2:
- specified the commit that this bug fix fixes

Acked-by Balazs Nemeth <balazs.nemeth at intel.com>
Acked-by on v2 1/1
#2 lore raw
In reply to Maryam Tahhan

Hi,

Quoted 17 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Maryam Tahhan
Sent: Monday, July 20, 2015 8:28 PM
To: [email protected]
Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors

Fixes f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove

(rxnfgpc - hw_stats->gprc) which does not account for phy errors. hw_stats->gprc is the Number of good (non-erred) Rx packets (from the network) that pass L2 filtering and has a legal length as defined by LongPacketEnable. While rxnfgpc is the Number of good (non-erred with legal length) Rx packets (from the network) regardless of packet filtering and receive enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation should be removed from the calculation of ierrors.
Validated with testpmd by sending packets to the interface without forwarding enabled - packets should be dropped and the error counters incremented.

Quoted 4 lines

v2:
- specified the commit that this bug fix fixes.

Signed-off-by Maryam Tahhan <[email protected]>
Acked-by Wenzhuo Lu <[email protected]>
Tested-by
#3 lore raw
Tested-by Marvin Liu <[email protected]>
Quoted 36 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Lu, Wenzhuo
Sent: Tuesday, July 21, 2015 1:41 PM
To: Tahhan, Maryam; [email protected]
Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats-

Quoted 1 line

ierrors

Hi,

Quoted 7 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Maryam Tahhan
Sent: Monday, July 20, 2015 8:28 PM
To: [email protected]
Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats- ierrors

Quoted 5 lines
Fixes f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove

(rxnfgpc - hw_stats->gprc) which does not account for phy errors. hw_stats->gprc is the Number of good (non-erred) Rx packets (from the network) that pass L2 filtering and has a legal length as defined by LongPacketEnable. While rxnfgpc is the Number of good (non-erred with

legal

Quoted 1 line

length) Rx packets (from the network) regardless of packet filtering and

receive

Quoted 1 line

enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation

should

Quoted 2 lines

be removed from the calculation of ierrors.
Validated with testpmd by sending packets to the interface without

forwarding

Quoted 6 lines

enabled - packets should be dropped and the error counters incremented.

v2:
- specified the commit that this bug fix fixes.

Signed-off-by Maryam Tahhan <[email protected]>
Acked-by Wenzhuo Lu <[email protected]>
Applied
#4 lore raw
Quoted 13 lines
Quoted 13 lines
Quoted 5 lines
Fixes f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove

(rxnfgpc - hw_stats->gprc) which does not account for phy errors. hw_stats->gprc is the Number of good (non-erred) Rx packets (from the network) that pass L2 filtering and has a legal length as defined by LongPacketEnable. While rxnfgpc is the Number of good (non-erred with

legal

Quoted 1 line

length) Rx packets (from the network) regardless of packet filtering and

receive

Quoted 1 line

enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation

should

Quoted 2 lines

be removed from the calculation of ierrors.
Validated with testpmd by sending packets to the interface without

forwarding

Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

enabled - packets should be dropped and the error counters incremented.

v2:
- specified the commit that this bug fix fixes.

Signed-off-by Maryam Tahhan <[email protected]>
Acked-by Wenzhuo Lu <[email protected]>
Tested-by Marvin Liu <[email protected]>

Applied, thanks