Skip to contentSkip to conversation

arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory

PATCH kernel test robot 4 participants 12 messages Jan 30, 2024 – Feb 1, 2024

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git linux-4.4.y-st-rc
head:   4daf8df4558b5aae717516f7e941014c463772c2
commit: 193e83a8194fcb23b6fb4aea9518a67b786df1c5 [878/1809] m68k: Only force 030 bus error if PC not in exception table
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20240130/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory
    #include <linux/extable.h>
             ^~~~~~~~~~~~~~~~~

compilation terminated.

vim +32 arch/m68k/kernel/traps.c

  > 32	#include <linux/extable.h>
    33
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#1 lore raw
Quoted 12 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git linux-4.4.y-st-rc
head:   4daf8df4558b5aae717516f7e941014c463772c2
commit: 193e83a8194fcb23b6fb4aea9518a67b786df1c5 [878/1809] m68k: Only force 030 bus error if PC not in exception table
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20240130/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 6 lines

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory

    #include <linux/extable.h>
             ^~~~~~~~~~~~~~~~~

compilation terminated.

Either include <linux/module.h> instead, or backport commit 0ef7653797addea8 ("exceptions: fork exception table content from module.h into extable.h") in v4.8?

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw

Hi Geert,

Quoted 15 lines · Geert Uytterhoeven
Quoted 14 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git linux-4.4.y-st-rc
head:   4daf8df4558b5aae717516f7e941014c463772c2
commit: 193e83a8194fcb23b6fb4aea9518a67b786df1c5 [878/1809] m68k: Only force 030 bus error if PC not in exception table
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20240130/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line

arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory

     #include <linux/extable.h>
              ^~~~~~~~~~~~~~~~~
    compilation terminated.

Either include <linux/module.h> instead, or backport commit 0ef7653797addea8 ("exceptions: fork exception table content from module.h into extable.h") in v4.8?

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

Does the /proc/sysrq_trigger mechanism exist in 4.4? Might otherwise drop that patch from 4.4.

Cheers,

    Michael

Quoted 4 lines

Gr{oetje,eeting}s,

Geert

#3 lore raw

Hi Geert,

Quoted 19 lines · Michael Schmitz

Hi Geert,

Quoted 16 lines · Geert Uytterhoeven
Quoted 15 lines · kernel test robot

tree: https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git linux-4.4.y-st-rc
head:   4daf8df4558b5aae717516f7e941014c463772c2
commit: 193e83a8194fcb23b6fb4aea9518a67b786df1c5 [878/1809] m68k: Only force 030 bus error if PC not in exception table
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20240130/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

     #include <linux/extable.h>
              ^~~~~~~~~~~~~~~~~
    compilation terminated.

Either include <linux/module.h> instead, or backport commit 0ef7653797addea8 ("exceptions: fork exception table content from module.h into extable.h") in v4.8?

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

On second thought - backporting that commit would break anything in 4.4 that includes module.h for exception table stuff.

module.h was where the exception table handling used to live prior to 4.8, so my patch ought to be changed to include that one.

Cheers,

    Michael

Quoted 12 lines

Does the /proc/sysrq_trigger mechanism exist in 4.4? Might otherwise drop that patch from 4.4.

Cheers,

    Michael

Quoted 4 lines

Gr{oetje,eeting}s,

                         Geert

#4 lore raw

Hi Michael,

Quoted 33 lines · Michael Schmitz
Quoted 32 lines · Michael Schmitz
Quoted 30 lines · Geert Uytterhoeven
Quoted 19 lines · kernel test robot

tree:
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git
linux-4.4.y-st-rc

head:   4daf8df4558b5aae717516f7e941014c463772c2
commit: 193e83a8194fcb23b6fb4aea9518a67b786df1c5 [878/1809] m68k:

Only force 030 bus error if PC not in exception table
config: m68k-allnoconfig
(https://download.01.org/0day-ci/archive/20240130/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 7.5.0 reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20240130/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 7 lines

All errors (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory

     #include <linux/extable.h>
              ^~~~~~~~~~~~~~~~~
    compilation terminated.

Either include <linux/module.h> instead, or backport commit 0ef7653797addea8 ("exceptions: fork exception table content from module.h into extable.h") in v4.8?

Quoted 5 lines
Quoted 2 lines

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

On second thought - backporting that commit would break anything in 4.4 that includes module.h for exception table stuff.

Why? <linux/module.h> still includes the new <linux/extable.h>, so existing users of <linux/module.h.> should be fine.

Plain v4.4 + these two commits seems to build fine for me (modulo the issues due to my cross-compiler being too new for v4.4 ;-).

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#5 lore raw

Hi Geert,

Quoted 35 lines · Geert Uytterhoeven

Hi Michael,

Quoted 32 lines · Michael Schmitz
Quoted 31 lines · Michael Schmitz
Quoted 30 lines · Geert Uytterhoeven
Quoted 19 lines · kernel test robot

tree:
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git
linux-4.4.y-st-rc

head:   4daf8df4558b5aae717516f7e941014c463772c2
commit: 193e83a8194fcb23b6fb4aea9518a67b786df1c5 [878/1809] m68k:

Only force 030 bus error if PC not in exception table
config: m68k-allnoconfig
(https://download.01.org/0day-ci/archive/20240130/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 7.5.0 reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20240130/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 7 lines

All errors (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

arch/m68k/kernel/traps.c:32:10: fatal error: linux/extable.h: No such file or directory

      #include <linux/extable.h>
               ^~~~~~~~~~~~~~~~~
     compilation terminated.

Either include <linux/module.h> instead, or backport commit 0ef7653797addea8 ("exceptions: fork exception table content from module.h into extable.h") in v4.8?

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

On second thought - backporting that commit would break anything in 4.4 that includes module.h for exception table stuff.

Why? <linux/module.h> still includes the new <linux/extable.h>, so existing users of <linux/module.h.> should be fine.

You are correct, of course. I missed the inclusion of extable.h by that commit.

Would adding 0ef7653797addea8 to the list of v4.4 patches be acceptable, Uli? No functional change as a result of that commit.

Cheers,

    Michael

Quoted 7 lines

Plain v4.4 + these two commits seems to build fine for me (modulo the issues due to my cross-compiler being too new for v4.4 ;-).

Gr{oetje,eeting}s,

Geert

#6 lore raw
Quoted 4 lines · CET Michael Schmitz

Would adding 0ef7653797addea8 to the list of v4.4 patches be acceptable, Uli? No functional change as a result of that commit.

If the issue can be fixed within arch/m68k, we would strongly prefer that, I think.

CU
Uli

#7 lore raw

Hi Uli,

Quoted 4 lines · Ulrich Hecht
Quoted 3 lines · CET Michael Schmitz

Would adding 0ef7653797addea8 to the list of v4.4 patches be acceptable, Uli? No functional change as a result of that commit.

If the issue can be fixed within arch/m68k, we would strongly prefer that, I think.

Fair enough. Patch just went out (compile tested only so far).

Cheers,

    Michael

Quoted 3 lines

CU
Uli

#9 lore raw

Uli,

Am 31.01.2024 um 15:21 schrieb Ulrich Hecht:

Quoted 6 lines
Quoted 4 lines · CET Michael Schmitz

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

Please send patches for 4.4.y-st and 4.4.y-cip kernels to [email protected]. Thank you!

Just to make certain there is no misunderstanding: these patches will be applied to 4.4 kernels only? I.e., not applied to later upstream kernels?

Cheers,

Michael

Quoted 4 lines

CU
Uli

#10 lore raw
Quoted 12 lines · CET Michael Schmitz

Am 31.01.2024 um 15:21 schrieb Ulrich Hecht:

Quoted 6 lines
Quoted 4 lines · CET Michael Schmitz

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

Please send patches for 4.4.y-st and 4.4.y-cip kernels to [email protected]. Thank you!

Just to make certain there is no misunderstanding: these patches will be applied to 4.4 kernels only? I.e., not applied to later upstream kernels?

Correct.

CU
Uli

#11 lore raw
Quoted 11 lines · CET Ulrich Hecht
Quoted 9 lines · CET Michael Schmitz

Am 31.01.2024 um 15:21 schrieb Ulrich Hecht:

Quoted 5 lines
Quoted 4 lines · CET Michael Schmitz

The latter, for preference. Thanks for spotting that. Where would I send such a patch?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Please send patches for 4.4.y-st and 4.4.y-cip kernels to [email protected]. Thank you!

Just to make certain there is no misunderstanding: these patches will be applied to 4.4 kernels only? I.e., not applied to later upstream kernels?

Correct.

Actually, they will not be applied to _upstream_ kernels, but please do mark them as 4.4 only, so they don't accidentally get picked up for _CIP_ kernels >4.4. Sorry for any confusion that may have caused.

CU
Uli