Skip to contentSkip to conversation

test-runner: increase RAM for valgrind

PATCH Applied James Prestwood 2 participants 2 messages May 3, 2021 – May 4, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-runner: increase RAM for valgrind

Certain tests like testAP spawn two IWD process in separate namespaces. When --valrind is used this eats up quite a bit of RAM and causes the VM to run out of memory and start killing off processes.

---
 tools/test-runner | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
tools/test-runner +10 -2
index b890b3e7..dd4cbf82 100755
@@ -1570,7 +1570,15 @@ class Main:
 		else:
 			smp = int(nproc / 2)
 
-		print("Using %d cores for VM" % smp)
+		#
+		# Increase RAM if valgrind is being used
+		#
+		if self.args.valgrind:
+			ram = 512
+		else:
+			ram = 256
+
+		print("Using %d cores, %d RAM for VM" % (smp, ram))
 
 		#
 		# This passes through most of the command line options to
@@ -1593,7 +1601,7 @@ class Main:
 			qemu_binary,
 			'-machine', 'type=q35,accel=kvm:tcg',
 			'-nodefaults', '-no-user-config', '-monitor', 'none',
-			'-display', 'none', '-m', '256M', '-nographic', '-vga',
+			'-display', 'none', '-m', '%dM' % ram, '-nographic', '-vga',
 			'none', '-no-acpi', '-no-hpet',
 			'-no-reboot', '-fsdev',
 			'local,id=fsdev-root,path=/,readonly,security_model=none,multidevs=remap',
Signature · 1 line
2.26.2
#1 lore raw

Hi James,

Quoted 8 lines · James Prestwood

Certain tests like testAP spawn two IWD process in separate namespaces. When --valrind is used this eats up quite a bit of RAM and causes the VM to run out of memory and start killing off processes.

---
  tools/test-runner | 12 ++++++++++--
  1 file changed, 10 insertions(+), 2 deletions(-)

Applied, thanks.

Regards,
-Denis